)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d3586f9f5786b883a3390635636669ecbb62ca2d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"   context to the cell that the instance is in, so we\u0027re"},{"line_number":16,"context_line":"   needlessly doing that DB query for no reason."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"2. For reschedules during build (build_instances method) or"},{"line_number":19,"context_line":"   resize (migrate_server method), the InstanceMapping query"},{"line_number":20,"context_line":"   in targets_cell is an \"up call\" to the API DB which will"},{"line_number":21,"context_line":"   fail with a CantStartEngineError if the cell conductor"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_b9cb9b1b","line":18,"range":{"start_line":18,"start_character":33,"end_line":18,"end_character":48},"updated":"2018-07-11 23:58:13.000000000","message":"This doesn\u0027t use the targets_cell method so I should remove this.","commit_id":"ad94cf79e1aef8371c822c4b4e03be4b3c8fd551"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9af802f33a56a882e9c61d2351d6d94a1529afe3","unresolved":false,"context_lines":[{"line_number":13,"context_line":"1. For existing servers (not a build), the _get_instance"},{"line_number":14,"context_line":"   method in the compute API code already targeted the"},{"line_number":15,"context_line":"   context to the cell that the instance is in, so we\u0027re"},{"line_number":16,"context_line":"   needlessly doing that DB query for no reason."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"2. For reschedules during resize (migrate_server method),"},{"line_number":19,"context_line":"   the InstanceMapping query in targets_cell is an \"up call\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_3c177949","line":16,"updated":"2018-07-12 00:39:46.000000000","message":"While it\u0027s true we target the context in the compute API, cell targeting does not persist across an RPC call -- so I don\u0027t think we\u0027ll short-circuit with this change. Note: in our unit/functional testing, the CellDatabases fixture _will_ send cell targeting over RPC (see the CheatingSerializer) but this doesn\u0027t happen in real deployments.","commit_id":"3e535ff5fdfa2a6a01d01bfba62d7b89255af0fe"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"43f67df5062fbb6f935c9572ec7fc77077cedae9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"1. For existing servers (not a build), the _get_instance"},{"line_number":14,"context_line":"   method in the compute API code already targeted the"},{"line_number":15,"context_line":"   context to the cell that the instance is in, so we\u0027re"},{"line_number":16,"context_line":"   needlessly doing that DB query for no reason."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"2. For reschedules during resize (migrate_server method),"},{"line_number":19,"context_line":"   the InstanceMapping query in targets_cell is an \"up call\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_cb91a4f3","line":16,"in_reply_to":"5f7c97a3_3b7f6d6a","updated":"2018-08-21 11:25:15.000000000","message":"Note to self: good to keep in mind.","commit_id":"3e535ff5fdfa2a6a01d01bfba62d7b89255af0fe"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f806584f5e6197d64cb4210329eab1729ac6fb03","unresolved":false,"context_lines":[{"line_number":13,"context_line":"1. For existing servers (not a build), the _get_instance"},{"line_number":14,"context_line":"   method in the compute API code already targeted the"},{"line_number":15,"context_line":"   context to the cell that the instance is in, so we\u0027re"},{"line_number":16,"context_line":"   needlessly doing that DB query for no reason."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"2. For reschedules during resize (migrate_server method),"},{"line_number":19,"context_line":"   the InstanceMapping query in targets_cell is an \"up call\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_3b7f6d6a","line":16,"in_reply_to":"5f7c97a3_3c177949","updated":"2018-07-12 15:30:58.000000000","message":"OK I forgot about that thing - and RequestContext.to_dict/from_dict doesn\u0027t handle db_connection or mq_connection. Blast!","commit_id":"3e535ff5fdfa2a6a01d01bfba62d7b89255af0fe"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9af802f33a56a882e9c61d2351d6d94a1529afe3","unresolved":false,"context_lines":[{"line_number":18,"context_line":"2. For reschedules during resize (migrate_server method),"},{"line_number":19,"context_line":"   the InstanceMapping query in targets_cell is an \"up call\""},{"line_number":20,"context_line":"   to the API DB which will fail with a CantStartEngineError"},{"line_number":21,"context_line":"   if the cell conductor is not configured for the API DB."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"This resolves both issues by simply checking to see if the"},{"line_number":24,"context_line":"context is already targeted to a cell and noops the decorator"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_1c763da5","line":21,"updated":"2018-07-12 00:39:46.000000000","message":"Since reschedules go over RPC back to conductor, the context targeting will be lost similarly and we won\u0027t do the short-circuit.","commit_id":"3e535ff5fdfa2a6a01d01bfba62d7b89255af0fe"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f806584f5e6197d64cb4210329eab1729ac6fb03","unresolved":false,"context_lines":[{"line_number":18,"context_line":"2. For reschedules during resize (migrate_server method),"},{"line_number":19,"context_line":"   the InstanceMapping query in targets_cell is an \"up call\""},{"line_number":20,"context_line":"   to the API DB which will fail with a CantStartEngineError"},{"line_number":21,"context_line":"   if the cell conductor is not configured for the API DB."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"This resolves both issues by simply checking to see if the"},{"line_number":24,"context_line":"context is already targeted to a cell and noops the decorator"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_5be90917","line":21,"in_reply_to":"5f7c97a3_1c763da5","updated":"2018-07-12 15:30:58.000000000","message":"Crap. Well, then we\u0027re kind of screwed for split MQ and resize reschedules, unless nova-compute casts to a different resize method specifically for reschedules that doesn\u0027t have the @targets_cell decorator - that\u0027s how we avoid this for reschedules during a build (compute casts to the build_instances method).","commit_id":"3e535ff5fdfa2a6a01d01bfba62d7b89255af0fe"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d681b4fd2c446678f4d1b5a79e6e6f939ba29885","unresolved":false,"context_lines":[{"line_number":18,"context_line":"2. For reschedules during resize (migrate_server method),"},{"line_number":19,"context_line":"   the InstanceMapping query in targets_cell is an \"up call\""},{"line_number":20,"context_line":"   to the API DB which will fail with a CantStartEngineError"},{"line_number":21,"context_line":"   if the cell conductor is not configured for the API DB."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"This resolves both issues by simply checking to see if the"},{"line_number":24,"context_line":"context is already targeted to a cell and noops the decorator"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_88f4675d","line":21,"in_reply_to":"5f7c97a3_5be90917","updated":"2018-08-03 22:08:58.000000000","message":"Also, we\u0027d still fail with an up-call to the DB API due to bug 1781286. Those are separate fixes though.","commit_id":"3e535ff5fdfa2a6a01d01bfba62d7b89255af0fe"}],"nova/conductor/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bdecf0479b5c8ba3bb2d30d035aee5c77dbea757","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        except exception.InstanceMappingNotFound:"},{"line_number":75,"context_line":"            LOG.error(\u0027InstanceMapping not found, unable to target cell\u0027,"},{"line_number":76,"context_line":"                      instance\u003dinstance)"},{"line_number":77,"context_line":"            im \u003d None"},{"line_number":78,"context_line":"        else:"},{"line_number":79,"context_line":"            LOG.debug(\u0027Targeting cell %(cell)s for conductor method %(meth)s\u0027,"},{"line_number":80,"context_line":"                      {\u0027cell\u0027: im.cell_mapping.identity,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_31ebb813","side":"PARENT","line":77,"range":{"start_line":77,"start_character":12,"end_line":77,"end_character":21},"updated":"2019-04-18 13:39:35.000000000","message":"This isn\u0027t used - my IDE (pycharm) shows it as dead so that\u0027s likely why I removed it; yes it\u0027s unrelated.","commit_id":"0ba34a818414823eda5e693dc2127a534410b5df"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"44ac7898a75f93f58c1458d57c0ce5c4a3d66ef1","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        except exception.InstanceMappingNotFound:"},{"line_number":75,"context_line":"            LOG.error(\u0027InstanceMapping not found, unable to target cell\u0027,"},{"line_number":76,"context_line":"                      instance\u003dinstance)"},{"line_number":77,"context_line":"            im \u003d None"},{"line_number":78,"context_line":"        else:"},{"line_number":79,"context_line":"            LOG.debug(\u0027Targeting cell %(cell)s for conductor method %(meth)s\u0027,"},{"line_number":80,"context_line":"                      {\u0027cell\u0027: im.cell_mapping.identity,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_f1f0d0ff","side":"PARENT","line":77,"updated":"2019-04-18 13:39:55.000000000","message":"Undocumented dead code removal, but I don\u0027t think it\u0027s wrong.","commit_id":"0ba34a818414823eda5e693dc2127a534410b5df"}],"nova/tests/unit/conductor/test_conductor.py":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"aa437ca6625308cdec5606629728871273fe3a91","unresolved":false,"context_lines":[{"line_number":2847,"context_line":""},{"line_number":2848,"context_line":"        @conductor_manager.targets_cell"},{"line_number":2849,"context_line":"        def test(self, context, instance):"},{"line_number":2850,"context_line":"            return mock.sentinel.iransofaraway"},{"line_number":2851,"context_line":""},{"line_number":2852,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":2853,"context_line":"        inst \u003d objects.Instance(ctxt, uuid\u003duuids.instance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_bf1cdb66","line":2850,"range":{"start_line":2850,"start_character":12,"end_line":2850,"end_character":46},"updated":"2018-07-12 01:48:30.000000000","message":"This is interesting :)","commit_id":"3e535ff5fdfa2a6a01d01bfba62d7b89255af0fe"}]}