)]}'
{"doc/v3/api_samples/flavor-extra-specs/flavor-extra-specs-update-req.xml":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"41101cee4bc2274af9638e4a75268fea50020fef","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003c?xml version\u003d\"1.0\" encoding\u003d\"UTF-8\"?\u003e"},{"line_number":2,"context_line":"\u003cextra_spec key\u003d\"key1\"\u003enew_value1\u003c/extra_spec\u003e"}],"source_content_type":"application/xml","patch_set":1,"id":"AAAATn%2F%2BKfI%3D","line":2,"updated":"2013-12-01 04:07:42.000000000","message":"the singular form here seems inconsistent with the json format","commit_id":"6018d8d3b9b8351a9d95bd1adfc88ede5ab6b136"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"36629448150f0271c2dc83e33bf5407e9c730ff6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003c?xml version\u003d\"1.0\" encoding\u003d\"UTF-8\"?\u003e"},{"line_number":2,"context_line":"\u003cextra_spec key\u003d\"key1\"\u003enew_value1\u003c/extra_spec\u003e"}],"source_content_type":"application/xml","patch_set":1,"id":"AAAATn%2F%2BIao%3D","line":2,"in_reply_to":"AAAATn%2F%2BKfI%3D","updated":"2013-12-02 08:01:19.000000000","message":"let me fix for json format","commit_id":"6018d8d3b9b8351a9d95bd1adfc88ede5ab6b136"},{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"c46486fe0c320f0e756d3a4966d553e9af422af1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003c?xml version\u003d\"1.0\" encoding\u003d\"UTF-8\"?\u003e"},{"line_number":2,"context_line":"\u003cextra_spec key\u003d\"key1\"\u003enew_value1\u003c/extra_spec\u003e"}],"source_content_type":"application/xml","patch_set":3,"id":"AAAATn%2F%2BDHQ%3D","line":2,"updated":"2013-12-03 03:19:28.000000000","message":"why not:\n\u003cextra_specs\u003e\n    \u003ckey\u003e\u003c/key\u003e\n    \u003ckey1\u003e\u003c/key1\u003e\n    ...\n\u003c/extra_specs\u003e","commit_id":"308164ba6d324b63a19aa0da922f4bcd3ded7665"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"78f75da3dca70cfcfbc9d0fa67a261498357f272","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003c?xml version\u003d\"1.0\" encoding\u003d\"UTF-8\"?\u003e"},{"line_number":2,"context_line":"\u003cextra_spec key\u003d\"key1\"\u003enew_value1\u003c/extra_spec\u003e"}],"source_content_type":"application/xml","patch_set":3,"id":"AAAATn%2F9kFU%3D","line":2,"in_reply_to":"AAAATn%2F%2BCN4%3D","updated":"2013-12-10 07:29:55.000000000","message":"GuoHui, is there any xml spec require use elements instead of attributes? So it is rule or just style?\n\nI just want api v3 consistent, like server metadata use same style:\nhttps://github.com/openstack/nova/blob/master/doc/v3/api_samples/server-metadata/server-metadata-resp.xml\n\nif there is spec or rule, I will update the patch.\nIf it is just style, I\u0027m not sure which style most of people like, maybe waiting for others review, or bring it up to ML.","commit_id":"308164ba6d324b63a19aa0da922f4bcd3ded7665"},{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"677e29017fa83083578895b9f131f5ccdcd5c49b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003c?xml version\u003d\"1.0\" encoding\u003d\"UTF-8\"?\u003e"},{"line_number":2,"context_line":"\u003cextra_spec key\u003d\"key1\"\u003enew_value1\u003c/extra_spec\u003e"}],"source_content_type":"application/xml","patch_set":3,"id":"AAAATn%2F%2BCN4%3D","line":2,"in_reply_to":"AAAATn%2F%2BCtk%3D","updated":"2013-12-03 14:28:45.000000000","message":"on the contrary, the format I commented return single resource, most important the format \u003cextra_spec key\u003d\"key1\"\u003e will make the client little bit difficult to parse the xml than single tag and doesn\u0027t comply xml spec well, I knew there are lots of similar doc exists, but this format looks really not that good IMHO.","commit_id":"308164ba6d324b63a19aa0da922f4bcd3ded7665"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c7c916fef196bf74463a4a6f86e8dacdc2cf0692","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003c?xml version\u003d\"1.0\" encoding\u003d\"UTF-8\"?\u003e"},{"line_number":2,"context_line":"\u003cextra_spec key\u003d\"key1\"\u003enew_value1\u003c/extra_spec\u003e"}],"source_content_type":"application/xml","patch_set":3,"id":"AAAATn%2F%2BCtk%3D","line":2,"in_reply_to":"AAAATn%2F%2BDHQ%3D","updated":"2013-12-03 05:45:08.000000000","message":"Just want to make it consistent.\n\nLike you update server, you request and response like this {\u0027server\u0027: ....}, it return single resource.","commit_id":"308164ba6d324b63a19aa0da922f4bcd3ded7665"},{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"83958a25ebecf22d17eb76aad9eea134cce746a5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003c?xml version\u003d\"1.0\" encoding\u003d\"UTF-8\"?\u003e"},{"line_number":2,"context_line":"\u003cextra_spec key\u003d\"key1\"\u003enew_value1\u003c/extra_spec\u003e"}],"source_content_type":"application/xml","patch_set":3,"id":"AAAATn%2F9RwM%3D","line":2,"in_reply_to":"AAAATn%2F9kFU%3D","updated":"2013-12-13 06:10:26.000000000","message":"Alex, in general element is better than attributes IMHO, if we considering it from the readability, performance aspect, but attribute has it\u0027s own advantage, like smaller size etc, so it\u0027s not only just a coding style, I still think in this case we should use element rather than attributes, but I agree with you that we need broader discussion on this, I will initial a discussion in ML, let\u0027s talking about it in ML to have a standard on xml format, thanks.","commit_id":"308164ba6d324b63a19aa0da922f4bcd3ded7665"}],"nova/api/openstack/compute/plugins/v3/flavors_extraspecs.py":[{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"c46486fe0c320f0e756d3a4966d553e9af422af1","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    def _check_body(self, body, key):"},{"line_number":68,"context_line":"        if not self.is_valid_body(body, key):"},{"line_number":69,"context_line":"            raise webob.exc.HTTPBadRequest("},{"line_number":70,"context_line":"                explanation\u003d_(\u0027Invalid request body \u0027))"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @extensions.expected_errors(())"},{"line_number":73,"context_line":"    @wsgi.serializers(xml\u003dExtraSpecsTemplate)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BDG0%3D","line":70,"updated":"2013-12-03 03:19:28.000000000","message":"there is a extra space","commit_id":"308164ba6d324b63a19aa0da922f4bcd3ded7665"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c7c916fef196bf74463a4a6f86e8dacdc2cf0692","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    def _check_body(self, body, key):"},{"line_number":68,"context_line":"        if not self.is_valid_body(body, key):"},{"line_number":69,"context_line":"            raise webob.exc.HTTPBadRequest("},{"line_number":70,"context_line":"                explanation\u003d_(\u0027Invalid request body \u0027))"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @extensions.expected_errors(())"},{"line_number":73,"context_line":"    @wsgi.serializers(xml\u003dExtraSpecsTemplate)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BCtg%3D","line":70,"in_reply_to":"AAAATn%2F%2BDG0%3D","updated":"2013-12-03 05:45:08.000000000","message":"thanks","commit_id":"308164ba6d324b63a19aa0da922f4bcd3ded7665"}]}