)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7fa62b5a186f353f775e7f1d3276d5320fe01876","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t overwrite greenthread-local context in host manager"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are a couple of places in host manager where we create a blank"},{"line_number":10,"context_line":"RequestContext for internal database operations without passing"},{"line_number":11,"context_line":"overwrite\u003dFalse, so they will overwrite the greenthread-local context"},{"line_number":12,"context_line":"that will be used for logging request_id, replacing them with newly"},{"line_number":13,"context_line":"generated request_ids."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This changes the RequestContext creations to get_admin_context calls,"},{"line_number":16,"context_line":"(which uses overwrite\u003dFalse) to be more explicit about the admin-ness"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_1cd05d1f","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":22},"updated":"2018-08-07 22:56:06.000000000","message":"Hmm, I\u0027m not seeing a difference between the logs after your change and before.\n\nThis is with your change:\n\nhttp://logs.openstack.org/32/582332/5/check/tempest-full/093effd/controller/logs/screen-n-sch.txt.gz#_Jul_31_18_51_40_268511\n\nNote the request ID is req-fe79cb75-ddaf-4d8b-aea9-3cd1b4a83ab4 and that shows up in other log messages.\n\nThis is before your change:\n\nhttp://logs.openstack.org/10/587510/2/check/tempest-full/9e96d08/controller/logs/screen-n-sch.txt.gz#_Jul_31_17_48_52_740340\n\nAnd the request Id there (req-6c722137-62a1-4e44-8b97-056459fc00b3) shows up in other log messages, so what\u0027s the difference?","commit_id":"67c761cb2c32d130bcb4bcb1c97ac65e828f6c80"}],"nova/rpc.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f3da89e48113c8df0a7ea8dfeaea6d7fdcd1d530","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        return context.to_dict()"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def deserialize_context(self, context):"},{"line_number":145,"context_line":"        return nova.context.RequestContext.from_dict(context, overwrite\u003dFalse)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"class ProfilerRequestContextSerializer(RequestContextSerializer):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_7f3756fe","line":145,"updated":"2018-07-20 15:21:54.000000000","message":"Hm, based on the latest logs, it looks like this does the opposite of what I expected. It makes us get a different request_id after we cross an RPC boundary.","commit_id":"5c6e6d8ec47bf361a9c7d8da1975f9813014d8f4"}],"nova/scheduler/host_manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7fa62b5a186f353f775e7f1d3276d5320fe01876","unresolved":false,"context_lines":[{"line_number":419,"context_line":""},{"line_number":420,"context_line":"        def _async_init_instance_info(computes_by_cell):"},{"line_number":421,"context_line":"            context \u003d context_module.get_admin_context()"},{"line_number":422,"context_line":"            LOG.debug(\"START:_async_init_instance_info\")"},{"line_number":423,"context_line":"            self._instance_info \u003d {}"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"            count \u003d 0"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_9cd30d39","line":422,"range":{"start_line":422,"start_character":12,"end_line":422,"end_character":56},"updated":"2018-08-07 22:56:06.000000000","message":"Hmm, we shouldn\u0027t even be logging in here, right? I thought logging in a greenthread was potentially very nasty.","commit_id":"67c761cb2c32d130bcb4bcb1c97ac65e828f6c80"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4fe6f494f350b83e127f85e5417e95ba7d8a3ea0","unresolved":false,"context_lines":[{"line_number":419,"context_line":""},{"line_number":420,"context_line":"        def _async_init_instance_info(computes_by_cell):"},{"line_number":421,"context_line":"            context \u003d context_module.get_admin_context()"},{"line_number":422,"context_line":"            LOG.debug(\"START:_async_init_instance_info\")"},{"line_number":423,"context_line":"            self._instance_info \u003d {}"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"            count \u003d 0"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_306937f8","line":422,"range":{"start_line":422,"start_character":12,"end_line":422,"end_character":56},"in_reply_to":"3f79a3b5_22ffce34","updated":"2019-06-13 16:11:51.000000000","message":"I guess the logging was already in here and unrelated to this change, right.","commit_id":"67c761cb2c32d130bcb4bcb1c97ac65e828f6c80"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"34c41e7f537c329b2c9aecd2c94200a56ef33e37","unresolved":false,"context_lines":[{"line_number":419,"context_line":""},{"line_number":420,"context_line":"        def _async_init_instance_info(computes_by_cell):"},{"line_number":421,"context_line":"            context \u003d context_module.get_admin_context()"},{"line_number":422,"context_line":"            LOG.debug(\"START:_async_init_instance_info\")"},{"line_number":423,"context_line":"            self._instance_info \u003d {}"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"            count \u003d 0"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_22ffce34","line":422,"range":{"start_line":422,"start_character":12,"end_line":422,"end_character":56},"in_reply_to":"3f79a3b5_9cd30d39","updated":"2018-09-18 12:21:24.000000000","message":"Seem unrelated, though I thought basically everything was a greenthread (Although I remember some worries around greenthreads and exception blocks, logging and loosing context, although I thought that had been fixed).","commit_id":"67c761cb2c32d130bcb4bcb1c97ac65e828f6c80"}]}