)]}'
{"nova/availability_zones.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c798fd2e3171ff18cf0e28eccd88d36df3db350e","unresolved":false,"context_lines":[{"line_number":165,"context_line":"def get_instance_availability_zone(context, instance):"},{"line_number":166,"context_line":"    \"\"\"Return availability zone of specified instance.\"\"\""},{"line_number":167,"context_line":"    host \u003d instance.host if \u0027host\u0027 in instance else None"},{"line_number":168,"context_line":"    if not host or (host and instance.availability_zone):"},{"line_number":169,"context_line":"        # If host is None, we likely haven\u0027t reached a viable compute node yet"},{"line_number":170,"context_line":"        # so give back the desired availability_zone in the instance record if"},{"line_number":171,"context_line":"        # the boot request specified one."}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_1140d231","line":168,"range":{"start_line":168,"start_character":4,"end_line":168,"end_character":57},"updated":"2018-07-18 16:34:07.000000000","message":"Can this just be simplified to:\n\nif instance.availability_zone:\n\n?","commit_id":"87717e1a5d23aca4a66541134cc2333dd7bcac87"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5cfa835d2e62f9da651935c090196c9a58c69f6c","unresolved":false,"context_lines":[{"line_number":165,"context_line":"def get_instance_availability_zone(context, instance):"},{"line_number":166,"context_line":"    \"\"\"Return availability zone of specified instance.\"\"\""},{"line_number":167,"context_line":"    host \u003d instance.host if \u0027host\u0027 in instance else None"},{"line_number":168,"context_line":"    if not host or (host and instance.availability_zone):"},{"line_number":169,"context_line":"        # If host is None, we likely haven\u0027t reached a viable compute node yet"},{"line_number":170,"context_line":"        # so give back the desired availability_zone in the instance record if"},{"line_number":171,"context_line":"        # the boot request specified one."}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_c766f728","line":168,"range":{"start_line":168,"start_character":4,"end_line":168,"end_character":57},"in_reply_to":"5f7c97a3_1140d231","updated":"2018-07-19 20:40:27.000000000","message":"Hmm, this might have implications for how the API works, see bug 1782539. Do we set the instance.availability_zone to \u0027nova\u0027 during scheduling if the host is not in an aggregate and then later added to one?","commit_id":"87717e1a5d23aca4a66541134cc2333dd7bcac87"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"eb1028215fb965086d863ddb87cffabcf2e26814","unresolved":false,"context_lines":[{"line_number":165,"context_line":"def get_instance_availability_zone(context, instance):"},{"line_number":166,"context_line":"    \"\"\"Return availability zone of specified instance.\"\"\""},{"line_number":167,"context_line":"    host \u003d instance.host if \u0027host\u0027 in instance else None"},{"line_number":168,"context_line":"    if not host or (host and instance.availability_zone):"},{"line_number":169,"context_line":"        # If host is None, we likely haven\u0027t reached a viable compute node yet"},{"line_number":170,"context_line":"        # so give back the desired availability_zone in the instance record if"},{"line_number":171,"context_line":"        # the boot request specified one."}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_f1416ca8","line":168,"range":{"start_line":168,"start_character":4,"end_line":168,"end_character":57},"in_reply_to":"5f7c97a3_931da178","updated":"2018-07-20 02:10:16.000000000","message":"+1","commit_id":"87717e1a5d23aca4a66541134cc2333dd7bcac87"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"eb1028215fb965086d863ddb87cffabcf2e26814","unresolved":false,"context_lines":[{"line_number":165,"context_line":"def get_instance_availability_zone(context, instance):"},{"line_number":166,"context_line":"    \"\"\"Return availability zone of specified instance.\"\"\""},{"line_number":167,"context_line":"    host \u003d instance.host if \u0027host\u0027 in instance else None"},{"line_number":168,"context_line":"    if not host or (host and instance.availability_zone):"},{"line_number":169,"context_line":"        # If host is None, we likely haven\u0027t reached a viable compute node yet"},{"line_number":170,"context_line":"        # so give back the desired availability_zone in the instance record if"},{"line_number":171,"context_line":"        # the boot request specified one."}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_712ebcf9","line":168,"range":{"start_line":168,"start_character":4,"end_line":168,"end_character":57},"in_reply_to":"5f7c97a3_c766f728","updated":"2018-07-20 02:10:16.000000000","message":"+1","commit_id":"87717e1a5d23aca4a66541134cc2333dd7bcac87"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a842ad8063a282cd13f208c6573f08bb0cedd326","unresolved":false,"context_lines":[{"line_number":165,"context_line":"def get_instance_availability_zone(context, instance):"},{"line_number":166,"context_line":"    \"\"\"Return availability zone of specified instance.\"\"\""},{"line_number":167,"context_line":"    host \u003d instance.host if \u0027host\u0027 in instance else None"},{"line_number":168,"context_line":"    if not host or (host and instance.availability_zone):"},{"line_number":169,"context_line":"        # If host is None, we likely haven\u0027t reached a viable compute node yet"},{"line_number":170,"context_line":"        # so give back the desired availability_zone in the instance record if"},{"line_number":171,"context_line":"        # the boot request specified one."}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_931da178","line":168,"range":{"start_line":168,"start_character":4,"end_line":168,"end_character":57},"in_reply_to":"5f7c97a3_c766f728","updated":"2018-07-19 23:36:58.000000000","message":"I likely need to write a functional test for the scenario in bug 1782539 to make sure I don\u0027t break something there.","commit_id":"87717e1a5d23aca4a66541134cc2333dd7bcac87"}]}