)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"349dd2d0115fa6c6bc90f67271b90132130fa11f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"whether that approach might cause unintended effects where service"},{"line_number":22,"context_line":"information that used to be viewable for instances becomes hidden."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-Bug: #1778305"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I347096a527c257075cefe7b81210622f6cd87daf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_9a679253","line":24,"updated":"2018-07-12 23:11:02.000000000","message":"Looks like we need to add bug 1764556 here too. Need to add another regression test to this stack for it.","commit_id":"644d235c569e7be4f04d31f80c2a8467660ec1b6"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ad9f2509c74b62bfd431b3510f075c31effa6b6b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This causes a problem in the scenario where an operator upgrades their"},{"line_number":14,"context_line":"cluster and has old, deleted services with hostnames matching existing"},{"line_number":15,"context_line":"services associated with instances. When we go to generate the service"},{"line_number":16,"context_line":"UUID for the old, deleted service, we hit a ServiceTooOld exception."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This addresses the problem by not bothering to generate a UUID for a"},{"line_number":19,"context_line":"deleted service. One alternative would be to exclude deleted services"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_7535db42","line":16,"updated":"2018-07-13 14:29:22.000000000","message":"In a similar scenario where a current version deleted service shares the same hostname as a current version non-deleted service associated with an instance, an attempt to list instances will result in a ServiceNotFound exception when we try to generate a UUID for the deleted service.","commit_id":"4153bfc10f4f4bdac1f4d89f31be10d9b1545577"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cb41bf96ca21b64c71f2cb910d4fff014e958458","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This addresses the problem by not bothering to generate a UUID for a"},{"line_number":19,"context_line":"deleted service. One alternative would be to exclude deleted services"},{"line_number":20,"context_line":"when we join the \u0027instances\u0027 and \u0027services\u0027 tables, but I\u0027m not sure"},{"line_number":21,"context_line":"whether that approach might cause unintended effects where service"},{"line_number":22,"context_line":"information that used to be viewable for instances becomes hidden."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-Bug: #1778305"},{"line_number":25,"context_line":"Closes-Bug: #1764556"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_b020619c","line":22,"range":{"start_line":20,"start_character":52,"end_line":22,"end_character":66},"updated":"2018-07-13 14:44:13.000000000","message":"Like for instances that exist before we stopped allowing admins to delete services that were hosting instances? So in the before times, admins could delete a compute service even though it had instances on it, then restart the service which would create a new service record, so then the instance would be linked to \u003e1 service record (by host) where one was deleted and one wasn\u0027t.","commit_id":"4153bfc10f4f4bdac1f4d89f31be10d9b1545577"}],"nova/objects/service.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cb41bf96ca21b64c71f2cb910d4fff014e958458","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        service.obj_reset_changes()"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        # TODO(dpeschman): Drop this once all services have uuids in database"},{"line_number":267,"context_line":"        if \u0027uuid\u0027 not in service and not service.deleted:"},{"line_number":268,"context_line":"            service.uuid \u003d uuidutils.generate_uuid()"},{"line_number":269,"context_line":"            LOG.debug(\u0027Generated UUID %(uuid)s for service %(id)i\u0027,"},{"line_number":270,"context_line":"                      dict(uuid\u003dservice.uuid, id\u003dservice.id))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_302c5192","line":267,"range":{"start_line":267,"start_character":33,"end_line":267,"end_character":56},"updated":"2018-07-13 14:44:13.000000000","message":"I would leave a comment here.","commit_id":"4153bfc10f4f4bdac1f4d89f31be10d9b1545577"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0fa49917635b604a14f55597e42ec3064a16b654","unresolved":false,"context_lines":[{"line_number":385,"context_line":"    def save(self):"},{"line_number":386,"context_line":"        updates \u003d self.obj_get_changes()"},{"line_number":387,"context_line":"        updates.pop(\u0027id\u0027, None)"},{"line_number":388,"context_line":"        self._check_minimum_version()"},{"line_number":389,"context_line":"        db_service \u003d db.service_update(self._context, self.id, updates)"},{"line_number":390,"context_line":"        self._from_db_object(self._context, self, db_service)"},{"line_number":391,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_606be4b8","line":388,"range":{"start_line":388,"start_character":13,"end_line":388,"end_character":35},"updated":"2018-07-13 01:38:18.000000000","message":"This will raise ServiceTooOld if called on a deleted service with too old a version.","commit_id":"4153bfc10f4f4bdac1f4d89f31be10d9b1545577"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0fa49917635b604a14f55597e42ec3064a16b654","unresolved":false,"context_lines":[{"line_number":386,"context_line":"        updates \u003d self.obj_get_changes()"},{"line_number":387,"context_line":"        updates.pop(\u0027id\u0027, None)"},{"line_number":388,"context_line":"        self._check_minimum_version()"},{"line_number":389,"context_line":"        db_service \u003d db.service_update(self._context, self.id, updates)"},{"line_number":390,"context_line":"        self._from_db_object(self._context, self, db_service)"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"        self._send_status_update_notification(updates)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_a071fcad","line":389,"range":{"start_line":389,"start_character":24,"end_line":389,"end_character":38},"updated":"2018-07-13 01:38:18.000000000","message":"This will raise ServiceNotFound if called on a deleted service.","commit_id":"4153bfc10f4f4bdac1f4d89f31be10d9b1545577"}]}