)]}'
{"nova/conductor/manager.py":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"6ea00e181e2bf3669c64e1efaf39d9df97e59149","unresolved":false,"context_lines":[{"line_number":586,"context_line":"            # compute, \"retry\" will be set and num_attempts will be \u003e1 because"},{"line_number":587,"context_line":"            # populate_retry above will increment it. If the server build was"},{"line_number":588,"context_line":"            # forced onto a host/node or [scheduler]/max_attempts\u003d1, \"retry\""},{"line_number":589,"context_line":"            # won\u0027t be in filter_properties and we won\u0027t get here on a"},{"line_number":590,"context_line":"            # reschedule because nova-compute will just abort the build since"},{"line_number":591,"context_line":"            # reschedules are disabled in those cases."},{"line_number":592,"context_line":"            num_attempts \u003d filter_properties.get("},{"line_number":593,"context_line":"                \u0027retry\u0027, {}).get(\u0027num_attempts\u0027, 1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_715dea7a","line":590,"range":{"start_line":589,"start_character":66,"end_line":590,"end_character":24},"updated":"2018-07-13 18:23:33.000000000","message":"I\u0027d take out the \"on a reschedule\" bit because the point is that there won\u0027t be a reschedule.","commit_id":"80dec373408eaa4552ef5dff4a545fe5b2803c14"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6bf3a9614bfe42420104cc786ef4505b38ea3705","unresolved":false,"context_lines":[{"line_number":586,"context_line":"            # compute, \"retry\" will be set and num_attempts will be \u003e1 because"},{"line_number":587,"context_line":"            # populate_retry above will increment it. If the server build was"},{"line_number":588,"context_line":"            # forced onto a host/node or [scheduler]/max_attempts\u003d1, \"retry\""},{"line_number":589,"context_line":"            # won\u0027t be in filter_properties and we won\u0027t get here on a"},{"line_number":590,"context_line":"            # reschedule because nova-compute will just abort the build since"},{"line_number":591,"context_line":"            # reschedules are disabled in those cases."},{"line_number":592,"context_line":"            num_attempts \u003d filter_properties.get("},{"line_number":593,"context_line":"                \u0027retry\u0027, {}).get(\u0027num_attempts\u0027, 1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_68b6508c","line":590,"range":{"start_line":589,"start_character":66,"end_line":590,"end_character":24},"in_reply_to":"5f7c97a3_715dea7a","updated":"2018-07-14 12:38:20.000000000","message":"Done","commit_id":"80dec373408eaa4552ef5dff4a545fe5b2803c14"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"d55c31a30074292f935d93e93e7de51d2475ae7e","unresolved":false,"context_lines":[{"line_number":582,"context_line":"                host_lists \u003d self._schedule_instances(context, spec_obj,"},{"line_number":583,"context_line":"                        instance_uuids, return_alternates\u003dTrue)"},{"line_number":584,"context_line":"        except Exception as exc:"},{"line_number":585,"context_line":"            # NOTE(mriedem): If we\u0027re rescheduling from a failed build on a"},{"line_number":586,"context_line":"            # compute, \"retry\" will be set and num_attempts will be \u003e1 because"},{"line_number":587,"context_line":"            # populate_retry above will increment it. If the server build was"},{"line_number":588,"context_line":"            # forced onto a host/node or [scheduler]/max_attempts\u003d1, \"retry\""},{"line_number":589,"context_line":"            # won\u0027t be in filter_properties and we won\u0027t get here because"},{"line_number":590,"context_line":"            # nova-compute will just abort the build since reschedules are"},{"line_number":591,"context_line":"            # disabled in those cases."},{"line_number":592,"context_line":"            num_attempts \u003d filter_properties.get("},{"line_number":593,"context_line":"                \u0027retry\u0027, {}).get(\u0027num_attempts\u0027, 1)"},{"line_number":594,"context_line":"            updates \u003d {\u0027vm_state\u0027: vm_states.ERROR, \u0027task_state\u0027: None}"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_23494d65","line":591,"range":{"start_line":585,"start_character":12,"end_line":591,"end_character":38},"updated":"2018-07-16 07:36:31.000000000","message":"++\nthen this logic is error leading as we are sure retry and num_attempts will be set if we enter here?\n\nnum_attempts \u003d filter_properties.get(\n                \u0027retry\u0027, {}).get(\u0027num_attempts\u0027, 1)","commit_id":"276130c6d1637f8e0f39ba274e2619a115a8fa1a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4df808fe41aa00cf2e88b5b24498b4ac13fcfe54","unresolved":false,"context_lines":[{"line_number":582,"context_line":"                host_lists \u003d self._schedule_instances(context, spec_obj,"},{"line_number":583,"context_line":"                        instance_uuids, return_alternates\u003dTrue)"},{"line_number":584,"context_line":"        except Exception as exc:"},{"line_number":585,"context_line":"            # NOTE(mriedem): If we\u0027re rescheduling from a failed build on a"},{"line_number":586,"context_line":"            # compute, \"retry\" will be set and num_attempts will be \u003e1 because"},{"line_number":587,"context_line":"            # populate_retry above will increment it. If the server build was"},{"line_number":588,"context_line":"            # forced onto a host/node or [scheduler]/max_attempts\u003d1, \"retry\""},{"line_number":589,"context_line":"            # won\u0027t be in filter_properties and we won\u0027t get here because"},{"line_number":590,"context_line":"            # nova-compute will just abort the build since reschedules are"},{"line_number":591,"context_line":"            # disabled in those cases."},{"line_number":592,"context_line":"            num_attempts \u003d filter_properties.get("},{"line_number":593,"context_line":"                \u0027retry\u0027, {}).get(\u0027num_attempts\u0027, 1)"},{"line_number":594,"context_line":"            updates \u003d {\u0027vm_state\u0027: vm_states.ERROR, \u0027task_state\u0027: None}"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_dc35aedc","line":591,"range":{"start_line":585,"start_character":12,"end_line":591,"end_character":38},"in_reply_to":"5f7c97a3_23494d65","updated":"2018-07-17 16:44:09.000000000","message":"I\u0027m not sure I understand your point, but are you asking that we change that to this?\n\nnum_attempts \u003d filter_properties[\u0027retry\u0027][\u0027num_attempts\u0027]\n\nI think we could probably do that given those keys should always be set at this point if we\u0027re rescheduling, but we\u0027d need to account for the is_reschedule flag probably because populate_retry won\u0027t set the \u0027retry\u0027 flag if we\u0027re forcing a host/node or CONF.scheduler.max_attempts\u003d1 - and we can\u0027t get here from a scheduler filter that\u0027s not due to a retry if using cells v1. So it\u0027s probably just simpler to leave the .get() calls here for defaults.","commit_id":"276130c6d1637f8e0f39ba274e2619a115a8fa1a"}]}