)]}'
{"nova/api/openstack/placement/objects/resource_provider.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"9e30a562fee75c2b1d5e7bd4dfeeb6a5c201c334","unresolved":false,"context_lines":[{"line_number":4095,"context_line":""},{"line_number":4096,"context_line":"    # And finally, we can set the inventories to their actual desired state."},{"line_number":4097,"context_line":"    for new_inv_list in inventories.values():"},{"line_number":4098,"context_line":"        # NB: If we wanted this to be more efficient, we could keep track of"},{"line_number":4099,"context_line":"        # inventories to delete in the above loop and just do those and skip"},{"line_number":4100,"context_line":"        # the rest, since they\u0027re already in their final form."},{"line_number":4101,"context_line":"        new_inv_list[0].resource_provider.set_inventory(new_inv_list)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_9febeddb","line":4100,"range":{"start_line":4098,"start_character":9,"end_line":4100,"end_character":62},"updated":"2018-07-13 19:37:22.000000000","message":"as long as you\u0027re using set_inventory(), you\u0027re blowing away all the existing records anyway so I don\u0027t see how that would be any more efficient than you have here.","commit_id":"99186397f0f679569e815d3d14249a06c069a4af"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9d4acf394200977d61ef23c355036deac2ff292f","unresolved":false,"context_lines":[{"line_number":4095,"context_line":""},{"line_number":4096,"context_line":"    # And finally, we can set the inventories to their actual desired state."},{"line_number":4097,"context_line":"    for new_inv_list in inventories.values():"},{"line_number":4098,"context_line":"        # NB: If we wanted this to be more efficient, we could keep track of"},{"line_number":4099,"context_line":"        # inventories to delete in the above loop and just do those and skip"},{"line_number":4100,"context_line":"        # the rest, since they\u0027re already in their final form."},{"line_number":4101,"context_line":"        new_inv_list[0].resource_provider.set_inventory(new_inv_list)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_7f4a9182","line":4100,"range":{"start_line":4098,"start_character":9,"end_line":4100,"end_character":62},"in_reply_to":"5f7c97a3_7f8db127","updated":"2018-07-13 20:04:03.000000000","message":"Note that it\u0027s possible some or all resource providers will have their generations incremented by two with this approach. But that\u0027s okay, since the generation is supposed to be opaque.","commit_id":"99186397f0f679569e815d3d14249a06c069a4af"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9959130a0550125fac9f07516f30fb7405e97c26","unresolved":false,"context_lines":[{"line_number":4095,"context_line":""},{"line_number":4096,"context_line":"    # And finally, we can set the inventories to their actual desired state."},{"line_number":4097,"context_line":"    for new_inv_list in inventories.values():"},{"line_number":4098,"context_line":"        # NB: If we wanted this to be more efficient, we could keep track of"},{"line_number":4099,"context_line":"        # inventories to delete in the above loop and just do those and skip"},{"line_number":4100,"context_line":"        # the rest, since they\u0027re already in their final form."},{"line_number":4101,"context_line":"        new_inv_list[0].resource_provider.set_inventory(new_inv_list)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_7f8db127","line":4100,"range":{"start_line":4098,"start_character":9,"end_line":4100,"end_character":62},"in_reply_to":"5f7c97a3_9febeddb","updated":"2018-07-13 19:40:41.000000000","message":"Ah, true; but we could keep track of providers with no deletions and just skip those providers entirely.","commit_id":"99186397f0f679569e815d3d14249a06c069a4af"}]}