)]}'
{"nova/api/openstack/compute/keypairs.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8ef85639fda656c98632c3965c07230cff8acca9","unresolved":false,"context_lines":[{"line_number":297,"context_line":"            db_server \u003d req.get_db_instance(server[\u0027id\u0027])"},{"line_number":298,"context_line":"            # server[\u0027id\u0027] is guaranteed to be in the cache due to"},{"line_number":299,"context_line":"            # the core API adding it in its \u0027show\u0027/\u0027detail\u0027 methods."},{"line_number":300,"context_line":"            server[\u0027key_name\u0027] \u003d db_server[\u0027key_name\u0027]"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    def _show(self, req, resp_obj):"},{"line_number":303,"context_line":"        if \u0027server\u0027 in resp_obj.obj:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_ae9862cb","line":300,"updated":"2018-07-20 13:11:49.000000000","message":"Why can\u0027t we move this into the server view builder to centralize the server view builder response body generation and remove this code?","commit_id":"a66aabb4d8bf47262c2dbf6c8235efff9a87375c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"46bebefa4b1f85bdd9f26926eeb90766e350cc32","unresolved":false,"context_lines":[{"line_number":297,"context_line":"            db_server \u003d req.get_db_instance(server[\u0027id\u0027])"},{"line_number":298,"context_line":"            # server[\u0027id\u0027] is guaranteed to be in the cache due to"},{"line_number":299,"context_line":"            # the core API adding it in its \u0027show\u0027/\u0027detail\u0027 methods."},{"line_number":300,"context_line":"            server[\u0027key_name\u0027] \u003d db_server[\u0027key_name\u0027]"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    def _show(self, req, resp_obj):"},{"line_number":303,"context_line":"        if \u0027server\u0027 in resp_obj.obj:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_61732fb5","line":300,"in_reply_to":"5f7c97a3_49650848","updated":"2018-07-21 02:44:12.000000000","message":"yeah. this will be merged in separate series.","commit_id":"a66aabb4d8bf47262c2dbf6c8235efff9a87375c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3997fcbd03e7be75a6d02e8739d3a83c463b6ac8","unresolved":false,"context_lines":[{"line_number":297,"context_line":"            db_server \u003d req.get_db_instance(server[\u0027id\u0027])"},{"line_number":298,"context_line":"            # server[\u0027id\u0027] is guaranteed to be in the cache due to"},{"line_number":299,"context_line":"            # the core API adding it in its \u0027show\u0027/\u0027detail\u0027 methods."},{"line_number":300,"context_line":"            server[\u0027key_name\u0027] \u003d db_server[\u0027key_name\u0027]"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    def _show(self, req, resp_obj):"},{"line_number":303,"context_line":"        if \u0027server\u0027 in resp_obj.obj:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_49650848","line":300,"in_reply_to":"5f7c97a3_ae9862cb","updated":"2018-07-20 14:08:47.000000000","message":"View builder changes will come in another cleanup phase so this will happen separately.","commit_id":"a66aabb4d8bf47262c2dbf6c8235efff9a87375c"}],"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8ef85639fda656c98632c3965c07230cff8acca9","unresolved":false,"context_lines":[{"line_number":431,"context_line":"        # keypair create. But we didn\u0027t strip spaces at here for"},{"line_number":432,"context_line":"        # backward-compatible some users already created keypair and name with"},{"line_number":433,"context_line":"        # leading/trailing spaces by legacy v2 API."},{"line_number":434,"context_line":"        create_kwargs[\u0027key_name\u0027] \u003d server_dict.get(\u0027key_name\u0027)"},{"line_number":435,"context_line":"        security_groups \u003d server_dict.get(\u0027security_groups\u0027)"},{"line_number":436,"context_line":"        if security_groups is not None:"},{"line_number":437,"context_line":"            create_kwargs[\u0027security_groups\u0027] \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_6e9ecab7","line":434,"updated":"2018-07-20 13:11:49.000000000","message":"Why not do this in our helpers translation method?\n\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/helpers.py#L55","commit_id":"a66aabb4d8bf47262c2dbf6c8235efff9a87375c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3997fcbd03e7be75a6d02e8739d3a83c463b6ac8","unresolved":false,"context_lines":[{"line_number":431,"context_line":"        # keypair create. But we didn\u0027t strip spaces at here for"},{"line_number":432,"context_line":"        # backward-compatible some users already created keypair and name with"},{"line_number":433,"context_line":"        # leading/trailing spaces by legacy v2 API."},{"line_number":434,"context_line":"        create_kwargs[\u0027key_name\u0027] \u003d server_dict.get(\u0027key_name\u0027)"},{"line_number":435,"context_line":"        security_groups \u003d server_dict.get(\u0027security_groups\u0027)"},{"line_number":436,"context_line":"        if security_groups is not None:"},{"line_number":437,"context_line":"            create_kwargs[\u0027security_groups\u0027] \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_69556451","line":434,"in_reply_to":"5f7c97a3_6e9ecab7","updated":"2018-07-20 14:08:47.000000000","message":"We can merge this and sort out what should move into the helpers method in a follow up cleanup patch.","commit_id":"a66aabb4d8bf47262c2dbf6c8235efff9a87375c"}]}