)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"ab81e9df63f05bc3ad335ac39a634b7c0d24594d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"re-scheduling case multiple events with the same event name of"},{"line_number":13,"context_line":"\u0027schedule\u0027 could be generated under the same action id."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This change switchs to use action_event_update interface to always"},{"line_number":16,"context_line":"update an event referenced by event id. Also change action_event_start"},{"line_number":17,"context_line":"to action_event_create call, since the former one implicitly implies"},{"line_number":18,"context_line":"a subsequent \u0027finish\u0027 call which is not the case any more."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAUH%2F%2Fv%2Bc%3D","line":15,"updated":"2014-01-08 22:15:38.000000000","message":"switches","commit_id":"7220cc6bcfaf98d9948e0b097411c5704f1ca1d7"}],"nova/compute/utils.py":[{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"86423acf8e205de09a1e270c8d7fdc93bd8177c9","unresolved":false,"context_lines":[{"line_number":447,"context_line":"            event \u003d pack_action_event_start(self.context, uuid,"},{"line_number":448,"context_line":"                                            self.event_name)"},{"line_number":449,"context_line":"            event_ref \u003d self.conductor.action_event_start(self.context, event)"},{"line_number":450,"context_line":"            self.instance_event_map.update({uuid: event_ref.get(\u0027id\u0027, None)})"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        return self"},{"line_number":453,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BekA%3D","line":450,"updated":"2013-11-25 17:09:56.000000000","message":"by default get method return None, so we don\u0027t need it explicitly","commit_id":"7812d0652e5a349b89f9362ae0f0635a47887d9e"},{"author":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"change_message_id":"420d6d2bdfb0a84995bbfb3c4ec1360fdc3a4678","unresolved":false,"context_lines":[{"line_number":447,"context_line":"            event \u003d pack_action_event_start(self.context, uuid,"},{"line_number":448,"context_line":"                                            self.event_name)"},{"line_number":449,"context_line":"            event_ref \u003d self.conductor.action_event_start(self.context, event)"},{"line_number":450,"context_line":"            self.instance_event_map.update({uuid: event_ref.get(\u0027id\u0027, None)})"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        return self"},{"line_number":453,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BeZo%3D","line":450,"in_reply_to":"AAAATn%2F%2BekA%3D","updated":"2013-11-25 17:36:54.000000000","message":"Gaohui, thank you so much for pointing out. I\u0027d rather treated as a coding style choice, which (explicitly specify default value of None) exists many places in Nova code.","commit_id":"7812d0652e5a349b89f9362ae0f0635a47887d9e"},{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"86423acf8e205de09a1e270c8d7fdc93bd8177c9","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        for uuid in self.instance_uuids:"},{"line_number":456,"context_line":"            event \u003d pack_action_event_finish(self.context, uuid,"},{"line_number":457,"context_line":"                                             self.event_name, exc_val, exc_tb)"},{"line_number":458,"context_line":"            event.update({\u0027event_id\u0027: self.instance_event_map.get(uuid, None)})"},{"line_number":459,"context_line":"            self.conductor.action_event_finish(self.context, event)"},{"line_number":460,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Bej4%3D","line":458,"updated":"2013-11-25 17:09:56.000000000","message":"ditto","commit_id":"7812d0652e5a349b89f9362ae0f0635a47887d9e"},{"author":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"change_message_id":"420d6d2bdfb0a84995bbfb3c4ec1360fdc3a4678","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        for uuid in self.instance_uuids:"},{"line_number":456,"context_line":"            event \u003d pack_action_event_finish(self.context, uuid,"},{"line_number":457,"context_line":"                                             self.event_name, exc_val, exc_tb)"},{"line_number":458,"context_line":"            event.update({\u0027event_id\u0027: self.instance_event_map.get(uuid, None)})"},{"line_number":459,"context_line":"            self.conductor.action_event_finish(self.context, event)"},{"line_number":460,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BeZg%3D","line":458,"in_reply_to":"AAAATn%2F%2Bej4%3D","updated":"2013-11-25 17:36:54.000000000","message":"Same above","commit_id":"7812d0652e5a349b89f9362ae0f0635a47887d9e"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"144ff157b53c15cf8d89de92d6c74d700ed5b9e5","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        for uuid in self.instance_uuids:"},{"line_number":443,"context_line":"            event \u003d pack_action_event_start(self.context, uuid,"},{"line_number":444,"context_line":"                                            self.event_name)"},{"line_number":445,"context_line":"            event_ref \u003d self.conductor.action_event_create(self.context, event)"},{"line_number":446,"context_line":"            self.instance_event_map.update({uuid: event_ref.get(\u0027id\u0027, None)})"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"        return self"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUX%2F%2F6nE%3D","line":445,"updated":"2014-02-09 23:18:08.000000000","message":"I noted in the patch before this one that I don\u0027t want to see any more db proxy methods added to conductor.  We should be adding these methods to an object in nova/objects and using the object instead.","commit_id":"35a58c0bf5279933c26e6e210c8c2fff7da3d226"}],"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"86423acf8e205de09a1e270c8d7fdc93bd8177c9","unresolved":false,"context_lines":[{"line_number":5360,"context_line":"                            filter_by(action_id\u003daction[\u0027id\u0027]).\\"},{"line_number":5361,"context_line":"                            filter_by(event\u003dvalues[\u0027event\u0027])"},{"line_number":5362,"context_line":""},{"line_number":5363,"context_line":"        event_id \u003d values.get(\u0027event_id\u0027, None)"},{"line_number":5364,"context_line":"        if event_id:"},{"line_number":5365,"context_line":"            query \u003d query.filter_by(id\u003devent_id)"},{"line_number":5366,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Bejw%3D","line":5363,"updated":"2013-11-25 17:09:56.000000000","message":"ditto","commit_id":"7812d0652e5a349b89f9362ae0f0635a47887d9e"},{"author":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"change_message_id":"420d6d2bdfb0a84995bbfb3c4ec1360fdc3a4678","unresolved":false,"context_lines":[{"line_number":5360,"context_line":"                            filter_by(action_id\u003daction[\u0027id\u0027]).\\"},{"line_number":5361,"context_line":"                            filter_by(event\u003dvalues[\u0027event\u0027])"},{"line_number":5362,"context_line":""},{"line_number":5363,"context_line":"        event_id \u003d values.get(\u0027event_id\u0027, None)"},{"line_number":5364,"context_line":"        if event_id:"},{"line_number":5365,"context_line":"            query \u003d query.filter_by(id\u003devent_id)"},{"line_number":5366,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BeZY%3D","line":5363,"in_reply_to":"AAAATn%2F%2Bejw%3D","updated":"2013-11-25 17:36:54.000000000","message":"Replied in utils.py. Thanks.","commit_id":"7812d0652e5a349b89f9362ae0f0635a47887d9e"}]}
