)]}'
{"nova/api/openstack/compute/config_drive.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"563d044947d6810c3214b04e68bcee40b5d3c78d","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class ConfigDriveController(wsgi.Controller):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def _add_config_drive(self, req, servers):"},{"line_number":27,"context_line":"        for server in servers:"},{"line_number":28,"context_line":"            db_server \u003d req.get_db_instance(server[\u0027id\u0027])"},{"line_number":29,"context_line":"            # server[\u0027id\u0027] is guaranteed to be in the cache due to"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_93bb5373","line":26,"updated":"2018-07-20 13:00:39.000000000","message":"See the discussion here:\n\nhttps://review.openstack.org/#/c/567785/3/nova/api/openstack/compute/config_drive.py\n\nWhy don\u0027t we also drop this code and move it to the server view builder? Then it\u0027s all centralized where we build the response body.","commit_id":"c21d6fd6ac3ef60bd1684a4caf40133315a8e34e"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"2e5ab24b5f8f6a60bdab263178ccf3d49bfaafb1","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class ConfigDriveController(wsgi.Controller):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def _add_config_drive(self, req, servers):"},{"line_number":27,"context_line":"        for server in servers:"},{"line_number":28,"context_line":"            db_server \u003d req.get_db_instance(server[\u0027id\u0027])"},{"line_number":29,"context_line":"            # server[\u0027id\u0027] is guaranteed to be in the cache due to"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_c56fb826","line":26,"in_reply_to":"5f7c97a3_93bb5373","updated":"2018-07-21 08:34:00.000000000","message":"+1 it would be nice if everything is moved to the server view builder.","commit_id":"c21d6fd6ac3ef60bd1684a4caf40133315a8e34e"}],"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"864030c3c1a0c1c8389fcd3ccf8168e35407b3d3","unresolved":false,"context_lines":[{"line_number":430,"context_line":"        # backward-compatible some users already created keypair and name with"},{"line_number":431,"context_line":"        # leading/trailing spaces by legacy v2 API."},{"line_number":432,"context_line":"        create_kwargs[\u0027key_name\u0027] \u003d server_dict.get(\u0027key_name\u0027)"},{"line_number":433,"context_line":"        create_kwargs[\u0027config_drive\u0027] \u003d server_dict.get(\u0027config_drive\u0027)"},{"line_number":434,"context_line":"        security_groups \u003d server_dict.get(\u0027security_groups\u0027)"},{"line_number":435,"context_line":"        if security_groups is not None:"},{"line_number":436,"context_line":"            create_kwargs[\u0027security_groups\u0027] \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_2eda1278","line":433,"updated":"2018-07-20 13:12:28.000000000","message":"Do this in the helpers translation method.\n\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/helpers.py#L55","commit_id":"c21d6fd6ac3ef60bd1684a4caf40133315a8e34e"}],"nova/tests/unit/api/openstack/compute/test_serversV21.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"adcca8678bc7816d25c50b19f848723224a9d361","unresolved":false,"context_lines":[{"line_number":3524,"context_line":"    def test_create_instance_with_config_drive(self):"},{"line_number":3525,"context_line":"        param \u003d True"},{"line_number":3526,"context_line":"        self._create_instance_body_of_config_drive(param)"},{"line_number":3527,"context_line":"        self.controller.create(self.req, body\u003dself.body).obj"},{"line_number":3528,"context_line":""},{"line_number":3529,"context_line":"    def test_create_instance_with_config_drive_as_boolean_string(self):"},{"line_number":3530,"context_line":"        param \u003d \u0027false\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_761569e5","line":3527,"range":{"start_line":3527,"start_character":0,"end_line":3527,"end_character":60},"updated":"2018-07-19 08:36:03.000000000","message":"There are assertions in the original location of this test [1] to make sure the created server\u0027s UUID is as expected. I imagine this was unnecessary in the first place and definitely isn\u0027t necessary here\n\n[1] https://review.openstack.org/#/c/583538/2/nova/tests/unit/api/openstack/compute/test_config_drive.py","commit_id":"c21d6fd6ac3ef60bd1684a4caf40133315a8e34e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"13125c648213c99d86e8a853a1cc7a2aff04e0d0","unresolved":false,"context_lines":[{"line_number":3524,"context_line":"    def test_create_instance_with_config_drive(self):"},{"line_number":3525,"context_line":"        param \u003d True"},{"line_number":3526,"context_line":"        self._create_instance_body_of_config_drive(param)"},{"line_number":3527,"context_line":"        self.controller.create(self.req, body\u003dself.body).obj"},{"line_number":3528,"context_line":""},{"line_number":3529,"context_line":"    def test_create_instance_with_config_drive_as_boolean_string(self):"},{"line_number":3530,"context_line":"        param \u003d \u0027false\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_e9bbc271","line":3527,"range":{"start_line":3527,"start_character":0,"end_line":3527,"end_character":60},"in_reply_to":"5f7c97a3_761569e5","updated":"2018-07-20 01:21:38.000000000","message":"yeah, no error on create is enough here.","commit_id":"c21d6fd6ac3ef60bd1684a4caf40133315a8e34e"}]}