)]}'
{"nova/api/openstack/compute/block_device_mapping.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9756c5cb5f50f4b580d019f94a96b0d76863ac19","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# parameter as this is placed to handle scheduler_hint extension for V2.1."},{"line_number":30,"context_line":"def server_create(server_dict, create_kwargs, body_deprecated_param):"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    # Have to check whether --image is given, see bug 1433609"},{"line_number":33,"context_line":"    image_href \u003d server_dict.get(\u0027imageRef\u0027)"},{"line_number":34,"context_line":"    image_uuid_specified \u003d image_href is not None"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_c9635818","side":"PARENT","line":32,"range":{"start_line":32,"start_character":4,"end_line":32,"end_character":61},"updated":"2018-07-20 14:15:21.000000000","message":"You dropped this comment.","commit_id":"c21d6fd6ac3ef60bd1684a4caf40133315a8e34e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dad0313b3992bcc9be08f25918f8c98d741216d6","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# parameter as this is placed to handle scheduler_hint extension for V2.1."},{"line_number":30,"context_line":"def server_create(server_dict, create_kwargs, body_deprecated_param):"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    # Have to check whether --image is given, see bug 1433609"},{"line_number":33,"context_line":"    image_href \u003d server_dict.get(\u0027imageRef\u0027)"},{"line_number":34,"context_line":"    image_uuid_specified \u003d image_href is not None"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_7a58f8f7","side":"PARENT","line":32,"range":{"start_line":32,"start_character":4,"end_line":32,"end_character":61},"in_reply_to":"5f7c97a3_c9635818","updated":"2018-10-02 02:30:59.000000000","message":"fixed in follow up patch- https://review.openstack.org/#/c/607088/","commit_id":"c21d6fd6ac3ef60bd1684a4caf40133315a8e34e"}],"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"78bb892a6dd60bde4cdc359c6744fd0f7f6cd0dd","unresolved":false,"context_lines":[{"line_number":501,"context_line":"        block_device_mapping_v2 \u003d server_dict.get(\u0027block_device_mapping_v2\u0027,"},{"line_number":502,"context_line":"                                                  [])"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"        if block_device_mapping_legacy and block_device_mapping_v2:"},{"line_number":505,"context_line":"            expl \u003d _(\u0027Using different block_device_mapping syntaxes \u0027"},{"line_number":506,"context_line":"                     \u0027is not allowed in the same request.\u0027)"},{"line_number":507,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dexpl)"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"        if block_device_mapping_legacy:"},{"line_number":510,"context_line":"            for bdm in block_device_mapping_legacy:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_f6a419ba","line":507,"range":{"start_line":504,"start_character":0,"end_line":507,"end_character":54},"updated":"2018-07-19 08:39:55.000000000","message":"I was going to say that the if-else flow we\u0027ve used here doesn\u0027t allow us to use the different syntaxes together, then I saw this and realized we (sensibly) never allowed that anyway :)","commit_id":"4ce1ef6f4a09ea0439afd3da6500e145d8847aa4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7c81bfc9a467344cd887fdc4165c30aff8e26c49","unresolved":false,"context_lines":[{"line_number":506,"context_line":"                     \u0027is not allowed in the same request.\u0027)"},{"line_number":507,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dexpl)"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"        if block_device_mapping_legacy:"},{"line_number":510,"context_line":"            for bdm in block_device_mapping_legacy:"},{"line_number":511,"context_line":"                if \u0027delete_on_termination\u0027 in bdm:"},{"line_number":512,"context_line":"                    bdm[\u0027delete_on_termination\u0027] \u003d strutils.bool_from_string("}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_8ec806a7","line":509,"updated":"2018-07-20 13:14:15.000000000","message":"This create() method is getting huge. Move this bdm stuff into the helpers method https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/helpers.py#L55 and then probably even a private method within there.","commit_id":"4ce1ef6f4a09ea0439afd3da6500e145d8847aa4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9d2bec536a7a8c6aa38ac83a070ac673690e343d","unresolved":false,"context_lines":[{"line_number":506,"context_line":"                     \u0027is not allowed in the same request.\u0027)"},{"line_number":507,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dexpl)"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"        if block_device_mapping_legacy:"},{"line_number":510,"context_line":"            for bdm in block_device_mapping_legacy:"},{"line_number":511,"context_line":"                if \u0027delete_on_termination\u0027 in bdm:"},{"line_number":512,"context_line":"                    bdm[\u0027delete_on_termination\u0027] \u003d strutils.bool_from_string("}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_01627bd9","line":509,"in_reply_to":"5f7c97a3_8ec806a7","updated":"2018-07-21 02:46:50.000000000","message":"yup, we can do that.","commit_id":"4ce1ef6f4a09ea0439afd3da6500e145d8847aa4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9756c5cb5f50f4b580d019f94a96b0d76863ac19","unresolved":false,"context_lines":[{"line_number":516,"context_line":"            # Sets the legacy_bdm flag if we got a legacy block device mapping."},{"line_number":517,"context_line":"            create_kwargs[\u0027legacy_bdm\u0027] \u003d True"},{"line_number":518,"context_line":"        elif block_device_mapping_v2:"},{"line_number":519,"context_line":"            image_href \u003d server_dict.get(\u0027imageRef\u0027)"},{"line_number":520,"context_line":"            image_uuid_specified \u003d image_href is not None"},{"line_number":521,"context_line":"            try:"},{"line_number":522,"context_line":"                block_device_mapping \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_496f48f9","line":519,"updated":"2018-07-20 14:15:21.000000000","message":"nit: You dropped the comment for this:\n\n# Have to check whether --image is given, see bug 1433609","commit_id":"4ce1ef6f4a09ea0439afd3da6500e145d8847aa4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9d2bec536a7a8c6aa38ac83a070ac673690e343d","unresolved":false,"context_lines":[{"line_number":516,"context_line":"            # Sets the legacy_bdm flag if we got a legacy block device mapping."},{"line_number":517,"context_line":"            create_kwargs[\u0027legacy_bdm\u0027] \u003d True"},{"line_number":518,"context_line":"        elif block_device_mapping_v2:"},{"line_number":519,"context_line":"            image_href \u003d server_dict.get(\u0027imageRef\u0027)"},{"line_number":520,"context_line":"            image_uuid_specified \u003d image_href is not None"},{"line_number":521,"context_line":"            try:"},{"line_number":522,"context_line":"                block_device_mapping \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_416cf3cd","line":519,"in_reply_to":"5f7c97a3_496f48f9","updated":"2018-07-21 02:46:50.000000000","message":"oh, thanks. i will add it in followup.","commit_id":"4ce1ef6f4a09ea0439afd3da6500e145d8847aa4"}]}