)]}'
{"nova/objects/base.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"4eb26014968b4e0ddc6c09aeed47cab8d1a431ad","unresolved":false,"context_lines":[{"line_number":484,"context_line":""},{"line_number":485,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":486,"context_line":"        primitives \u003d primitive[\u0027objects\u0027]"},{"line_number":487,"context_line":"        child_target_version \u003d self.child_versions.get(target_version, \u00271.0\u0027)"},{"line_number":488,"context_line":"        for index, item in enumerate(self.objects):"},{"line_number":489,"context_line":"            self.objects[index].obj_make_compatible("},{"line_number":490,"context_line":"                primitives[index][\u0027nova_object.data\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BXiY%3D","line":487,"updated":"2013-11-26 20:52:48.000000000","message":"Is there any point in doing a \u0027get\u0027 here?  If there\u0027s no entry, the target version would be None.  And it looks like Instance\u0027s obj_make_compatible would barf on that anyway:\n\ndef obj_make_compatible(self, primitive, target_version):\n186\t+        target_version \u003d (int(target_version.split(\u0027.\u0027)[0]),\n187\t+                          int(target_version.split(\u0027.\u0027)[1]))\n188\t+","commit_id":"bdeceab0c98940757b7a301d1d519be424a96d1d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4ca255d7564b0c32cd47204d4a8f2b45445665cc","unresolved":false,"context_lines":[{"line_number":484,"context_line":""},{"line_number":485,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":486,"context_line":"        primitives \u003d primitive[\u0027objects\u0027]"},{"line_number":487,"context_line":"        child_target_version \u003d self.child_versions.get(target_version, \u00271.0\u0027)"},{"line_number":488,"context_line":"        for index, item in enumerate(self.objects):"},{"line_number":489,"context_line":"            self.objects[index].obj_make_compatible("},{"line_number":490,"context_line":"                primitives[index][\u0027nova_object.data\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BXTo%3D","line":487,"in_reply_to":"AAAATn%2F%2BXiY%3D","updated":"2013-12-02 21:59:19.000000000","message":"It simplifies the case where we only have a 1.0 of both the list and the object itself. If it\u0027s too implicit, then I can fix it, but it covers a bunch of cases right now (try running the tests without it).","commit_id":"bdeceab0c98940757b7a301d1d519be424a96d1d"}]}
