)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8916e7bfd16791eb8cda7b46cdfb8c846ed6eb1a","unresolved":false,"context_lines":[{"line_number":5503,"context_line":"        if \u0027tag\u0027 in bdm and bdm.tag:"},{"line_number":5504,"context_line":"            self._delete_disk_metadata(instance, bdm)"},{"line_number":5505,"context_line":"        else:"},{"line_number":5506,"context_line":"            LOG.debug(\u0027No tag in bdm %s, not cleaning up disk metada.\u0027, bdm)"},{"line_number":5507,"context_line":"        if destroy_bdm:"},{"line_number":5508,"context_line":"            bdm.destroy()"},{"line_number":5509,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_048249c8","line":5506,"range":{"start_line":5506,"start_character":62,"end_line":5506,"end_character":68},"updated":"2018-07-24 19:58:25.000000000","message":"metadata","commit_id":"a82da00a68c7312129b1435cfc5786a8ee7d98fe"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"383bd251996500979f7b85c64e93ea09b3426ea0","unresolved":false,"context_lines":[{"line_number":5503,"context_line":"        if \u0027tag\u0027 in bdm and bdm.tag:"},{"line_number":5504,"context_line":"            self._delete_disk_metadata(instance, bdm)"},{"line_number":5505,"context_line":"        else:"},{"line_number":5506,"context_line":"            LOG.debug(\u0027No tag in bdm %s, not cleaning up disk metada.\u0027, bdm)"},{"line_number":5507,"context_line":"        if destroy_bdm:"},{"line_number":5508,"context_line":"            bdm.destroy()"},{"line_number":5509,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_a4ab551d","line":5506,"range":{"start_line":5506,"start_character":62,"end_line":5506,"end_character":68},"in_reply_to":"5f7c97a3_048249c8","updated":"2018-07-24 20:05:14.000000000","message":"Done","commit_id":"a82da00a68c7312129b1435cfc5786a8ee7d98fe"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8916e7bfd16791eb8cda7b46cdfb8c846ed6eb1a","unresolved":false,"context_lines":[{"line_number":5510,"context_line":"    def _delete_disk_metadata(self, instance, bdm):"},{"line_number":5511,"context_line":"        for device in instance.device_metadata.devices:"},{"line_number":5512,"context_line":"            if isinstance(device, objects.DiskMetadata):"},{"line_number":5513,"context_line":"                LOG.debug(\u0027Attempting clean up for disk %s.\u0027, device)"},{"line_number":5514,"context_line":"                if \u0027serial\u0027 in device:"},{"line_number":5515,"context_line":"                    if device.serial \u003d\u003d bdm.volume_id:"},{"line_number":5516,"context_line":"                        instance.device_metadata.devices.remove(device)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_c463f144","line":5513,"updated":"2018-07-24 19:58:25.000000000","message":"This will always log right? Is that necessary given we have the else..LOG below?","commit_id":"a82da00a68c7312129b1435cfc5786a8ee7d98fe"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"383bd251996500979f7b85c64e93ea09b3426ea0","unresolved":false,"context_lines":[{"line_number":5510,"context_line":"    def _delete_disk_metadata(self, instance, bdm):"},{"line_number":5511,"context_line":"        for device in instance.device_metadata.devices:"},{"line_number":5512,"context_line":"            if isinstance(device, objects.DiskMetadata):"},{"line_number":5513,"context_line":"                LOG.debug(\u0027Attempting clean up for disk %s.\u0027, device)"},{"line_number":5514,"context_line":"                if \u0027serial\u0027 in device:"},{"line_number":5515,"context_line":"                    if device.serial \u003d\u003d bdm.volume_id:"},{"line_number":5516,"context_line":"                        instance.device_metadata.devices.remove(device)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_24b8a576","line":5513,"in_reply_to":"5f7c97a3_c463f144","updated":"2018-07-24 20:05:14.000000000","message":"I guess yeah, if _delete_disk_metadata got called, there\u0027ll be at least one objects.DiskMetadata in devices (unless something *really* freaky is happening).\n\nAnd there\u0027s no interest in logging if we\u0027ve successfully cleaned up. OK, will just remove this.","commit_id":"a82da00a68c7312129b1435cfc5786a8ee7d98fe"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3e77134fa95372bdec700ba13066aba33f327dc0","unresolved":false,"context_lines":[{"line_number":5503,"context_line":"        if \u0027tag\u0027 in bdm and bdm.tag:"},{"line_number":5504,"context_line":"            self._delete_disk_metadata(instance, bdm)"},{"line_number":5505,"context_line":"        else:"},{"line_number":5506,"context_line":"            LOG.debug(\u0027No tag in bdm %s, not cleaning up disk metadata.\u0027, bdm)"},{"line_number":5507,"context_line":"        if destroy_bdm:"},{"line_number":5508,"context_line":"            bdm.destroy()"},{"line_number":5509,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_9f38e43c","line":5506,"updated":"2018-07-24 20:27:15.000000000","message":"instance\u003dinstance kwarg","commit_id":"754b16123e22cadedc7822828abcc9eb1e9c63e9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3e77134fa95372bdec700ba13066aba33f327dc0","unresolved":false,"context_lines":[{"line_number":5516,"context_line":"                        instance.save()"},{"line_number":5517,"context_line":"                        break"},{"line_number":5518,"context_line":"                    else:"},{"line_number":5519,"context_line":"                        LOG.debug(\u0027Not cleaning up, serial %s does not match \u0027"},{"line_number":5520,"context_line":"                                  \u0027volume id %s\u0027,"},{"line_number":5521,"context_line":"                                  (device.serial, bdm.volume_id))"},{"line_number":5522,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_5fed6cb6","line":5519,"range":{"start_line":5519,"start_character":48,"end_line":5519,"end_character":50},"updated":"2018-07-24 20:27:15.000000000","message":"nit: context for the message would be good, i.e. \"Not cleaning up disk metadata; serial %s does not match volume id %s\" and use the instance\u003dinstance kwarg for highlighting.","commit_id":"754b16123e22cadedc7822828abcc9eb1e9c63e9"}]}