)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c9e3487021fe85eec81151125b9604b7619e8a51","unresolved":false,"context_lines":[{"line_number":17,"context_line":"using the rc_fields package in nova. It is a lighter weight alternative"},{"line_number":18,"context_line":"to Jay\u0027s proposal at https://github.com/jaypipes/os-resource-classes"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The placement side of the equation is update to use the new modules"},{"line_number":21,"context_line":"while the nova side continues to use rc_fields."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"requirements.txt has been temporarily updated to try to load"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_173f1ddf","line":20,"range":{"start_line":20,"start_character":38,"end_line":20,"end_character":44},"updated":"2018-07-21 15:11:26.000000000","message":"updated","commit_id":"4c9f67934ea15addc233f1a234df8a6608f070f0"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c9e3487021fe85eec81151125b9604b7619e8a51","unresolved":false,"context_lines":[{"line_number":18,"context_line":"to Jay\u0027s proposal at https://github.com/jaypipes/os-resource-classes"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The placement side of the equation is update to use the new modules"},{"line_number":21,"context_line":"while the nova side continues to use rc_fields."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"requirements.txt has been temporarily updated to try to load"},{"line_number":24,"context_line":"os-resource-classes from github, but it\u0027s being difficult, so may not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_572ef5aa","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":47},"updated":"2018-07-21 15:11:26.000000000","message":"Why? I thought the whole point of this was to have a common place to reference the fields from.","commit_id":"4c9f67934ea15addc233f1a234df8a6608f070f0"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"62acf48540e97a4c83395488e53207801ebeed77","unresolved":false,"context_lines":[{"line_number":18,"context_line":"to Jay\u0027s proposal at https://github.com/jaypipes/os-resource-classes"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The placement side of the equation is update to use the new modules"},{"line_number":21,"context_line":"while the nova side continues to use rc_fields."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"requirements.txt has been temporarily updated to try to load"},{"line_number":24,"context_line":"os-resource-classes from github, but it\u0027s being difficult, so may not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_fb3607e0","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":47},"in_reply_to":"5f7c97a3_1866692a","updated":"2018-07-22 12:34:11.000000000","message":"yeah yeah, I get it, I was just making sure it was going to be covered once you _do_ cut over.","commit_id":"4c9f67934ea15addc233f1a234df8a6608f070f0"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"ec8229c7b6066bccb20263f44ffd9991143ef237","unresolved":false,"context_lines":[{"line_number":18,"context_line":"to Jay\u0027s proposal at https://github.com/jaypipes/os-resource-classes"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The placement side of the equation is update to use the new modules"},{"line_number":21,"context_line":"while the nova side continues to use rc_fields."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"requirements.txt has been temporarily updated to try to load"},{"line_number":24,"context_line":"os-resource-classes from github, but it\u0027s being difficult, so may not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_d2e3f304","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":47},"in_reply_to":"5f7c97a3_572ef5aa","updated":"2018-07-21 16:21:28.000000000","message":"I forgot to write the full thought that was in my head which was:\n\n\"the nova side continues to use rc_fields for now because that demonstrates that an old installation of nova will continue to work with a new placement, and that the resource classes are stable between the two modes. If/when this become real we can change the whole thing.\"","commit_id":"4c9f67934ea15addc233f1a234df8a6608f070f0"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"ccfa06bd8adb234b768a3492abd159f94ade4870","unresolved":false,"context_lines":[{"line_number":18,"context_line":"to Jay\u0027s proposal at https://github.com/jaypipes/os-resource-classes"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The placement side of the equation is update to use the new modules"},{"line_number":21,"context_line":"while the nova side continues to use rc_fields."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"requirements.txt has been temporarily updated to try to load"},{"line_number":24,"context_line":"os-resource-classes from github, but it\u0027s being difficult, so may not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_1866692a","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":47},"in_reply_to":"5f7c97a3_b26af714","updated":"2018-07-22 11:52:59.000000000","message":"Yes, but that doesn\u0027t help me much as an in-progress developer running tests locally and doing TDD.","commit_id":"4c9f67934ea15addc233f1a234df8a6608f070f0"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3b28220c0fe41f43bcd165f2eae87c92661f0636","unresolved":false,"context_lines":[{"line_number":18,"context_line":"to Jay\u0027s proposal at https://github.com/jaypipes/os-resource-classes"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The placement side of the equation is update to use the new modules"},{"line_number":21,"context_line":"while the nova side continues to use rc_fields."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"requirements.txt has been temporarily updated to try to load"},{"line_number":24,"context_line":"os-resource-classes from github, but it\u0027s being difficult, so may not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_b26af714","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":47},"in_reply_to":"5f7c97a3_d2e3f304","updated":"2018-07-21 17:38:41.000000000","message":"Gotcha.\n\nDon\u0027t we have a CI job whose responsibility is to make sure of things like that? Grenade or something?","commit_id":"4c9f67934ea15addc233f1a234df8a6608f070f0"}],"nova/api/openstack/placement/objects/resource_provider.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c9e3487021fe85eec81151125b9604b7619e8a51","unresolved":false,"context_lines":[{"line_number":2224,"context_line":""},{"line_number":2225,"context_line":"    fields \u003d {"},{"line_number":2226,"context_line":"        \u0027id\u0027: fields.IntegerField(read_only\u003dTrue),"},{"line_number":2227,"context_line":"        \u0027name\u0027: rc_fields.ResourceClassField(nullable\u003dFalse),"},{"line_number":2228,"context_line":"    }"},{"line_number":2229,"context_line":""},{"line_number":2230,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_7228df83","side":"PARENT","line":2227,"range":{"start_line":2227,"start_character":26,"end_line":2227,"end_character":44},"updated":"2018-07-21 15:11:26.000000000","message":"Could os-resource-classes provide a ResourceClassField for ovo-ness? Does that confer any kind of advantage, like enum value checking? (I guess how could it, if CUSTOM_* is allowed?)","commit_id":"50f40854b04351fb622fd8b68b374a8fe8ca2070"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"ec8229c7b6066bccb20263f44ffd9991143ef237","unresolved":false,"context_lines":[{"line_number":2224,"context_line":""},{"line_number":2225,"context_line":"    fields \u003d {"},{"line_number":2226,"context_line":"        \u0027id\u0027: fields.IntegerField(read_only\u003dTrue),"},{"line_number":2227,"context_line":"        \u0027name\u0027: rc_fields.ResourceClassField(nullable\u003dFalse),"},{"line_number":2228,"context_line":"    }"},{"line_number":2229,"context_line":""},{"line_number":2230,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_f2de2f3a","side":"PARENT","line":2227,"range":{"start_line":2227,"start_character":26,"end_line":2227,"end_character":44},"in_reply_to":"5f7c97a3_7228df83","updated":"2018-07-21 16:21:28.000000000","message":"exactly. as far as I can tell we either need a more complex ResourceClassField that does some kind of fancy checking that it is either standard or custom\n\nOr we can just do a StringField because it doesn\u0027t really matter, we\u0027re not doing type checking at this level of the system anyway.","commit_id":"50f40854b04351fb622fd8b68b374a8fe8ca2070"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3b28220c0fe41f43bcd165f2eae87c92661f0636","unresolved":false,"context_lines":[{"line_number":2224,"context_line":""},{"line_number":2225,"context_line":"    fields \u003d {"},{"line_number":2226,"context_line":"        \u0027id\u0027: fields.IntegerField(read_only\u003dTrue),"},{"line_number":2227,"context_line":"        \u0027name\u0027: rc_fields.ResourceClassField(nullable\u003dFalse),"},{"line_number":2228,"context_line":"    }"},{"line_number":2229,"context_line":""},{"line_number":2230,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_72621f3f","side":"PARENT","line":2227,"range":{"start_line":2227,"start_character":26,"end_line":2227,"end_character":44},"in_reply_to":"5f7c97a3_f2de2f3a","updated":"2018-07-21 17:38:41.000000000","message":"ack","commit_id":"50f40854b04351fb622fd8b68b374a8fe8ca2070"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c9e3487021fe85eec81151125b9604b7619e8a51","unresolved":false,"context_lines":[{"line_number":152,"context_line":"@oslo_db_api.wrap_db_retry(max_retries\u003d5, retry_on_deadlock\u003dTrue)"},{"line_number":153,"context_line":"@db_api.placement_context_manager.writer.independent"},{"line_number":154,"context_line":"def _resource_classes_sync(ctx):"},{"line_number":155,"context_line":"    # Create a set of all traits in the os_traits library."},{"line_number":156,"context_line":"    sel \u003d sa.select([_RC_TBL.c.name])"},{"line_number":157,"context_line":"    res \u003d ctx.session.execute(sel).fetchall()"},{"line_number":158,"context_line":"    db_classes \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_3205870f","line":155,"range":{"start_line":155,"start_character":26,"end_line":155,"end_character":49},"updated":"2018-07-21 15:11:26.000000000","message":"copypastaaaa","commit_id":"4c9f67934ea15addc233f1a234df8a6608f070f0"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c9e3487021fe85eec81151125b9604b7619e8a51","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        r[0] for r in res"},{"line_number":160,"context_line":"        if not os_resource_classes.is_custom(r[0])"},{"line_number":161,"context_line":"    ]"},{"line_number":162,"context_line":"    # Determine those traits which are in os_traits but not"},{"line_number":163,"context_line":"    # currently in the database, and insert them."},{"line_number":164,"context_line":"    need_sync \u003d [(index, name) for index, name in"},{"line_number":165,"context_line":"                 enumerate(os_resource_classes.ORDERED_CLASSES)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_d20f732c","line":162,"range":{"start_line":162,"start_character":22,"end_line":162,"end_character":51},"updated":"2018-07-21 15:11:26.000000000","message":"aaaaa","commit_id":"4c9f67934ea15addc233f1a234df8a6608f070f0"}],"nova/db/sqlalchemy/resource_class_cache.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c9e3487021fe85eec81151125b9604b7619e8a51","unresolved":false,"context_lines":[{"line_number":26,"context_line":"_LOCKNAME \u003d \u0027rc_cache\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def raise_if_custom_resource_class_pre_v1_1(rc):"},{"line_number":30,"context_line":"    \"\"\"Raises ValueError if the supplied resource class identifier is"},{"line_number":31,"context_line":"    *not* in the set of standard resource classes as of Inventory/Allocation"},{"line_number":32,"context_line":"    object version 1.1"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_97524d35","side":"PARENT","line":29,"range":{"start_line":29,"start_character":4,"end_line":29,"end_character":43},"updated":"2018-07-21 15:11:26.000000000","message":"See https://review.openstack.org/#/c/575847/","commit_id":"50f40854b04351fb622fd8b68b374a8fe8ca2070"}],"requirements.txt":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c9e3487021fe85eec81151125b9604b7619e8a51","unresolved":false,"context_lines":[{"line_number":67,"context_line":"os-service-types\u003e\u003d1.2.0 # Apache-2.0"},{"line_number":68,"context_line":"taskflow\u003e\u003d2.16.0 # Apache-2.0"},{"line_number":69,"context_line":"python-dateutil\u003e\u003d2.5.3 # BSD"},{"line_number":70,"context_line":"#zVMCloudConnector\u003e\u003d1.1.1;sys_platform!\u003d\u0027win32\u0027  # Apache 2.0 License"},{"line_number":71,"context_line":"futures\u003e\u003d3.0.0;python_version\u003d\u003d\u00272.7\u0027 or python_version\u003d\u003d\u00272.6\u0027 # PSF"}],"source_content_type":"text/plain","patch_set":1,"id":"5f7c97a3_f2386fcb","line":70,"updated":"2018-07-21 15:11:26.000000000","message":"https://bugs.launchpad.net/designate/+bug/1782604 is tracking your woes here.","commit_id":"4c9f67934ea15addc233f1a234df8a6608f070f0"}]}