)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"41c2705b112afe63a0fe77700b1555a57d7fd982","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Currently schema and request/response extended code are there"},{"line_number":12,"context_line":"among all extensions."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This commit merge the config drive extension resposne into server controller."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partially implements: blueprint api-extensions-merge-rocky"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_846c67cf","line":14,"range":{"start_line":14,"start_character":45,"end_line":14,"end_character":53},"updated":"2018-07-20 14:23:44.000000000","message":"response","commit_id":"246ffbeffe1380ab5cb60f9bd29fb25f23efab35"}],"nova/api/openstack/compute/views/servers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"41c2705b112afe63a0fe77700b1555a57d7fd982","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            server[\"server\"][\"OS-EXT-AZ:availability_zone\"] \u003d az or \u0027\u0027"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        if show_config_drive is None:"},{"line_number":175,"context_line":"            show_config_drive \u003d context.can(cd_policies.BASE_POLICY_NAME,"},{"line_number":176,"context_line":"                                            fatal\u003dFalse)"},{"line_number":177,"context_line":"        if show_config_drive:"},{"line_number":178,"context_line":"            server[\"server\"][\"config_drive\"] \u003d instance[\"config_drive\"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_84a1c7f8","line":175,"range":{"start_line":175,"start_character":56,"end_line":175,"end_character":72},"updated":"2018-07-20 14:23:44.000000000","message":"We should probably deprecate these old legacy extension policy rules for things that our API reference says are not optional in the response.","commit_id":"246ffbeffe1380ab5cb60f9bd29fb25f23efab35"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0d1107bd213579d23002d3bfb1c056829128a91e","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            server[\"server\"][\"OS-EXT-AZ:availability_zone\"] \u003d az or \u0027\u0027"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        if show_config_drive is None:"},{"line_number":175,"context_line":"            show_config_drive \u003d context.can(cd_policies.BASE_POLICY_NAME,"},{"line_number":176,"context_line":"                                            fatal\u003dFalse)"},{"line_number":177,"context_line":"        if show_config_drive:"},{"line_number":178,"context_line":"            server[\"server\"][\"config_drive\"] \u003d instance[\"config_drive\"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_e1941f8e","line":175,"range":{"start_line":175,"start_character":56,"end_line":175,"end_character":72},"in_reply_to":"5f7c97a3_84a1c7f8","updated":"2018-07-21 03:04:11.000000000","message":"All extensions policy are deprecated for removal. We did this in queens[1]. all the extensions policy are deprecated and marked for removal since queens[2].\n\n[1] Ie05f4e84519f8a00ffb66ea5ee920d5c7722a66b \n[2] https://github.com/openstack/nova/blob/7667e8e0cd38cda7478243b6d7518417a56af9b9/nova/policies/config_drive.py#L39\n\nI have question on that about removing those policy now in Rocky or in Stein.Question in - https://review.openstack.org/#/c/502859/4/nova/api/openstack/compute/views/servers.py@167\n\nif we remove it now then it makes view builder code merge very easy. \n\nI thought of doing it in Stein so that operator get more time to remove their dependency on those policy.","commit_id":"246ffbeffe1380ab5cb60f9bd29fb25f23efab35"}]}