)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3ad0ea0d76edbc38f3af079b6aa23bd718dae12c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In preparation for reshaper work, implement a superior method to"},{"line_number":10,"context_line":"retrieve allocations for a consumer. The new get_allocs_for_consumer:"},{"line_number":11,"context_line":"- Uses the microversion that returns consumer generations (1.28). This"},{"line_number":12,"context_line":"  bumps the overall minimum for Rocky."},{"line_number":13,"context_line":"- Doesn\u0027t hide error conditions:"},{"line_number":14,"context_line":"  - If the request returns non-200, instead of returning {}, it raises a"},{"line_number":15,"context_line":"    new ConsumerAllocationRetrievalFailed exception."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"3f79a3b5_20624aaf","line":12,"range":{"start_line":12,"start_character":2,"end_line":12,"end_character":7},"updated":"2018-08-24 16:03:41.000000000","message":"Also, this doesn\u0027t happen now b/c I bumped it.","commit_id":"147340708cd000fcca709b5da0df5a2e8025ac0c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4bfcfa18f314c04a242c25a26c9af53bde009685","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In preparation for reshaper work, implement a superior method to"},{"line_number":10,"context_line":"retrieve allocations for a consumer. The new get_allocs_for_consumer:"},{"line_number":11,"context_line":"- Uses the microversion that returns consumer generations (1.28). This"},{"line_number":12,"context_line":"  bumps the overall minimum for Rocky."},{"line_number":13,"context_line":"- Doesn\u0027t hide error conditions:"},{"line_number":14,"context_line":"  - If the request returns non-200, instead of returning {}, it raises a"},{"line_number":15,"context_line":"    new ConsumerAllocationRetrievalFailed exception."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"3f79a3b5_d559d68d","line":12,"range":{"start_line":12,"start_character":32,"end_line":12,"end_character":37},"updated":"2018-08-24 16:02:54.000000000","message":"Stein","commit_id":"147340708cd000fcca709b5da0df5a2e8025ac0c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3f13c9bf17bdde9d6ad4acfa616dda9b09389a77","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In preparation for reshaper work, implement a superior method to"},{"line_number":10,"context_line":"retrieve allocations for a consumer. The new get_allocs_for_consumer:"},{"line_number":11,"context_line":"- Uses the microversion that returns consumer generations (1.28). This"},{"line_number":12,"context_line":"  bumps the overall minimum for Rocky."},{"line_number":13,"context_line":"- Doesn\u0027t hide error conditions:"},{"line_number":14,"context_line":"  - If the request returns non-200, instead of returning {}, it raises a"},{"line_number":15,"context_line":"    new ConsumerAllocationRetrievalFailed exception."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"3f79a3b5_493c4e92","line":12,"range":{"start_line":12,"start_character":2,"end_line":12,"end_character":7},"in_reply_to":"3f79a3b5_20624aaf","updated":"2018-08-24 19:43:56.000000000","message":"Done.","commit_id":"147340708cd000fcca709b5da0df5a2e8025ac0c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"87b7db12d295cba981f3ea810d313a6445c35ff8","unresolved":false,"context_lines":[{"line_number":20,"context_line":"The existing get_allocations_for_consumer is refactored to behave"},{"line_number":21,"context_line":"compatibly (except it logs warnings for the previously-silently-hidden"},{"line_number":22,"context_line":"error conditions). In a subsequent patch, we should rework all callers"},{"line_number":23,"context_line":"of this method to use the new one, and get rid of the old one."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I0e9a804ae7717252175f7fe409223f5eb8f50013"},{"line_number":26,"context_line":"blueprint: reshape-provider-tree"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"3f79a3b5_f7d3c1ff","line":23,"updated":"2018-08-24 09:24:58.000000000","message":"This could be part of my series adding overall support for 1.28 [1]\n\n[1]https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:consumer_gen","commit_id":"147340708cd000fcca709b5da0df5a2e8025ac0c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9ddf53491ee1c0d72906592722b7f2f2291cc753","unresolved":false,"context_lines":[{"line_number":20,"context_line":"The existing get_allocations_for_consumer is refactored to behave"},{"line_number":21,"context_line":"compatibly (except it logs warnings for the previously-silently-hidden"},{"line_number":22,"context_line":"error conditions). In a subsequent patch, we should rework all callers"},{"line_number":23,"context_line":"of this method to use the new one, and get rid of the old one."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I0e9a804ae7717252175f7fe409223f5eb8f50013"},{"line_number":26,"context_line":"blueprint: reshape-provider-tree"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"3f79a3b5_15918e47","line":23,"in_reply_to":"3f79a3b5_f7d3c1ff","updated":"2018-08-24 15:40:57.000000000","message":"++","commit_id":"147340708cd000fcca709b5da0df5a2e8025ac0c"}],"doc/source/user/placement.rst":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"26354c3f0bd7a5f9b72b8a649056c50b9706fe2c","unresolved":false,"context_lines":[{"line_number":63,"context_line":".. _Request Traits During Scheduling: https://specs.openstack.org/openstack/nova-specs/specs/queens/approved/request-traits-in-nova.html"},{"line_number":64,"context_line":".. _filter allocation candidates by aggregate membership: https://specs.openstack.org/openstack/nova-specs/specs/rocky/approved/alloc-candidates-member-of.html"},{"line_number":65,"context_line":".. _perform granular allocation candidate requests: http://specs.openstack.org/openstack/nova-specs/specs/rocky/approved/granular-resource-requests.html"},{"line_number":66,"context_line":".. _return consumer generations: http://specs.openstack.org/openstack/nova-specs/specs/rocky/approved/add-consumer-generation.html"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Deployment"},{"line_number":69,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5f7c97a3_15a394b2","line":66,"updated":"2018-08-02 13:58:15.000000000","message":"these changes are welcome, but seem a tad unrelated to this patch?","commit_id":"6fcd81bcd72dbc8dfe523ff9a8d4d5277ee9aa8f"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0a2b3c7f0df1d3a72dbfc61a4009010b3561b945","unresolved":false,"context_lines":[{"line_number":63,"context_line":".. _Request Traits During Scheduling: https://specs.openstack.org/openstack/nova-specs/specs/queens/approved/request-traits-in-nova.html"},{"line_number":64,"context_line":".. _filter allocation candidates by aggregate membership: https://specs.openstack.org/openstack/nova-specs/specs/rocky/approved/alloc-candidates-member-of.html"},{"line_number":65,"context_line":".. _perform granular allocation candidate requests: http://specs.openstack.org/openstack/nova-specs/specs/rocky/approved/granular-resource-requests.html"},{"line_number":66,"context_line":".. _return consumer generations: http://specs.openstack.org/openstack/nova-specs/specs/rocky/approved/add-consumer-generation.html"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Deployment"},{"line_number":69,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5f7c97a3_e8baaeb8","line":66,"in_reply_to":"5f7c97a3_15a394b2","updated":"2018-08-02 22:31:34.000000000","message":"These lines were removed via [1] - not sure how, but I wound up \"restoring them\" via a rebase at some point. They\u0027re still nice to have even in light of the intent of [1] - should I yank \u0027em or leave \u0027em?\n\n[1] I8bf6ab049f15ad24a5fbf0557bd0cd8652101901","commit_id":"6fcd81bcd72dbc8dfe523ff9a8d4d5277ee9aa8f"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"fdd163c533a4f1dc530994fc98038e38c1acde5a","unresolved":false,"context_lines":[{"line_number":63,"context_line":".. _Request Traits During Scheduling: https://specs.openstack.org/openstack/nova-specs/specs/queens/approved/request-traits-in-nova.html"},{"line_number":64,"context_line":".. _filter allocation candidates by aggregate membership: https://specs.openstack.org/openstack/nova-specs/specs/rocky/approved/alloc-candidates-member-of.html"},{"line_number":65,"context_line":".. _perform granular allocation candidate requests: http://specs.openstack.org/openstack/nova-specs/specs/rocky/approved/granular-resource-requests.html"},{"line_number":66,"context_line":".. _return consumer generations: http://specs.openstack.org/openstack/nova-specs/specs/rocky/approved/add-consumer-generation.html"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Deployment"},{"line_number":69,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_ed792293","line":66,"updated":"2018-08-08 12:18:28.000000000","message":"this slipped in again. not a huge deal though","commit_id":"4dd78e34d2250eb91bd4427948ccf9921e0fe7ab"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"613501be402f7cc80f3113cf00a4766034becc4a","unresolved":false,"context_lines":[{"line_number":63,"context_line":".. _Request Traits During Scheduling: https://specs.openstack.org/openstack/nova-specs/specs/queens/approved/request-traits-in-nova.html"},{"line_number":64,"context_line":".. _filter allocation candidates by aggregate membership: https://specs.openstack.org/openstack/nova-specs/specs/rocky/approved/alloc-candidates-member-of.html"},{"line_number":65,"context_line":".. _perform granular allocation candidate requests: http://specs.openstack.org/openstack/nova-specs/specs/rocky/approved/granular-resource-requests.html"},{"line_number":66,"context_line":".. _return consumer generations: http://specs.openstack.org/openstack/nova-specs/specs/rocky/approved/add-consumer-generation.html"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Deployment"},{"line_number":69,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_dadc0176","line":66,"in_reply_to":"3f79a3b5_ed792293","updated":"2018-08-21 17:26:22.000000000","message":"Done","commit_id":"4dd78e34d2250eb91bd4427948ccf9921e0fe7ab"}],"nova/cmd/manage.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4bfcfa18f314c04a242c25a26c9af53bde009685","unresolved":false,"context_lines":[{"line_number":1811,"context_line":"        except (ks_exc.ClientException,"},{"line_number":1812,"context_line":"                exception.ConsumerAllocationRetrievalFailed) as e:"},{"line_number":1813,"context_line":"            output(_(\"Allocation retrieval failed: %s\") % e)"},{"line_number":1814,"context_line":"            allocations \u003d None"},{"line_number":1815,"context_line":""},{"line_number":1816,"context_line":"        # get_allocations_for_consumer uses safe_connect which will"},{"line_number":1817,"context_line":"        # return None if we can\u0027t communicate with Placement, and the"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f79a3b5_b55c5a4b","line":1814,"updated":"2018-08-24 16:02:54.000000000","message":"Hmm, so this is compatible with what we were handling before per the comment on L1817, but likely not really something we want to do, because the PUT below will likely just fail if we got a KSA exception. So best case is this fails b/c placement is down and then put_allocations returns None (via it\u0027s usage of @safe_connect) and then we\u0027ll raise AllocationCreateFailed; worst case is the GET here fails and then we ovewrite with put_allocations below. It would likely be better to just fail fast here if we can\u0027t get allocations because we can\u0027t talk to placement...","commit_id":"147340708cd000fcca709b5da0df5a2e8025ac0c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3f13c9bf17bdde9d6ad4acfa616dda9b09389a77","unresolved":false,"context_lines":[{"line_number":1811,"context_line":"        except (ks_exc.ClientException,"},{"line_number":1812,"context_line":"                exception.ConsumerAllocationRetrievalFailed) as e:"},{"line_number":1813,"context_line":"            output(_(\"Allocation retrieval failed: %s\") % e)"},{"line_number":1814,"context_line":"            allocations \u003d None"},{"line_number":1815,"context_line":""},{"line_number":1816,"context_line":"        # get_allocations_for_consumer uses safe_connect which will"},{"line_number":1817,"context_line":"        # return None if we can\u0027t communicate with Placement, and the"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f79a3b5_e9c99aab","line":1814,"in_reply_to":"3f79a3b5_a0fadab9","updated":"2018-08-24 19:43:56.000000000","message":"Agree fup is best, since the point here was to *not* change the behavior. Added TODO(mriedem) :P","commit_id":"147340708cd000fcca709b5da0df5a2e8025ac0c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"671cd7f113396ee7faf968c04463580770be2c72","unresolved":false,"context_lines":[{"line_number":1811,"context_line":"        except (ks_exc.ClientException,"},{"line_number":1812,"context_line":"                exception.ConsumerAllocationRetrievalFailed) as e:"},{"line_number":1813,"context_line":"            output(_(\"Allocation retrieval failed: %s\") % e)"},{"line_number":1814,"context_line":"            allocations \u003d None"},{"line_number":1815,"context_line":""},{"line_number":1816,"context_line":"        # get_allocations_for_consumer uses safe_connect which will"},{"line_number":1817,"context_line":"        # return None if we can\u0027t communicate with Placement, and the"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f79a3b5_a0fadab9","line":1814,"in_reply_to":"3f79a3b5_b55c5a4b","updated":"2018-08-24 16:05:02.000000000","message":"Having said this, it was a problem before as well and could just be dealt with in a follow up patch (by me if you like).","commit_id":"147340708cd000fcca709b5da0df5a2e8025ac0c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8ee15e3fe6e5936c1da7a6b8c12e0e6b66f99499","unresolved":false,"context_lines":[{"line_number":1811,"context_line":"        except (ks_exc.ClientException,"},{"line_number":1812,"context_line":"                exception.ConsumerAllocationRetrievalFailed) as e:"},{"line_number":1813,"context_line":"            output(_(\"Allocation retrieval failed: %s\") % e)"},{"line_number":1814,"context_line":"            allocations \u003d None"},{"line_number":1815,"context_line":""},{"line_number":1816,"context_line":"        # get_allocations_for_consumer uses safe_connect which will"},{"line_number":1817,"context_line":"        # return None if we can\u0027t communicate with Placement, and the"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f79a3b5_94f2396f","line":1814,"in_reply_to":"3f79a3b5_e9c99aab","updated":"2018-08-28 20:56:09.000000000","message":"https://review.openstack.org/597237","commit_id":"147340708cd000fcca709b5da0df5a2e8025ac0c"}],"nova/scheduler/client/report.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"54741c464c7f469405f5392938ad9ded50e05b2c","unresolved":false,"context_lines":[{"line_number":1601,"context_line":"                               global_request_id\u003dcontext.global_id)"},{"line_number":1602,"context_line":"        if not resp:"},{"line_number":1603,"context_line":"            raise exception.ConsumerAllocationRetrievalFailed("},{"line_number":1604,"context_line":"                consumer_uuid\u003dconsumer, error\u003dresp.text)"},{"line_number":1605,"context_line":""},{"line_number":1606,"context_line":"        return resp.json()"},{"line_number":1607,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_035a6c1d","line":1604,"updated":"2018-07-23 11:28:52.000000000","message":"Since the error message is coming back as json, you might consider accessing any  of \u0027code\u0027, \u0027title\u0027 or \u0027detail\u0027. attributes on the first item in the errors list.","commit_id":"630563197648d350cac008fa24731716f1b1f46d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"2483898ab89b36d34aea21c7537af848bab88411","unresolved":false,"context_lines":[{"line_number":1601,"context_line":"                               global_request_id\u003dcontext.global_id)"},{"line_number":1602,"context_line":"        if not resp:"},{"line_number":1603,"context_line":"            raise exception.ConsumerAllocationRetrievalFailed("},{"line_number":1604,"context_line":"                consumer_uuid\u003dconsumer, error\u003dresp.text)"},{"line_number":1605,"context_line":""},{"line_number":1606,"context_line":"        return resp.json()"},{"line_number":1607,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_31c9e579","line":1604,"in_reply_to":"5f7c97a3_035a6c1d","updated":"2018-07-24 13:38:51.000000000","message":"I actually don\u0027t have a way to make this fail yet. I\u0027ll leave a TODO to spiff it up when we do the 404-for-nonexistent-consumer thing.","commit_id":"630563197648d350cac008fa24731716f1b1f46d"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"26354c3f0bd7a5f9b72b8a649056c50b9706fe2c","unresolved":false,"context_lines":[{"line_number":1547,"context_line":"    def get_allocations_for_consumer(self, context, consumer):"},{"line_number":1548,"context_line":"        \"\"\"Legacy method for allocation retrieval."},{"line_number":1549,"context_line":""},{"line_number":1550,"context_line":"        Callers should move to using get_allocations_for_consumer, which"},{"line_number":1551,"context_line":"        handles errors properly and returns the entire payload."},{"line_number":1552,"context_line":""},{"line_number":1553,"context_line":"        :param context: The nova.context.RequestContext auth context"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_b56c206c","line":1550,"range":{"start_line":1550,"start_character":36,"end_line":1550,"end_character":65},"updated":"2018-08-02 13:58:15.000000000","message":"that\u0027s this method...","commit_id":"6fcd81bcd72dbc8dfe523ff9a8d4d5277ee9aa8f"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0a2b3c7f0df1d3a72dbfc61a4009010b3561b945","unresolved":false,"context_lines":[{"line_number":1547,"context_line":"    def get_allocations_for_consumer(self, context, consumer):"},{"line_number":1548,"context_line":"        \"\"\"Legacy method for allocation retrieval."},{"line_number":1549,"context_line":""},{"line_number":1550,"context_line":"        Callers should move to using get_allocations_for_consumer, which"},{"line_number":1551,"context_line":"        handles errors properly and returns the entire payload."},{"line_number":1552,"context_line":""},{"line_number":1553,"context_line":"        :param context: The nova.context.RequestContext auth context"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_48df220b","line":1550,"range":{"start_line":1550,"start_character":36,"end_line":1550,"end_character":65},"in_reply_to":"5f7c97a3_b56c206c","updated":"2018-08-02 22:31:34.000000000","message":"Done","commit_id":"6fcd81bcd72dbc8dfe523ff9a8d4d5277ee9aa8f"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"1d027352e926efd6f75b664421954473c6d1d014","unresolved":false,"context_lines":[{"line_number":1578,"context_line":"        :return: Dict of the form:"},{"line_number":1579,"context_line":"                { \"allocations\": {"},{"line_number":1580,"context_line":"                      $RP_UUID: {"},{"line_number":1581,"context_line":"                          \"generation\": $RP_GEN,"},{"line_number":1582,"context_line":"                          \"resources\": {"},{"line_number":1583,"context_line":"                              $RESOURCE_CLASS: $AMOUNT"},{"line_number":1584,"context_line":"                              ..."}],"source_content_type":"text/x-python","patch_set":21,"id":"3f79a3b5_b9154c3f","line":1581,"range":{"start_line":1581,"start_character":26,"end_line":1581,"end_character":48},"updated":"2018-08-23 19:55:48.000000000","message":"I wonder why we even return the provider generation when we don\u0027t use it in the POST/PUT /allocations calls...","commit_id":"147340708cd000fcca709b5da0df5a2e8025ac0c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9ddf53491ee1c0d72906592722b7f2f2291cc753","unresolved":false,"context_lines":[{"line_number":1578,"context_line":"        :return: Dict of the form:"},{"line_number":1579,"context_line":"                { \"allocations\": {"},{"line_number":1580,"context_line":"                      $RP_UUID: {"},{"line_number":1581,"context_line":"                          \"generation\": $RP_GEN,"},{"line_number":1582,"context_line":"                          \"resources\": {"},{"line_number":1583,"context_line":"                              $RESOURCE_CLASS: $AMOUNT"},{"line_number":1584,"context_line":"                              ..."}],"source_content_type":"text/x-python","patch_set":21,"id":"3f79a3b5_b2f6b08e","line":1581,"range":{"start_line":1581,"start_character":26,"end_line":1581,"end_character":48},"in_reply_to":"3f79a3b5_b9154c3f","updated":"2018-08-24 15:40:57.000000000","message":"It winds up in the reshaper payload. At some point I argued that this generation should be checked against the one from the inventories dict, but was convinced otherwise. So yeah, at this point I guess it\u0027s unused. But good form for it to be here.","commit_id":"147340708cd000fcca709b5da0df5a2e8025ac0c"}],"nova/tests/functional/test_report_client.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"1d027352e926efd6f75b664421954473c6d1d014","unresolved":false,"context_lines":[{"line_number":237,"context_line":"            # Check that we can get allocations for the consumer with"},{"line_number":238,"context_line":"            # the generation."},{"line_number":239,"context_line":"            allocations \u003d self.client.get_allocations_for_consumer("},{"line_number":240,"context_line":"                self.context, self.instance.uuid, include_generation\u003dTrue)"},{"line_number":241,"context_line":"            self.assertIn(\u0027consumer_generation\u0027, allocations)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"            # Delete allocations with our instance"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f79a3b5_99465050","side":"PARENT","line":240,"range":{"start_line":240,"start_character":48,"end_line":240,"end_character":74},"updated":"2018-08-23 19:55:48.000000000","message":"any reason you removed this test versus just removing the include_generation\u003dTrue part?","commit_id":"f534495a427d1683bc536cf003ec02edbf6d8a45"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9ddf53491ee1c0d72906592722b7f2f2291cc753","unresolved":false,"context_lines":[{"line_number":237,"context_line":"            # Check that we can get allocations for the consumer with"},{"line_number":238,"context_line":"            # the generation."},{"line_number":239,"context_line":"            allocations \u003d self.client.get_allocations_for_consumer("},{"line_number":240,"context_line":"                self.context, self.instance.uuid, include_generation\u003dTrue)"},{"line_number":241,"context_line":"            self.assertIn(\u0027consumer_generation\u0027, allocations)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"            # Delete allocations with our instance"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f79a3b5_158c2e34","side":"PARENT","line":240,"range":{"start_line":240,"start_character":48,"end_line":240,"end_character":74},"in_reply_to":"3f79a3b5_99465050","updated":"2018-08-24 15:40:57.000000000","message":"I was overlapping with something Matt was doing simultaneously [1] where he added this check *only* to validate the new kwarg he was introducing, which I was then immediately removing. (In fact, removing as part of a rebase along the way.)\n\n[Later] Hm, I was going to say I was covering this test case somewhere else in the change set, but I can\u0027t find it now. I can restore this if you like. Though all it would be testing is that the placement API call is returning the consumer_generation in the payload, which is almost redundant with the tests that ensure we\u0027re sending the right microversion to that call.\n\n[1] https://review.openstack.org/#/c/577905/","commit_id":"f534495a427d1683bc536cf003ec02edbf6d8a45"}]}