)]}'
{"nova/compute/resource_tracker.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"c8143833a86f31a178c5d402975de59c78ac99f5","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        self.stats \u003d stats.Stats()"},{"line_number":141,"context_line":"        self.tracked_instances \u003d {}"},{"line_number":142,"context_line":"        self.tracked_migrations \u003d {}"},{"line_number":143,"context_line":"        self.is_bfv \u003d {}  # dict, keyed by instance uuid, to is_bfv boolean"},{"line_number":144,"context_line":"        monitor_handler \u003d monitors.MonitorHandler(self)"},{"line_number":145,"context_line":"        self.monitors \u003d monitor_handler.monitors"},{"line_number":146,"context_line":"        self.old_resources \u003d collections.defaultdict(objects.ComputeNode)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_41109c4c","line":143,"updated":"2018-07-31 19:48:18.000000000","message":"I thought this reminded me of something:\n\nhttps://review.openstack.org/#/c/355091/7/nova/compute/resource_tracker.py@94","commit_id":"3a022299c13ff6a0a949c05c54fdc7331416a0b0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e407742f21c0b7e485feeb0d5f6dca8897cf589c","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        self.stats \u003d stats.Stats()"},{"line_number":141,"context_line":"        self.tracked_instances \u003d {}"},{"line_number":142,"context_line":"        self.tracked_migrations \u003d {}"},{"line_number":143,"context_line":"        self.is_bfv \u003d {}  # dict, keyed by instance uuid, to is_bfv boolean"},{"line_number":144,"context_line":"        monitor_handler \u003d monitors.MonitorHandler(self)"},{"line_number":145,"context_line":"        self.monitors \u003d monitor_handler.monitors"},{"line_number":146,"context_line":"        self.old_resources \u003d collections.defaultdict(objects.ComputeNode)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_e62768b4","line":143,"in_reply_to":"5f7c97a3_20b30837","updated":"2018-08-01 15:05:33.000000000","message":"@Sylvain, see below, but I\u0027m not really following you, and I don\u0027t think it buys us anything.","commit_id":"3a022299c13ff6a0a949c05c54fdc7331416a0b0"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"28579f727e20e1472133ae41c4c6dd886b5a2f39","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        self.stats \u003d stats.Stats()"},{"line_number":141,"context_line":"        self.tracked_instances \u003d {}"},{"line_number":142,"context_line":"        self.tracked_migrations \u003d {}"},{"line_number":143,"context_line":"        self.is_bfv \u003d {}  # dict, keyed by instance uuid, to is_bfv boolean"},{"line_number":144,"context_line":"        monitor_handler \u003d monitors.MonitorHandler(self)"},{"line_number":145,"context_line":"        self.monitors \u003d monitor_handler.monitors"},{"line_number":146,"context_line":"        self.old_resources \u003d collections.defaultdict(objects.ComputeNode)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_20b30837","line":143,"in_reply_to":"5f7c97a3_41109c4c","updated":"2018-08-01 14:07:06.000000000","message":"We already cache the instance primitives in self.tracked_instances and we make sure to update this cache correctly (and remove items when we need). Could we reuse this cache instead of trying to have yet another cache ?","commit_id":"3a022299c13ff6a0a949c05c54fdc7331416a0b0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e407742f21c0b7e485feeb0d5f6dca8897cf589c","unresolved":false,"context_lines":[{"line_number":1157,"context_line":"        instances assigned to the local compute host, even if they are not"},{"line_number":1158,"context_line":"        currently powered on."},{"line_number":1159,"context_line":"        \"\"\""},{"line_number":1160,"context_line":"        self.tracked_instances.clear()"},{"line_number":1161,"context_line":""},{"line_number":1162,"context_line":"        cn \u003d self.compute_nodes[nodename]"},{"line_number":1163,"context_line":"        # set some initial values, reserve room for host/hypervisor:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_8601d405","line":1160,"updated":"2018-08-01 15:05:33.000000000","message":"Sylvain, we clear the tracked_instances cache during ever update_available_resource periodic run, which means if we re-used this somehow (I\u0027m not sure how you propose to re-use it), it would still mean we\u0027d have to re-lookup whether or not every instance is bfv or not, since that\u0027s not something stored directly on the instance object.","commit_id":"3a022299c13ff6a0a949c05c54fdc7331416a0b0"}]}