)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"72f74ce335d6ecbd704298457f9a9d247a18ed62","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sean Mooney \u003cwork@seanmooney.info\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-07-23 19:43:19 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix disk_bus handeling"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- This change fixes handeling of the root"},{"line_number":10,"context_line":"  disk device bus selection in libvirt blockinfo.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_48eaabd9","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":22},"updated":"2018-07-24 02:44:22.000000000","message":"handling?","commit_id":"1bb9c6ae9bec5aa7cfbad6d9b6f4c169571d177e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"996f13f522e36a24648701560cedc34856597342","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sean Mooney \u003cwork@seanmooney.info\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-07-23 19:43:19 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix disk_bus handeling"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- This change fixes handeling of the root"},{"line_number":10,"context_line":"  disk device bus selection in libvirt blockinfo.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_5be82914","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":22},"in_reply_to":"5f7c97a3_48eaabd9","updated":"2018-07-31 18:41:38.000000000","message":"ye yes you are correct. i am just finishing a unit test to assert the correct behavior.\ni will address this when i submit. :)","commit_id":"1bb9c6ae9bec5aa7cfbad6d9b6f4c169571d177e"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"72f74ce335d6ecbd704298457f9a9d247a18ed62","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix disk_bus handeling"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- This change fixes handeling of the root"},{"line_number":10,"context_line":"  disk device bus selection in libvirt blockinfo.py"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I63836f461507f4924dc8f3491ef518a4ce4d32f9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_68e76711","line":9,"range":{"start_line":9,"start_character":20,"end_line":9,"end_character":29},"updated":"2018-07-24 02:44:22.000000000","message":"ditto","commit_id":"1bb9c6ae9bec5aa7cfbad6d9b6f4c169571d177e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fead51b33dc63afd1f1439a7f3d64ba19ac5df54","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sean Mooney \u003cwork@seanmooney.info\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-07-24 15:23:41 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix disk_bus handling"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- This change fixes handling of the root"},{"line_number":10,"context_line":"  disk device bus selection in libvirt blockinfo.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_8624a660","line":7,"updated":"2018-07-30 20:01:12.000000000","message":"Prefix with libvirt:\n\nlibvirt: fix disk_bus handling for root disks\n\n?","commit_id":"7ceb8e39f475df4891e5adc8c8a41c6120948a97"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fead51b33dc63afd1f1439a7f3d64ba19ac5df54","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix disk_bus handling"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- This change fixes handling of the root"},{"line_number":10,"context_line":"  disk device bus selection in libvirt blockinfo.py"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I63836f461507f4924dc8f3491ef518a4ce4d32f9"},{"line_number":13,"context_line":"Closes-Bug: 1759420"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_c62e1e41","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":51},"updated":"2018-07-30 20:01:12.000000000","message":"This doesn\u0027t explain the problem nor how it\u0027s solved by this change.","commit_id":"7ceb8e39f475df4891e5adc8c8a41c6120948a97"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"a0fbade27b9d5abe509360fd640df2b48c6d0078","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  to specify the bus to which guest hard disk"},{"line_number":11,"context_line":"  images are attached for libvirt instances."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- In commit 7be531fe9462f2b07d4a1abf6687f649d1dfbb89"},{"line_number":14,"context_line":"  the libvirt disk mappings were refactored. As"},{"line_number":15,"context_line":"  part of that change a lossy conversion was introduced"},{"line_number":16,"context_line":"  which resulted in multiple disk buses being mapped"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f79a3b5_f90be178","line":13,"updated":"2018-10-11 14:05:16.000000000","message":"so, more than five years ago...","commit_id":"1ba150fa5233ebeacdc02e89b2e83a1a6861bc19"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"a0fbade27b9d5abe509360fd640df2b48c6d0078","unresolved":false,"context_lines":[{"line_number":19,"context_line":"- As a result of this lossy mapping hw_disk_bus\u003dsata"},{"line_number":20,"context_line":"  and hw_disk_bus\u003dusb were mapped to the same prefix"},{"line_number":21,"context_line":"  as scsi \"sd\". this resulted in the request to use"},{"line_number":22,"context_line":"  sata or usb root disk being ignored."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- This change fixes handling of the root"},{"line_number":25,"context_line":"  disk device bus selection in libvirt blockinfo.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f79a3b5_b94fa9bc","line":22,"updated":"2018-10-11 14:05:16.000000000","message":"I asked this on the bug in question, but what are the *actual* ramifications of the bus being set to \u0027scsi\u0027 instead of the requested \u0027usb\u0027 or \u0027sata\u0027? Clearly, since this code has been in Nova for 5+ years, there\u0027s not really any negative ramifications (like the disk not being accessible) but I\u0027m curious if there\u0027s any real impact to this.","commit_id":"1ba150fa5233ebeacdc02e89b2e83a1a6861bc19"}],"nova/tests/unit/virt/libvirt/test_blockinfo.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9db35bfbae843b6b9d61d1c75fbd3002adad9aa6","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        mapping \u003d blockinfo.get_disk_mapping(\"kvm\", instance_ref,"},{"line_number":210,"context_line":"                                             \"virtio\", \"ide\","},{"line_number":211,"context_line":"                                             image_meta,"},{"line_number":212,"context_line":"                                             block_device_info)"},{"line_number":213,"context_line":"        expect \u003d {"},{"line_number":214,"context_line":"            \u0027disk\u0027: {\u0027bus\u0027: \u0027virtio\u0027, \u0027dev\u0027: \u0027sda\u0027,"},{"line_number":215,"context_line":"                     \u0027type\u0027: \u0027disk\u0027, \u0027boot_index\u0027: \u00271\u0027},"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_742e7dac","line":212,"updated":"2018-08-28 21:09:55.000000000","message":"Note to self: so get_disk_mapping calls get_root_info, and sets that in the mapping for \u0027root\u0027 and \u0027disk\u0027 if there\u0027s no root BDM and no volume in the mapping. So, in this test, we see that with the fix, the root device bus is being preserved as \u0027virtio\u0027 (as was passed to get_disk_mapping) instead of being changed to \u0027scsi\u0027.","commit_id":"9c13fa726b0338757ccf63f81c60a2bf266635e9"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"a0fbade27b9d5abe509360fd640df2b48c6d0078","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            }"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        mapping \u003d blockinfo.get_disk_mapping(\"kvm\", instance_ref,"},{"line_number":210,"context_line":"                                             \"virtio\", \"ide\","},{"line_number":211,"context_line":"                                             image_meta,"},{"line_number":212,"context_line":"                                             block_device_info)"},{"line_number":213,"context_line":"        expect \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_f938c1ed","line":210,"range":{"start_line":210,"start_character":55,"end_line":210,"end_character":60},"updated":"2018-10-11 14:05:16.000000000","message":"a note for reviewers who might be thinking that the \u0027bus\u0027 attribute should be \u0027ide\u0027 below and not \u0027virtio\u0027, this is the **cdrom_bus** not the primary disk bus... :( confusing.","commit_id":"1ba150fa5233ebeacdc02e89b2e83a1a6861bc19"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9e01325300da6f668bafb46e26b4a33b22bcbcec","unresolved":false,"context_lines":[{"line_number":7125,"context_line":"    def test_xml_disk_bus_sata(self):"},{"line_number":7126,"context_line":"        # It\u0027s necessary to check if the architecture is power, because"},{"line_number":7127,"context_line":"        # power doesn\u0027t have support to ide, and so libvirt translate"},{"line_number":7128,"context_line":"        # all ide calls to scsi"},{"line_number":7129,"context_line":""},{"line_number":7130,"context_line":"        expected \u003d (\"disk\", \"sata\", \"sda\")"},{"line_number":7131,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_bb73e2e7","line":7128,"updated":"2018-07-31 18:23:59.000000000","message":"I see that this comment is copied from L7108 but I don\u0027t think it makes any sense here. There\u0027s nothing in this test about checking architecture or power or scsi.","commit_id":"8e30ba60163b7b9a4cb9270c3462247697ec7cae"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"996f13f522e36a24648701560cedc34856597342","unresolved":false,"context_lines":[{"line_number":7125,"context_line":"    def test_xml_disk_bus_sata(self):"},{"line_number":7126,"context_line":"        # It\u0027s necessary to check if the architecture is power, because"},{"line_number":7127,"context_line":"        # power doesn\u0027t have support to ide, and so libvirt translate"},{"line_number":7128,"context_line":"        # all ide calls to scsi"},{"line_number":7129,"context_line":""},{"line_number":7130,"context_line":"        expected \u003d (\"disk\", \"sata\", \"sda\")"},{"line_number":7131,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_3b483129","line":7128,"in_reply_to":"5f7c97a3_bb73e2e7","updated":"2018-07-31 18:41:38.000000000","message":"sorry yes its not needed.","commit_id":"8e30ba60163b7b9a4cb9270c3462247697ec7cae"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9e01325300da6f668bafb46e26b4a33b22bcbcec","unresolved":false,"context_lines":[{"line_number":7133,"context_line":"            \"hw_disk_bus\": \"sata\"}})"},{"line_number":7134,"context_line":"        self._check_xml_and_disk_bus(image_meta,"},{"line_number":7135,"context_line":"                                     None,"},{"line_number":7136,"context_line":"                                     (expected,))"},{"line_number":7137,"context_line":""},{"line_number":7138,"context_line":"    def test_xml_disk_bus_ide_and_virtio(self):"},{"line_number":7139,"context_line":"        # It\u0027s necessary to check if the architecture is power, because"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_bb520110","line":7136,"updated":"2018-07-31 18:23:59.000000000","message":"This test passes even without your fix. And I can\u0027t tell what is being tested here really. What was the incorrect disk bus in the past and what would be the correct disk bus now? I think those things should be evident from running the test with and without your fix.","commit_id":"8e30ba60163b7b9a4cb9270c3462247697ec7cae"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"996f13f522e36a24648701560cedc34856597342","unresolved":false,"context_lines":[{"line_number":7133,"context_line":"            \"hw_disk_bus\": \"sata\"}})"},{"line_number":7134,"context_line":"        self._check_xml_and_disk_bus(image_meta,"},{"line_number":7135,"context_line":"                                     None,"},{"line_number":7136,"context_line":"                                     (expected,))"},{"line_number":7137,"context_line":""},{"line_number":7138,"context_line":"    def test_xml_disk_bus_ide_and_virtio(self):"},{"line_number":7139,"context_line":"        # It\u0027s necessary to check if the architecture is power, because"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_1b1455e9","line":7136,"in_reply_to":"5f7c97a3_bb520110","updated":"2018-07-31 18:41:38.000000000","message":"really, damb i didnt check that. in the past if the disk bus was set to sata in the image the libvirt xml generated would be scsi. ill create a more dettailed set of tests. \n\nwhat im trying to assert here was that if i set the disk bus in the image to sata then the xml generated was also sata not scsi.","commit_id":"8e30ba60163b7b9a4cb9270c3462247697ec7cae"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a0862ab7ba7e9b3c125c8d001a0f842ebb6ceeda","unresolved":false,"context_lines":[{"line_number":7130,"context_line":"        expected \u003d (\"disk\", \"sata\", \"vda\")"},{"line_number":7131,"context_line":""},{"line_number":7132,"context_line":"        image_meta \u003d objects.ImageMeta.from_dict({\"properties\": {"},{"line_number":7133,"context_line":"            \"hw_disk_bus\": \"sata\"}})"},{"line_number":7134,"context_line":"        block_device_info \u003d {"},{"line_number":7135,"context_line":"                \u0027root_device_name\u0027: \"vda\""},{"line_number":7136,"context_line":"                }"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_6a0a4d1e","line":7133,"range":{"start_line":7133,"start_character":11,"end_line":7133,"end_character":24},"updated":"2018-07-31 21:32:05.000000000","message":"i should propably be asserting more here such as the disk bus of all other disks e.g. swap and epherrmeral \n\ni would exepct all disk to respect the value of hw_disk_bus not just the root. one of the reasons for having this value it to facilitate operating system images that only have driver for specific bus types. e.g. old versions fo cantos 6 or 5 that have buggy virtio/scsi support may not be able to handel a swap disk on virtio.","commit_id":"1ae04777ac5b420ce5a6d573e3fc8d323d820026"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a0862ab7ba7e9b3c125c8d001a0f842ebb6ceeda","unresolved":false,"context_lines":[{"line_number":7132,"context_line":"        image_meta \u003d objects.ImageMeta.from_dict({\"properties\": {"},{"line_number":7133,"context_line":"            \"hw_disk_bus\": \"sata\"}})"},{"line_number":7134,"context_line":"        block_device_info \u003d {"},{"line_number":7135,"context_line":"                \u0027root_device_name\u0027: \"vda\""},{"line_number":7136,"context_line":"                }"},{"line_number":7137,"context_line":"        self._check_xml_and_disk_bus(image_meta,"},{"line_number":7138,"context_line":"                                     block_device_info,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_cf5ff34a","line":7135,"range":{"start_line":7135,"start_character":35,"end_line":7135,"end_character":36},"updated":"2018-07-31 21:32:05.000000000","message":"the patch below this is going to fail pep8....","commit_id":"1ae04777ac5b420ce5a6d573e3fc8d323d820026"}],"nova/virt/libvirt/blockinfo.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9e01325300da6f668bafb46e26b4a33b22bcbcec","unresolved":false,"context_lines":[{"line_number":439,"context_line":"            root_device_bus \u003d disk_bus"},{"line_number":440,"context_line":"            root_device_type \u003d \u0027disk\u0027"},{"line_number":441,"context_line":"        if not root_device_name:"},{"line_number":442,"context_line":"            root_device_name \u003d find_disk_dev_for_disk_bus({}, root_device_bus)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"        return {\u0027bus\u0027: root_device_bus,"},{"line_number":445,"context_line":"                \u0027type\u0027: root_device_type,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_9b762592","line":442,"updated":"2018-07-31 18:23:59.000000000","message":"I don\u0027t really understand what\u0027s going on here, even after looking at the old refactor linked in the commit message. Before this fix, if we had a root_device_name, we would look up the disk bus for it right? And if we did not have a root_device_name, we would find the device for the disk bus.\n\nHow does removing the logic for finding the disk bus fix things?","commit_id":"8e30ba60163b7b9a4cb9270c3462247697ec7cae"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"996f13f522e36a24648701560cedc34856597342","unresolved":false,"context_lines":[{"line_number":439,"context_line":"            root_device_bus \u003d disk_bus"},{"line_number":440,"context_line":"            root_device_type \u003d \u0027disk\u0027"},{"line_number":441,"context_line":"        if not root_device_name:"},{"line_number":442,"context_line":"            root_device_name \u003d find_disk_dev_for_disk_bus({}, root_device_bus)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"        return {\u0027bus\u0027: root_device_bus,"},{"line_number":445,"context_line":"                \u0027type\u0027: root_device_type,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_bbad2184","line":442,"in_reply_to":"5f7c97a3_5b1e4d0d","updated":"2018-07-31 18:41:38.000000000","message":"no as far as i can tell form the original refactor there was no clear reason why we were ignoring the requested disk bus and generating it from the name. i think this was an over sight. \n\nit is possible that we should generate the disk bus form the name in the event that disk bus is None when this function is invoked but i cant see a case where that will happen as we will use the hypervior default in that case.","commit_id":"8e30ba60163b7b9a4cb9270c3462247697ec7cae"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a9a9ac914eb4aef649bc39c00d0cb79fa5f7f15b","unresolved":false,"context_lines":[{"line_number":439,"context_line":"            root_device_bus \u003d disk_bus"},{"line_number":440,"context_line":"            root_device_type \u003d \u0027disk\u0027"},{"line_number":441,"context_line":"        if not root_device_name:"},{"line_number":442,"context_line":"            root_device_name \u003d find_disk_dev_for_disk_bus({}, root_device_bus)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"        return {\u0027bus\u0027: root_device_bus,"},{"line_number":445,"context_line":"                \u0027type\u0027: root_device_type,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_5b1e4d0d","line":442,"in_reply_to":"5f7c97a3_9b762592","updated":"2018-07-31 18:31:40.000000000","message":"After re-reading the bug and commit message, I think you were saying that the get_disk_bus_for_disk_dev method does a guess based on a prefix, and we should not do that. I can see from the docstring in get_disk_bus_for_disk_dev indeed it does a guess. So, ignore my previous comment here.\n\nAnd we\u0027re already setting root_device_bus on L436 or L439. Do you have any idea why the previous code was trying to guess the root_device_bus even after setting it earlier?","commit_id":"8e30ba60163b7b9a4cb9270c3462247697ec7cae"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"1392606a194081ffcdef923797d1c491ef93fef0","unresolved":false,"context_lines":[{"line_number":438,"context_line":"        else:"},{"line_number":439,"context_line":"            root_device_bus \u003d disk_bus"},{"line_number":440,"context_line":"            root_device_type \u003d \u0027disk\u0027"},{"line_number":441,"context_line":"        if root_device_name:"},{"line_number":442,"context_line":"            root_device_bus \u003d get_disk_bus_for_disk_dev(virt_type,"},{"line_number":443,"context_line":"                                                        root_device_name)"},{"line_number":444,"context_line":"        else:"},{"line_number":445,"context_line":"            root_device_name \u003d find_disk_dev_for_disk_bus({}, root_device_bus)"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        return {\u0027bus\u0027: root_device_bus,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_c38aee62","side":"PARENT","line":444,"range":{"start_line":441,"start_character":0,"end_line":444,"end_character":13},"updated":"2018-08-31 13:25:00.000000000","message":"Yes makes sense we should refer to the disk_bus passed to that method I don\u0027t see any reason to see it wrong.","commit_id":"7ff198619030685d14d739dee645bf44eee30c22"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9db35bfbae843b6b9d61d1c75fbd3002adad9aa6","unresolved":false,"context_lines":[{"line_number":548,"context_line":""},{"line_number":549,"context_line":"    root_device_name \u003d block_device.strip_dev("},{"line_number":550,"context_line":"        driver.block_device_info_get_root_device(block_device_info))"},{"line_number":551,"context_line":"    root_info \u003d get_root_info("},{"line_number":552,"context_line":"        instance, virt_type, image_meta, root_bdm,"},{"line_number":553,"context_line":"        disk_bus, cdrom_bus, root_device_name)"},{"line_number":554,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_94655920","line":551,"updated":"2018-08-28 21:09:55.000000000","message":"Note: here\u0027s where get_root_info is called in get_disk_mapping.","commit_id":"9c13fa726b0338757ccf63f81c60a2bf266635e9"}]}