)]}'
{"nova/virt/hyperv/vmops.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"767aa5f0961598dfbf4eb2318ff3f660f2df0bb9","unresolved":false,"context_lines":[{"line_number":859,"context_line":"            self._volumeops.fix_instance_volume_disk_paths(instance.name,"},{"line_number":860,"context_line":"                                                           block_device_info)"},{"line_number":861,"context_line":""},{"line_number":862,"context_line":"        if should_plug_vifs:"},{"line_number":863,"context_line":"            self.plug_vifs(instance, network_info)"},{"line_number":864,"context_line":"        self._set_vm_state(instance, os_win_const.HYPERV_VM_STATE_ENABLED)"},{"line_number":865,"context_line":""},{"line_number":866,"context_line":"    def _set_vm_state(self, instance, req_state):"},{"line_number":867,"context_line":"        instance_name \u003d instance.name"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_8ee66149","line":864,"range":{"start_line":862,"start_character":0,"end_line":864,"end_character":74},"updated":"2018-07-25 13:44:16.000000000","message":"Can you explain why you changed the order here?","commit_id":"bef7e9a717f3bca45b5edd0ebc65ab1dde5942d9"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"ff73d211dccce65cee266566159b909210c7a62f","unresolved":false,"context_lines":[{"line_number":859,"context_line":"            self._volumeops.fix_instance_volume_disk_paths(instance.name,"},{"line_number":860,"context_line":"                                                           block_device_info)"},{"line_number":861,"context_line":""},{"line_number":862,"context_line":"        if should_plug_vifs:"},{"line_number":863,"context_line":"            self.plug_vifs(instance, network_info)"},{"line_number":864,"context_line":"        self._set_vm_state(instance, os_win_const.HYPERV_VM_STATE_ENABLED)"},{"line_number":865,"context_line":""},{"line_number":866,"context_line":"    def _set_vm_state(self, instance, req_state):"},{"line_number":867,"context_line":"        instance_name \u003d instance.name"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_912526b0","line":864,"range":{"start_line":862,"start_character":0,"end_line":864,"end_character":74},"in_reply_to":"5f7c97a3_8edae119","updated":"2018-07-25 14:19:36.000000000","message":"Sorry, I guess that\u0027s explained in the commit message, which I clearly didn\u0027t read carefully enough.  Thank you Lucian.","commit_id":"bef7e9a717f3bca45b5edd0ebc65ab1dde5942d9"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"c33de34daae876dc7c8378605a1cb255ed7205cb","unresolved":false,"context_lines":[{"line_number":859,"context_line":"            self._volumeops.fix_instance_volume_disk_paths(instance.name,"},{"line_number":860,"context_line":"                                                           block_device_info)"},{"line_number":861,"context_line":""},{"line_number":862,"context_line":"        if should_plug_vifs:"},{"line_number":863,"context_line":"            self.plug_vifs(instance, network_info)"},{"line_number":864,"context_line":"        self._set_vm_state(instance, os_win_const.HYPERV_VM_STATE_ENABLED)"},{"line_number":865,"context_line":""},{"line_number":866,"context_line":"    def _set_vm_state(self, instance, req_state):"},{"line_number":867,"context_line":"        instance_name \u003d instance.name"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_8edae119","line":864,"range":{"start_line":862,"start_character":0,"end_line":864,"end_character":74},"in_reply_to":"5f7c97a3_8ee66149","updated":"2018-07-25 14:02:01.000000000","message":"Due to the previous limitation of OVS (only affecting Windows, fixed since a while), we could not bind the ports before starting the VMs, which no longer applies. So we can now invert those operations, binding the port before actually starting the vm. \n\nAlthough quite unlikely, if the port binding takes too long, the instance may be unable to use it, for which reason it\u0027s safer to do it before starting the vm.","commit_id":"bef7e9a717f3bca45b5edd0ebc65ab1dde5942d9"}]}