)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0c8edbb1723ab4efbb06876cfc6f4772240c631d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"microversion when PUTting allocation with the consumer,"},{"line_number":15,"context_line":"which causes \"no consumer generation provided error\","},{"line_number":16,"context_line":"Because the generation field is needed from microversion"},{"line_number":17,"context_line":"1.28. To avoid the error, this patch also changes the code"},{"line_number":18,"context_line":"to get the current consumer generation and use it."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Tagged \"Work In Progress\" because tests should be added."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_3cf3d0ea","line":18,"range":{"start_line":17,"start_character":54,"end_line":18,"end_character":50},"updated":"2018-07-25 08:27:53.000000000","message":"I think this defeat the purpose of the consumer generations. I think we need to do the support for 1.28 first.","commit_id":"9fcf7e31d5cc5d5079df84d91007bafb54dd57b1"}],"doc/source/cli/nova-status.rst":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"853d7dae08471111b68b0ea548c421e135d13933","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"  **18.0.0 (Rocky)**"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"  * Checks for the Placement API are modified to require version 1.29."},{"line_number":112,"context_line":"  * Checks that ironic instances have had their embedded flavors migrated to"},{"line_number":113,"context_line":"    use custom resource classes."},{"line_number":114,"context_line":"  * Checks for ``nova-osapi_compute`` service versions that are less than 15"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_2b54aa21","line":111,"updated":"2018-09-17 09:23:37.000000000","message":"I think this needs to be moved to the Stein section now","commit_id":"43a8f0b18307f60a6204e76a77d2f0d9cf9c83d1"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d178d885391ab38e03947c6f8e67770eeb57bf1b","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"  **18.0.0 (Rocky)**"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"  * Checks for the Placement API are modified to require version 1.29."},{"line_number":112,"context_line":"  * Checks that ironic instances have had their embedded flavors migrated to"},{"line_number":113,"context_line":"    use custom resource classes."},{"line_number":114,"context_line":"  * Checks for ``nova-osapi_compute`` service versions that are less than 15"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_2b290a9b","line":111,"in_reply_to":"3f79a3b5_2b54aa21","updated":"2018-09-17 09:24:13.000000000","message":"That\u0027s correct","commit_id":"43a8f0b18307f60a6204e76a77d2f0d9cf9c83d1"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3f536e44d7e12b9f9459c4f429a85da91d140917","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"  **19.0.0 (Stein)**"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"  * Checks for the Placement API are modified to require version 1.30."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"See Also"},{"line_number":126,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_8e370ce4","line":123,"updated":"2018-09-17 09:32:04.000000000","message":"well, technically, since this, we no longer need the above","commit_id":"43a8f0b18307f60a6204e76a77d2f0d9cf9c83d1"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"92ed74e136b93c89505946323b2a7ae1dc5ccf12","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"  **19.0.0 (Stein)**"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"  * Checks for the Placement API are modified to require version 1.30."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"See Also"},{"line_number":126,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_4e42543d","line":123,"in_reply_to":"3f79a3b5_8e370ce4","updated":"2018-09-17 09:33:38.000000000","message":"ohh, yeah. then just drop the above","commit_id":"43a8f0b18307f60a6204e76a77d2f0d9cf9c83d1"}],"nova/scheduler/client/report.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"159b1cc86f395a51175797ff1ed6895a3623bdcc","unresolved":false,"context_lines":[{"line_number":1633,"context_line":""},{"line_number":1634,"context_line":"        # If the allocation_request_version less than 1.12, then convert the"},{"line_number":1635,"context_line":"        # allocation array format to the dict format. This conversion can be"},{"line_number":1636,"context_line":"        # remove in Rocky release."},{"line_number":1637,"context_line":"        if versionutils.convert_version_to_tuple("},{"line_number":1638,"context_line":"                allocation_request_version) \u003c (1, 12):"},{"line_number":1639,"context_line":"            ar \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_7c9f08b3","line":1636,"updated":"2018-07-25 08:20:38.000000000","message":"should we remove this transformation?","commit_id":"9fcf7e31d5cc5d5079df84d91007bafb54dd57b1"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0441695d93bc2e4d4bce721fedb13f36d8e78b91","unresolved":false,"context_lines":[{"line_number":1633,"context_line":""},{"line_number":1634,"context_line":"        # If the allocation_request_version less than 1.12, then convert the"},{"line_number":1635,"context_line":"        # allocation array format to the dict format. This conversion can be"},{"line_number":1636,"context_line":"        # remove in Rocky release."},{"line_number":1637,"context_line":"        if versionutils.convert_version_to_tuple("},{"line_number":1638,"context_line":"                allocation_request_version) \u003c (1, 12):"},{"line_number":1639,"context_line":"            ar \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_8ecf41b1","line":1636,"in_reply_to":"5f7c97a3_7c9f08b3","updated":"2018-07-25 13:47:23.000000000","message":"gibi is removing it in [1] but couldn\u0027t hurt to do it in both.\n\n[1] https://review.openstack.org/#/c/583667/","commit_id":"9fcf7e31d5cc5d5079df84d91007bafb54dd57b1"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0c8edbb1723ab4efbb06876cfc6f4772240c631d","unresolved":false,"context_lines":[{"line_number":1648,"context_line":"        url \u003d \u0027/allocations/%s\u0027 % consumer_uuid"},{"line_number":1649,"context_line":""},{"line_number":1650,"context_line":"        payload \u003d ar"},{"line_number":1651,"context_line":"        payload[\u0027consumer_generation\u0027] \u003d None"},{"line_number":1652,"context_line":""},{"line_number":1653,"context_line":"        # We first need to determine if this is a move operation and if so"},{"line_number":1654,"context_line":"        # create the \"doubled-up\" allocation that exists for the duration of"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_7cc6289f","line":1651,"updated":"2018-07-25 08:27:53.000000000","message":"I think we have to do 1.28 first to make sure proper consumer_generation handling is in place.","commit_id":"9fcf7e31d5cc5d5079df84d91007bafb54dd57b1"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0c8edbb1723ab4efbb06876cfc6f4772240c631d","unresolved":false,"context_lines":[{"line_number":1659,"context_line":"            current_allocs \u003d r.json()[\u0027allocations\u0027]"},{"line_number":1660,"context_line":"            if current_allocs:"},{"line_number":1661,"context_line":"                payload \u003d _move_operation_alloc_request(current_allocs, ar)"},{"line_number":1662,"context_line":"                payload[\u0027consumer_generation\u0027] \u003d r.json().get(\u0027consumer_generation\u0027)"},{"line_number":1663,"context_line":""},{"line_number":1664,"context_line":"        payload[\u0027project_id\u0027] \u003d project_id"},{"line_number":1665,"context_line":"        payload[\u0027user_id\u0027] \u003d user_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_5cbb2c0f","line":1662,"updated":"2018-07-25 08:27:53.000000000","message":"Unfortunately this needs to be lot more complicated if we want to take care for consumer generations properly. \n\nSee https://review.openstack.org/#/c/583667/ where I try to add support for consumer_generation (1.28)","commit_id":"9fcf7e31d5cc5d5079df84d91007bafb54dd57b1"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"bd1cd5860077e7c5de70e23d8825be075c8b0961","unresolved":false,"context_lines":[{"line_number":1659,"context_line":"            current_allocs \u003d r.json()[\u0027allocations\u0027]"},{"line_number":1660,"context_line":"            if current_allocs:"},{"line_number":1661,"context_line":"                payload \u003d _move_operation_alloc_request(current_allocs, ar)"},{"line_number":1662,"context_line":"                payload[\u0027consumer_generation\u0027] \u003d r.json().get(\u0027consumer_generation\u0027)"},{"line_number":1663,"context_line":""},{"line_number":1664,"context_line":"        payload[\u0027project_id\u0027] \u003d project_id"},{"line_number":1665,"context_line":"        payload[\u0027user_id\u0027] \u003d user_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_bc00406b","line":1662,"in_reply_to":"5f7c97a3_5cbb2c0f","updated":"2018-07-25 08:37:49.000000000","message":"Okay, it is good to know that it is already being under work. I\u0027ll have it a look. Thanks!","commit_id":"9fcf7e31d5cc5d5079df84d91007bafb54dd57b1"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f6ce0118aaf78ed441cf511f3e218807ce823877","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                            \"(.+) in use\")"},{"line_number":48,"context_line":"WARN_EVERY \u003d 10"},{"line_number":49,"context_line":"PLACEMENT_CLIENT_SEMAPHORE \u003d \u0027placement_client\u0027"},{"line_number":50,"context_line":"CONSUMER_GENERATION_VERSION \u003d \u00271.28\u0027"},{"line_number":51,"context_line":"NESTED_AC_VERSION \u003d \u00271.29\u0027"},{"line_number":52,"context_line":"ALLOW_RESERVED_EQUAL_TOTAL_INVENTORY_VERSION \u003d \u00271.26\u0027"},{"line_number":53,"context_line":"POST_RPS_RETURNS_PAYLOAD_API_VERSION \u003d \u00271.20\u0027"},{"line_number":54,"context_line":"AGGREGATE_GENERATION_VERSION \u003d \u00271.19\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_05c72348","line":51,"range":{"start_line":50,"start_character":0,"end_line":51,"end_character":26},"updated":"2018-07-31 08:30:35.000000000","message":"nit: based on the pattern below the version constants are ordered from highest to lowest, so you have to switch these two.","commit_id":"cc959fb3ceb9841755403f21dfe06671c6f3589d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"050e9851bc10ed6f0f898a5f91662f89efae93ab","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        \"\"\""},{"line_number":353,"context_line":"        # Note that claim_resources() will use this version as well to"},{"line_number":354,"context_line":"        # make allocations by `PUT /allocations/{consumer_uuid}`"},{"line_number":355,"context_line":"        version \u003d NESTED_AC_VERSION"},{"line_number":356,"context_line":"        qparams \u003d resources.to_querystring()"},{"line_number":357,"context_line":"        url \u003d \"/allocation_candidates?%s\" % qparams"},{"line_number":358,"context_line":"        resp \u003d self.get(url, version\u003dversion,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_9fe7dbab","line":355,"range":{"start_line":355,"start_character":18,"end_line":355,"end_character":35},"updated":"2018-10-03 16:33:05.000000000","message":"Yeah, see, *here* we need to do this.","commit_id":"b0e1f7ae4b7db5c45e04fd7e51f46bf840eda1b8"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f988f5f3af1426d182b72ef7192bed56b5b680bc","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        \"\"\""},{"line_number":353,"context_line":"        # Note that claim_resources() will use this version as well to"},{"line_number":354,"context_line":"        # make allocations by `PUT /allocations/{consumer_uuid}`"},{"line_number":355,"context_line":"        version \u003d NESTED_AC_VERSION"},{"line_number":356,"context_line":"        qparams \u003d resources.to_querystring()"},{"line_number":357,"context_line":"        url \u003d \"/allocation_candidates?%s\" % qparams"},{"line_number":358,"context_line":"        resp \u003d self.get(url, version\u003dversion,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_6c61ea10","line":355,"range":{"start_line":355,"start_character":18,"end_line":355,"end_character":35},"in_reply_to":"3f79a3b5_9fe7dbab","updated":"2018-10-04 11:42:05.000000000","message":"if I squash this and the previous patch together then we can skip bumping the version intermittently to CONSUMER_GENERATION_VERSION but I hope you don\u0027t want to ask me to do that.","commit_id":"b0e1f7ae4b7db5c45e04fd7e51f46bf840eda1b8"}]}