)]}'
{"id":"openstack%2Fnova~585778","triplet_id":"openstack%2Fnova~master~Ice89e9a25f74caaa53b7df079bd529d172354524","project":"openstack/nova","branch":"master","topic":"bp/placement-extract","hashtags":[],"change_id":"Ice89e9a25f74caaa53b7df079bd529d172354524","subject":"[placement] Use base test in placement functional tests","status":"MERGED","created":"2018-07-25 15:01:17.000000000","updated":"2018-08-02 23:12:17.000000000","submitted":"2018-07-27 11:49:16.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":10,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"585778-1532692156364-3ebd00cc","meta_rev_id":"da559823938752e376e53aaeb013748169de4bbd","_number":585778,"virtual_id_number":585778,"owner":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2018-07-26 20:28:23.000000000","_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"date":"2018-07-26 21:07:44.000000000","_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"date":"2018-07-26 18:53:07.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"date":"2018-07-26 17:22:16.000000000","_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},{"value":0,"date":"2018-08-02 23:12:17.000000000","post_submit":true,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"date":"2018-07-26 17:43:11.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":2,"date":"2018-07-27 11:49:16.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"all":[{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":2,"date":"2018-07-26 18:38:19.000000000","_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":2,"date":"2018-07-27 07:42:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"all":[{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":1,"date":"2018-07-27 10:01:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-07-26 06:02:40.000000000","updated_by":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-07-26 17:22:16.000000000","updated_by":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"reviewer":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-07-26 17:43:11.000000000","updated_by":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"reviewer":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"state":"REVIEWER"},{"updated":"2018-07-26 18:38:19.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2018-07-26 18:53:07.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2018-07-26 20:28:23.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-07-26 21:07:44.000000000","updated_by":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-07-27 10:01:23.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2018-07-27 11:49:16.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-08-02 23:12:17.000000000","updated_by":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ada152f691e4b73830aa581b1cadba53344c8961","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2018-07-25 15:01:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3aa5cbf6fcbe575592726860618c27cf87ca963f","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2018-07-25 15:04:07.000000000","message":"Patch Set 1:\n\nBuild failed\n\n- dsvm-nova http://207.189.188.190/logs/78/585778/1/check-vote/ext-nova-zuul/334016c : FAILURE in 37s","accounts_in_message":[],"_revision_number":1},{"id":"6b477b6b5c3a02a7f14fd967a4502c975754cc97","author":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"date":"2018-07-25 15:28:47.000000000","message":"Patch Set 1:\n\n* pci-test http://52.27.155.124/pci/585778/1 : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"299358762646f6e05335ff43e9959183a1cdcc1c","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2018-07-25 15:39:06.000000000","message":"Patch Set 1: Code-Review+2\n\nLGTM!\nCheers,\ngibi","accounts_in_message":[],"_revision_number":1},{"id":"b1aba3fafcb107759ecbdd2fcd3845d143e55c70","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2018-07-25 17:03:44.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/585778/1 : SUCCESS in 2h 01m 38s","accounts_in_message":[],"_revision_number":1},{"id":"e1a281e08b6f7613bc9d38fa262c22e60ddd8fc7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-25 17:53:38.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/78/585778/1/check/openstack-tox-pep8/20e21f7/ : SUCCESS in 13m 09s\n- openstack-tox-py27 http://logs.openstack.org/78/585778/1/check/openstack-tox-py27/1efcb66/ : SUCCESS in 12m 52s\n- openstack-tox-py35 http://logs.openstack.org/78/585778/1/check/openstack-tox-py35/1d6fe83/ : SUCCESS in 15m 44s\n- build-openstack-sphinx-docs http://logs.openstack.org/78/585778/1/check/build-openstack-sphinx-docs/2438219/html/ : SUCCESS in 7m 18s\n- tempest-full-py3 http://logs.openstack.org/78/585778/1/check/tempest-full-py3/ad276b3/ : SUCCESS in 1h 28m 00s\n- nova-tox-functional http://logs.openstack.org/78/585778/1/check/nova-tox-functional/0d1b0a0/ : FAILURE in 9m 01s\n- nova-tox-functional-py35 http://logs.openstack.org/78/585778/1/check/nova-tox-functional-py35/a23691e/ : FAILURE in 8m 25s\n- openstack-tox-lower-constraints http://logs.openstack.org/78/585778/1/check/openstack-tox-lower-constraints/afbe0a7/ : FAILURE in 13m 00s","accounts_in_message":[],"_revision_number":1},{"id":"74bf50626877ebf55b8b228ef70398b5440c5766","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2018-07-25 19:10:10.000000000","message":"Patch Set 1: Workflow-1\n\nhmmm, something clearly very wrong here, investigating","accounts_in_message":[],"_revision_number":1},{"id":"215c1b5012410c63f29eb49587542a5ed6e63bd2","author":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"date":"2018-07-25 20:12:10.000000000","message":"Patch Set 1:\n\nBuild failed. Comment \u0027powervm: recheck\u0027 to recheck.\n For 3rd party CI contact info: https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI\n\n- nova-out-of-tree-pvm http://184.172.12.213/78/585778/1/check/nova-out-of-tree-pvm/7f20817 : FAILURE in 2h 35m 48s\n- nova-in-tree-pvm http://184.172.12.213/78/585778/1/check/nova-in-tree-pvm/9f028db : FAILURE in 5h 01m 02s","accounts_in_message":[],"_revision_number":1},{"id":"f9250e9529debd5130a643e3a62f9a5bd4243d06","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2018-07-25 22:17:56.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nWeird, none of your code changes are outside of the placement realm, yet a bunch of the failures are on the nova side.","accounts_in_message":[],"_revision_number":1},{"id":"d8a8d2575d87a621bfba83fa3a863507e88947f1","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2018-07-25 22:26:56.000000000","message":"Patch Set 1:\n\n\u003e Weird, none of your code changes are outside of the placement\n \u003e realm, yet a bunch of the failures are on the nova side.\n\nI haven\u0027t quite figured it out yet, but I\u0027m getting closer. It basically comes down to the fact that there are some globals in the fixtures (on both sides).","accounts_in_message":[],"_revision_number":1},{"id":"48b8838e453017097aaa26ee568605d70b5b6adc","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2018-07-25 23:15:27.000000000","message":"Patch Set 1:\n\nTesting completed on the zVM Driver CI system check-nova pipeline and failed.  To recheck only the zVM driver plugins, submit a comment with only  zvm: recheck in the comment.. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-22022 : FAILURE in 6h 27m 19s","accounts_in_message":[],"_revision_number":1},{"id":"42bb6ceebd4d38e9ef9453096496a0fa5fd7c1a1","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2018-07-26 01:01:19.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5101adb6a7af0a10585aa738397c330637395745","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2018-07-26 01:04:17.000000000","message":"Patch Set 2:\n\nI hope this fixes what was ailing things before.\n\nThe root of the problem is: https://github.com/openstack/nova/blob/master/nova/tests/fixtures.py#L582-L586\n\nbut doing something like clearing SESSION_CONFIGURED wasn\u0027t working for reasons too long to untangle here at this late hour. It was a maze of twisty passages, I hope the result captures the desired behavior. Of course it could still be broken...","accounts_in_message":[],"_revision_number":2},{"id":"517b74f9f650b53e18db86dfa8159903411a9419","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-26 02:29:24.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/78/585778/2/check/openstack-tox-pep8/e79e47d/ : SUCCESS in 10m 17s\n- openstack-tox-py27 http://logs.openstack.org/78/585778/2/check/openstack-tox-py27/34b7b48/ : SUCCESS in 13m 48s\n- openstack-tox-py35 http://logs.openstack.org/78/585778/2/check/openstack-tox-py35/1f690e2/ : SUCCESS in 15m 43s\n- build-openstack-sphinx-docs http://logs.openstack.org/78/585778/2/check/build-openstack-sphinx-docs/be8e12e/html/ : SUCCESS in 7m 25s\n- tempest-full-py3 http://logs.openstack.org/78/585778/2/check/tempest-full-py3/7f58435/ : SUCCESS in 1h 22m 07s\n- nova-tox-functional http://logs.openstack.org/78/585778/2/check/nova-tox-functional/8932100/ : SUCCESS in 19m 22s\n- nova-tox-functional-py35 http://logs.openstack.org/78/585778/2/check/nova-tox-functional-py35/d73b019/ : SUCCESS in 19m 26s\n- openstack-tox-lower-constraints http://logs.openstack.org/78/585778/2/check/openstack-tox-lower-constraints/dbbd505/ : SUCCESS in 13m 15s","accounts_in_message":[],"_revision_number":2},{"id":"cc2d4e46d49926325231f345f5349fea193e152d","author":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"date":"2018-07-26 02:29:38.000000000","message":"Patch Set 2:\n\n* pci-test http://52.27.155.124/pci/585778/2 : FAILURE","accounts_in_message":[],"_revision_number":2},{"id":"ae2e04904906485dfb155b7e1d96a190e1dd347b","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2018-07-26 03:04:09.000000000","message":"Patch Set 2:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/585778/2 : SUCCESS in 2h 01m 54s","accounts_in_message":[],"_revision_number":2},{"id":"b11a5acab6290ed4d26182d5c0adf9255c95a6d6","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2018-07-26 04:54:19.000000000","message":"Patch Set 2:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-78-585778-2 : FAILURE \n\nSee https://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI for rechecking and info.","accounts_in_message":[],"_revision_number":2},{"id":"8c44ecd4f931bdb658c72fc0adb97f6d151091ad","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2018-07-26 05:13:55.000000000","message":"Patch Set 2:\n\nTesting completed on the zVM Driver CI system check-nova pipeline.  To recheck only the zVM driver plugins, submit a comment with only zvm: recheck in the comment. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-22047 : SUCCESS in 2h 01m 05s","accounts_in_message":[],"_revision_number":2},{"id":"1c6662da701db2e16cc4dc3bc3c5dbc01be08c9c","author":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"date":"2018-07-26 06:02:40.000000000","message":"Patch Set 2:\n\nBuild failed. Comment \u0027powervm: recheck\u0027 to recheck.\n For 3rd party CI contact info: https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI\n\n- nova-out-of-tree-pvm http://184.172.12.213/78/585778/2/check/nova-out-of-tree-pvm/e9f0c6c : FAILURE in 2h 25m 48s\n- nova-in-tree-pvm http://184.172.12.213/78/585778/2/check/nova-in-tree-pvm/c659291 : FAILURE in 5h 00m 49s","accounts_in_message":[],"_revision_number":2},{"id":"e11431ab581c60350a24dc9af4a510b30879673e","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2018-07-26 15:26:12.000000000","message":"Patch Set 2:\n\nBuild succeeded\n\n- dsvm-nova http://207.189.188.190/logs/78/585778/2/check-vote/ext-nova-zuul/33dc3d0 : SUCCESS in 47m 08s","accounts_in_message":[],"_revision_number":2},{"id":"bd3e15975455283809504ec3c73e63c6ac9a3de4","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2018-07-26 16:14:58.000000000","message":"Patch Set 2:\n\n(6 comments)\n\nOverall moving in a good direction. Some of this stuff is above my head, but if it passes tests, I guess it\u0027s good.\n\nGonna hold off voting for some minor discussion points noted inline.","accounts_in_message":[],"_revision_number":2},{"id":"13d0e6d55a0afed2735c2d462dffa3e335020a4f","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2018-07-26 16:26:57.000000000","message":"Patch Set 2:\n\n(3 comments)\n\nresponses within","accounts_in_message":[],"_revision_number":2},{"id":"69056b08e44bfbd71cf21caf01bb47a564733bd8","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2018-07-26 16:54:09.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"c6f5eb33b4517e3c6c27d878ccfbddc028d9b537","author":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"date":"2018-07-26 17:22:16.000000000","message":"Patch Set 3:\n\n* pci-test http://52.27.155.124/pci/585778/3 : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"b3fb3e887b7d300fe6a6bd8e484770e1b5a1d56a","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2018-07-26 17:43:11.000000000","message":"Patch Set 3:\n\nTesting completed on the zVM Driver CI system check-nova pipeline and failed.  To recheck only the zVM driver plugins, submit a comment with only  zvm: recheck in the comment.. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-22079 : FAILURE in 48m 29s","accounts_in_message":[],"_revision_number":3},{"id":"1e9038ea8423b8a539e36df2b610920152b72f77","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2018-07-26 18:38:19.000000000","message":"Patch Set 3: Code-Review+2\n\nfair","accounts_in_message":[],"_revision_number":3},{"id":"7311bb677da52be28e896ed393c2bc309c93e299","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2018-07-26 18:53:07.000000000","message":"Patch Set 3:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/585778/3 : SUCCESS in 1h 58m 20s","accounts_in_message":[],"_revision_number":3},{"id":"580b34bd1dded80a122752b25fc5572c98f70f7c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-26 19:43:11.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/78/585778/3/check/openstack-tox-pep8/c64d7f9/ : SUCCESS in 14m 13s\n- openstack-tox-py27 http://logs.openstack.org/78/585778/3/check/openstack-tox-py27/13b87c0/ : SUCCESS in 14m 03s\n- openstack-tox-py35 http://logs.openstack.org/78/585778/3/check/openstack-tox-py35/61eb4f4/ : SUCCESS in 15m 20s\n- build-openstack-sphinx-docs http://logs.openstack.org/78/585778/3/check/build-openstack-sphinx-docs/3917330/html/ : SUCCESS in 8m 35s\n- tempest-full-py3 http://logs.openstack.org/78/585778/3/check/tempest-full-py3/ab178b6/ : SUCCESS in 1h 36m 16s\n- nova-tox-functional http://logs.openstack.org/78/585778/3/check/nova-tox-functional/07bfb1a/ : SUCCESS in 17m 38s\n- nova-tox-functional-py35 http://logs.openstack.org/78/585778/3/check/nova-tox-functional-py35/e54cf45/ : SUCCESS in 19m 17s\n- openstack-tox-lower-constraints http://logs.openstack.org/78/585778/3/check/openstack-tox-lower-constraints/5bca708/ : SUCCESS in 13m 15s","accounts_in_message":[],"_revision_number":3},{"id":"e258291cae2ab784ed6df5bb82aebf50c0289c5c","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2018-07-26 20:28:23.000000000","message":"Patch Set 3:\n\nBuild succeeded\n\n- dsvm-nova http://207.189.188.190/logs/78/585778/3/check-vote/ext-nova-zuul/fdf8a0e : SUCCESS in 47m 59s","accounts_in_message":[],"_revision_number":3},{"id":"79f1a25b5b96444997ab304a257fcf019a78a729","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2018-07-26 21:07:44.000000000","message":"Patch Set 3:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-78-585778-3 : FAILURE \n\nSee https://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI for rechecking and info.","accounts_in_message":[],"_revision_number":3},{"id":"968011bec29787c413f46842416f59445f5c12b4","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2018-07-27 07:42:31.000000000","message":"Patch Set 3: Code-Review+2\n\nLGTM, but we hit feature freeze. I can be convinced that this is just a refactor that is allowed after FF.\n\nCheers,\ngibi","accounts_in_message":[],"_revision_number":3},{"id":"0608bb503a0aaaafdb19e12f5dee7ab8d3df337b","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2018-07-27 10:01:23.000000000","message":"Patch Set 3: Workflow+1\n\nChris made me realize that it is a test only change, a test improvement so it can go in after FF. So I\u0027m approving it and blame the lack of caffeine.\nCheers,\ngibi","accounts_in_message":[],"_revision_number":3},{"id":"33102457caa83a669e29191a7e94a53a5db8cc4b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-27 10:03:34.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"bfe02c25942c0d1d2c96927668f4c9df170517e0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-27 11:49:16.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"e36ebe561921bf34e02638176af5eb256422dbb1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-27 11:49:16.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/78/585778/3/gate/openstack-tox-pep8/3a9467e/ : SUCCESS in 10m 56s\n- openstack-tox-py27 http://logs.openstack.org/78/585778/3/gate/openstack-tox-py27/37c88ba/ : SUCCESS in 13m 36s\n- openstack-tox-py35 http://logs.openstack.org/78/585778/3/gate/openstack-tox-py35/b5d1cde/ : SUCCESS in 13m 36s\n- build-openstack-sphinx-docs http://logs.openstack.org/78/585778/3/gate/build-openstack-sphinx-docs/d66c35a/html/ : SUCCESS in 7m 51s\n- tempest-full-py3 http://logs.openstack.org/78/585778/3/gate/tempest-full-py3/d4e8eff/ : SUCCESS in 1h 37m 58s\n- nova-tox-functional http://logs.openstack.org/78/585778/3/gate/nova-tox-functional/ed2f98a/ : SUCCESS in 19m 42s\n- nova-tox-functional-py35 http://logs.openstack.org/78/585778/3/gate/nova-tox-functional-py35/de09c41/ : SUCCESS in 21m 07s\n- openstack-tox-lower-constraints http://logs.openstack.org/78/585778/3/gate/openstack-tox-lower-constraints/53fffe4/ : SUCCESS in 13m 34s","accounts_in_message":[],"_revision_number":3},{"id":"7261bd632169c7be88015719b1ff876e0265fff7","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2018-08-02 23:12:17.000000000","message":"Patch Set 3:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-intel-nfv-xenial http://52.27.155.124/portland/2018-08-02/585778/3/check/tempest-dsvm-intel-nfv-xenial/5edb786 : EXCEPTION (non-voting)\n- tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial http://52.27.155.124/portland/2018-08-02/585778/3/check/tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial/9131448 : EXCEPTION (non-voting)\n- tempest-dsvm-ovsdpdk-nfv-networking-xenial http://52.27.155.124/portland/2018-08-02/585778/3/check/tempest-dsvm-ovsdpdk-nfv-networking-xenial/5937524 : EXCEPTION (non-voting)","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"f5783d90bcb0b52469d0e0ada3933271afb84e2a","revisions":{"9358e903958ef9b71346235339cb4b7b08e3e19c":{"kind":"REWORK","_number":1,"created":"2018-07-25 15:01:17.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/78/585778/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/78/585778/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/78/585778/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/78/585778/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/78/585778/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/78/585778/1"}}},"commit":{"parents":[{"commit":"f2533b73a76f79d1445864b990600fd43b07592a","subject":"[placement] Extract base functional test case from test_direct","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f2533b73a76f79d1445864b990600fd43b07592a"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2018-07-25 14:40:37.000000000","tz":60},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2018-07-25 14:58:44.000000000","tz":60},"subject":"[placement] Use base test in placement functional tests","message":"[placement] Use base test in placement functional tests\n\nThere is now a placement.base.TestCase for placement functional tests\nwhich assembles the necessary configuration and fixtures. This change\nuses that base class in the db functional tests and extends the base\nclass as required to add all the necessary functionality.\n\nIn the process issues were exposed in the fixtures.gabbits use of\noslo_config (causing tests to fail based on fallout from changes\nelsewhere in the functional tests) so this change also fixes that\nand limits the gabbi tests to only caring about the placement database\nconnection, which is more correct and how it should have been all\nalong.\n\nChange-Id: Ice89e9a25f74caaa53b7df079bd529d172354524\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9358e903958ef9b71346235339cb4b7b08e3e19c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9358e903958ef9b71346235339cb4b7b08e3e19c"}]},"branch":"refs/heads/master"},"4318e2fa2a10950814d67acfaae8cda5d2bb6d59":{"kind":"REWORK","_number":2,"created":"2018-07-26 01:01:19.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/78/585778/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/78/585778/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/78/585778/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/78/585778/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/78/585778/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/78/585778/2"}}},"commit":{"parents":[{"commit":"d1b087d59ea39af0323d263b3078d3b2f3d47f2d","subject":"[placement] Extract base functional test case from test_direct","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d1b087d59ea39af0323d263b3078d3b2f3d47f2d"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2018-07-25 14:40:37.000000000","tz":60},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2018-07-26 00:55:28.000000000","tz":60},"subject":"[placement] Use base test in placement functional tests","message":"[placement] Use base test in placement functional tests\n\nThere is now a placement.base.TestCase for placement functional tests\nwhich assembles the necessary configuration and fixtures. This change\nuses that base class in the db functional tests and extends the base\nclass as required to add all the necessary functionality.\n\nIn the process issues were exposed in the fixtures.gabbits use of\noslo_config (causing tests to fail based on fallout from changes\nelsewhere in the functional tests) so this change also fixes that\nand limits the gabbi tests to only caring about the placement database\nconnection, which is more correct and how it should have been all\nalong.\n\nThis change removes the ConfPatcher fixture in fixtures.placement\nbecause it is no better than using the oslo_config provided\nfixture and was in the way while diagnosing difficulties with\ngetting these changes to work correctly.\n\nThe root cause of those problems was that placement changes were\nat cross purposes with how the nova.tests.fixtures.Database fixture\nexpects to work: The goal of these changes was to only configure\nand establish those fixtures that were strictly necessary for\nplacement in the placements tests. However, when _any_ database\nis requested from the Database fixture, the context managers for\nall of them are configured.\n\nThis means, for example, that if a placement fixture, which\noriginally was not configuring a \u0027connection\u0027 string for the api\nor main databases ran before a later api db fixture, the api db\nfixture would fail with no connection string available.\n\nThe quick and dirty fix is used here to fix the problem: we set\nreasonable configuration for all three database in the placement\ntests that need the placement database fixture.\n\nIn the future when placement is extracted, these problems go away\nso it does not seem worth the effort (at least not now) to\nrestructure the nova Database fixture.\n\nblueprint: placement-extract\nChange-Id: Ice89e9a25f74caaa53b7df079bd529d172354524\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4318e2fa2a10950814d67acfaae8cda5d2bb6d59"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4318e2fa2a10950814d67acfaae8cda5d2bb6d59"}]},"branch":"refs/heads/master"},"f5783d90bcb0b52469d0e0ada3933271afb84e2a":{"kind":"REWORK","_number":3,"created":"2018-07-26 16:54:09.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/78/585778/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/78/585778/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/78/585778/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/78/585778/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/78/585778/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/78/585778/3"}}},"commit":{"parents":[{"commit":"d1b087d59ea39af0323d263b3078d3b2f3d47f2d","subject":"[placement] Extract base functional test case from test_direct","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d1b087d59ea39af0323d263b3078d3b2f3d47f2d"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2018-07-25 14:40:37.000000000","tz":60},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2018-07-26 16:52:59.000000000","tz":60},"subject":"[placement] Use base test in placement functional tests","message":"[placement] Use base test in placement functional tests\n\nThere is now a placement.base.TestCase for placement functional tests\nwhich assembles the necessary configuration and fixtures. This change\nuses that base class in the db functional tests and extends the base\nclass as required to add all the necessary functionality.\n\nIn the process issues were exposed in the fixtures.gabbits use of\noslo_config (causing tests to fail based on fallout from changes\nelsewhere in the functional tests) so this change also fixes that\nand limits the gabbi tests to only caring about the placement database\nconnection, which is more correct and how it should have been all\nalong.\n\nThis change removes the ConfPatcher fixture in fixtures.placement\nbecause it is no better than using the oslo_config provided\nfixture and was in the way while diagnosing difficulties with\ngetting these changes to work correctly.\n\nThe root cause of those problems was that placement changes were\nat cross purposes with how the nova.tests.fixtures.Database fixture\nexpects to work: The goal of these changes was to only configure\nand establish those fixtures that were strictly necessary for\nplacement in the placements tests. However, when _any_ database\nis requested from the Database fixture, the context managers for\nall of them are configured.\n\nThis means, for example, that if a placement fixture, which\noriginally was not configuring a \u0027connection\u0027 string for the api\nor main databases, ran before a later api db fixture, the api db\nfixture would fail with no connection string available.\n\nThe quick and dirty fix is used here to fix the problem: we set\nreasonable configuration for all three databases in the placement\ntests that need the placement database fixture.\n\nIn the future when placement is extracted, these problems go away\nso it does not seem worth the effort (at least not now) to\nrestructure the nova Database fixture.\n\nblueprint: placement-extract\nChange-Id: Ice89e9a25f74caaa53b7df079bd529d172354524\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f5783d90bcb0b52469d0e0ada3933271afb84e2a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f5783d90bcb0b52469d0e0ada3933271afb84e2a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}