)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"09ee7ec0b68d2c9d3baa4fd35212f3b8829fd57e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"compute node local_gb_used include swap disks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The ComputeNode.local_gb_used value is set in the ResourceTracker._update_usage() method:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://github.com/openstack/nova/blob/eb4f65a7951e921b1cd8d05713e144e72f2f254f/nova/compute/resource_tracker.py#L934"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Based on:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"1. root_gb in the flavor"},{"line_number":16,"context_line":"2. any disk overhead from the virt driver"},{"line_number":17,"context_line":"3. ephemeral_gb in the flavor"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-bug: #1782386"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_1b0a7fd0","line":17,"range":{"start_line":9,"start_character":0,"end_line":17,"end_character":29},"updated":"2018-07-26 08:25:42.000000000","message":"You should refactor this, I suggest:\n\nThe ComputeNode.local_gb_used value is set in the ResourceTracker._update_usage() method, based on\n\n1. root_gb in the flavor\n2. any disk overhead from the virt driver\n3. ephemeral_gb in the flavor\n\nThe consideration of swap disk in the flavor was ignored.\n\nThis patch adds swap disk to the consideration.","commit_id":"07a7360cb9875e270a164e87fc835ae6d84321f0"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"a9b8b79a5dd9cf38873b0c941dc42bd63cd54098","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     XiaohanZhang \u003c15809181826@qq.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-07-26 19:09:11 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"compute node local_gb_used include swap disks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The ComputeNode.local_gb_used value is set in the ResourceTracker._update_usage() method:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://github.com/openstack/nova/blob/eb4f65a7951e921b1cd8d05713e144e72f2f254f/nova/compute/resource_tracker.py#L934"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Based on:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"1. root_gb in the flavor"},{"line_number":16,"context_line":"2. any disk overhead from the virt driver"},{"line_number":17,"context_line":"3. ephemeral_gb in the flavor"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-bug: #1782386"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_07820b52","line":17,"range":{"start_line":7,"start_character":0,"end_line":17,"end_character":29},"updated":"2018-07-27 01:22:46.000000000","message":"You should refactor this, I suggest:\n\nThe ComputeNode.local_gb_used value is set in the ResourceTracker._update_usage() method, based on\n\n1. root_gb in the flavor\n2. any disk overhead from the virt driver\n3. ephemeral_gb in the flavor\n\nThe consideration of swap disk in the flavor was ignored.\n\nThis patch adds swap disk to the consideration.","commit_id":"1f5ffad52815b4cde8ca46069109275c0ed153b6"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"8756c782f4d7c7d4b8fdf40133ee7637181d2735","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"compute node local_gb_used include swap disks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The ComputeNode.local_gb_used value is set in the ResourceTracker._update_usage() method, based on"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"1. root_gb in the flavor"},{"line_number":12,"context_line":"2. any disk overhead from the virt driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f7c97a3_cb9659a1","line":9,"updated":"2018-07-27 07:43:01.000000000","message":"nit: Subsequent lines should be wrapped at 72 characters.\n\nYou can learn something details about commit message from ref[1].\n\n[1] https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"e3df049cad2b7a264acbad4d6baecbc813546e5d"}],"nova/compute/resource_tracker.py":[{"author":{"_account_id":26286,"name":"huanhongda","email":"hongda.xun@easystack.cn","username":"huanhongda"},"change_message_id":"9d26ac9d968a8fb7a32e856598b7a146623159be","unresolved":false,"context_lines":[{"line_number":1156,"context_line":"        cn \u003d self.compute_nodes[nodename]"},{"line_number":1157,"context_line":"        # set some initial values, reserve room for host/hypervisor:"},{"line_number":1158,"context_line":"        cn.local_gb_used \u003d CONF.reserved_host_disk_mb / 1024"},{"line_number":1159,"context_line":"        cn.memory_mb_used \u003d CONF.reserved_host_"},{"line_number":1160,"context_line":"        cn.vcpus_used \u003d CONF.reserved_host_cpus"},{"line_number":1161,"context_line":"        cn.free_ram_mb \u003d (cn.memory_mb - cn.memory_mb_used)"},{"line_number":1162,"context_line":"        cn.free_disk_gb \u003d (cn.local_gb - cn.local_gb_used)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_21b6328b","line":1159,"range":{"start_line":1159,"start_character":33,"end_line":1159,"end_character":47},"updated":"2018-07-26 02:36:41.000000000","message":"There isn\u0027t a \u0027reserved_host_\u0027 in conf.","commit_id":"7bb9cc85464cd92a9092eae1ae060db7e2cf36f5"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"09ee7ec0b68d2c9d3baa4fd35212f3b8829fd57e","unresolved":false,"context_lines":[{"line_number":936,"context_line":"        cn.memory_mb_used +\u003d sign * mem_usage"},{"line_number":937,"context_line":"        cn.local_gb_used +\u003d sign * disk_usage"},{"line_number":938,"context_line":"        cn.local_gb_used +\u003d sign * usage.get(\u0027ephemeral_gb\u0027, 0)"},{"line_number":939,"context_line":"        cn.local_gb_used +\u003d sign * usage.get(\u0027swap\u0027, 0)"},{"line_number":940,"context_line":"        cn.vcpus_used +\u003d sign * vcpus_usage"},{"line_number":941,"context_line":""},{"line_number":942,"context_line":"        # free ram and disk may be negative, depending on policy:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_fba78350","line":939,"range":{"start_line":939,"start_character":7,"end_line":939,"end_character":55},"updated":"2018-07-26 08:25:42.000000000","message":"according to https://github.com/openstack/nova/blob/eb4f65a7951e921b1cd8d05713e144e72f2f254f/api-ref/source/parameters.yaml#L2902\n\nthe swap disk is in MiB, so I guess you have to divide the value by 1024 here.","commit_id":"07a7360cb9875e270a164e87fc835ae6d84321f0"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"d3b466ad4a7de0252a046c0b43efc225e9034716","unresolved":false,"context_lines":[{"line_number":936,"context_line":"        cn.memory_mb_used +\u003d sign * mem_usage"},{"line_number":937,"context_line":"        cn.local_gb_used +\u003d sign * disk_usage"},{"line_number":938,"context_line":"        cn.local_gb_used +\u003d sign * usage.get(\u0027ephemeral_gb\u0027, 0)"},{"line_number":939,"context_line":"        cn.local_gb_used +\u003d sign * usage.get(\u0027swap\u0027, 0)"},{"line_number":940,"context_line":"        cn.vcpus_used +\u003d sign * vcpus_usage"},{"line_number":941,"context_line":""},{"line_number":942,"context_line":"        # free ram and disk may be negative, depending on policy:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_4018ff81","line":939,"range":{"start_line":939,"start_character":7,"end_line":939,"end_character":55},"in_reply_to":"5f7c97a3_fba78350","updated":"2018-07-26 11:23:25.000000000","message":"yes, this might lead to floating number here","commit_id":"07a7360cb9875e270a164e87fc835ae6d84321f0"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"d3b466ad4a7de0252a046c0b43efc225e9034716","unresolved":false,"context_lines":[{"line_number":1458,"context_line":"            is_bfv \u003d compute_utils.is_volume_backed_instance("},{"line_number":1459,"context_line":"                object_or_dict._context, object_or_dict)"},{"line_number":1460,"context_line":"            usage \u003d {\u0027memory_mb\u0027: object_or_dict.flavor.memory_mb,"},{"line_number":1461,"context_line":"                     \u0027swap\u0027: object_or_dict.flavor.swap,"},{"line_number":1462,"context_line":"                     \u0027vcpus\u0027: object_or_dict.flavor.vcpus,"},{"line_number":1463,"context_line":"                     \u0027root_gb\u0027: (0 if is_bfv else"},{"line_number":1464,"context_line":"                                 object_or_dict.flavor.root_gb),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_a008f32d","line":1461,"range":{"start_line":1461,"start_character":29,"end_line":1461,"end_character":56},"updated":"2018-07-26 11:23:25.000000000","message":"again, I don\u0027t know whether it\u0027s really a good way because we can allow swap disk smaller than flavor defined , same to eph disk","commit_id":"07a7360cb9875e270a164e87fc835ae6d84321f0"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"64ce89f167585717a3d55f2be1aaf7ac729e3d32","unresolved":false,"context_lines":[{"line_number":1458,"context_line":"            is_bfv \u003d compute_utils.is_volume_backed_instance("},{"line_number":1459,"context_line":"                object_or_dict._context, object_or_dict)"},{"line_number":1460,"context_line":"            usage \u003d {\u0027memory_mb\u0027: object_or_dict.flavor.memory_mb,"},{"line_number":1461,"context_line":"                     \u0027swap\u0027: object_or_dict.flavor.swap,"},{"line_number":1462,"context_line":"                     \u0027vcpus\u0027: object_or_dict.flavor.vcpus,"},{"line_number":1463,"context_line":"                     \u0027root_gb\u0027: (0 if is_bfv else"},{"line_number":1464,"context_line":"                                 object_or_dict.flavor.root_gb),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_2dd2455c","line":1461,"range":{"start_line":1461,"start_character":29,"end_line":1461,"end_character":56},"in_reply_to":"5f7c97a3_19b042dc","updated":"2018-07-31 08:45:33.000000000","message":"no, usage should indicate real consumption, right? \n\neven you give flavor 2G swap, maybe you don\u0027t use it all...\ne.g 512 M is possible\nso though this is a good change to include swap, I think we need give real usage instead of \u0027planned\u0027 or allowed one","commit_id":"07a7360cb9875e270a164e87fc835ae6d84321f0"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"e31df5c5c7b3c9eca1160dc309c76f84e021093c","unresolved":false,"context_lines":[{"line_number":1458,"context_line":"            is_bfv \u003d compute_utils.is_volume_backed_instance("},{"line_number":1459,"context_line":"                object_or_dict._context, object_or_dict)"},{"line_number":1460,"context_line":"            usage \u003d {\u0027memory_mb\u0027: object_or_dict.flavor.memory_mb,"},{"line_number":1461,"context_line":"                     \u0027swap\u0027: object_or_dict.flavor.swap,"},{"line_number":1462,"context_line":"                     \u0027vcpus\u0027: object_or_dict.flavor.vcpus,"},{"line_number":1463,"context_line":"                     \u0027root_gb\u0027: (0 if is_bfv else"},{"line_number":1464,"context_line":"                                 object_or_dict.flavor.root_gb),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_19b042dc","line":1461,"range":{"start_line":1461,"start_character":29,"end_line":1461,"end_character":56},"in_reply_to":"5f7c97a3_a008f32d","updated":"2018-07-26 13:00:50.000000000","message":"What do you mean? but the usage should be calculated by the flavor statics right?","commit_id":"07a7360cb9875e270a164e87fc835ae6d84321f0"}],"nova/tests/functional/test_servers.py":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"d0c9e693a13b8b183bf9349c2eed21dc2abf1238","unresolved":false,"context_lines":[{"line_number":3649,"context_line":"        self.assertEqual(expected_usage, resources[\u0027DISK_GB\u0027])"},{"line_number":3650,"context_line":"        # Ensure the compute node is reporting the correct disk usage"},{"line_number":3651,"context_line":"        self.assertEqual("},{"line_number":3652,"context_line":"            35,"},{"line_number":3653,"context_line":"            self.admin_api.get_hypervisor_stats()[\u0027local_gb_used\u0027])"},{"line_number":3654,"context_line":""},{"line_number":3655,"context_line":"    def test_volume_backed_no_disk_allocation(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_62c08d7e","line":3652,"range":{"start_line":3652,"start_character":12,"end_line":3652,"end_character":14},"updated":"2018-07-27 02:52:25.000000000","message":"The \"expected_usage\" can be used in here directly.","commit_id":"1f5ffad52815b4cde8ca46069109275c0ed153b6"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"d0c9e693a13b8b183bf9349c2eed21dc2abf1238","unresolved":false,"context_lines":[{"line_number":3662,"context_line":"        self.assertEqual(expected_usage, resources[\u0027DISK_GB\u0027])"},{"line_number":3663,"context_line":"        # Ensure the compute node is reporting the correct disk usage"},{"line_number":3664,"context_line":"        self.assertEqual("},{"line_number":3665,"context_line":"            25,"},{"line_number":3666,"context_line":"            self.admin_api.get_hypervisor_stats()[\u0027local_gb_used\u0027])"},{"line_number":3667,"context_line":""},{"line_number":3668,"context_line":"        # Now let\u0027s hack the RequestSpec.is_bfv field to mimic migrating an"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_22ba950a","line":3665,"range":{"start_line":3665,"start_character":12,"end_line":3665,"end_character":14},"updated":"2018-07-27 02:52:25.000000000","message":"ditto","commit_id":"1f5ffad52815b4cde8ca46069109275c0ed153b6"}]}