)]}'
{"nova/tests/functional/test_server_group.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b52aa127f8364491ea5bb1c4db6d1d4586a8d013","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                        + [\u0027ServerGroupAntiAffinityFilter\u0027,"},{"line_number":50,"context_line":"                           \u0027ServerGroupAffinityFilter\u0027])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    # Add a backoff time to avoid potential conflict"},{"line_number":53,"context_line":"    _backoff_time \u003d 1"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    # Override servicegroup parameters to make the tests run faster"},{"line_number":56,"context_line":"    _service_down_time \u003d 10"},{"line_number":57,"context_line":"    _report_interval \u003d 1"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    _sleep_time \u003d _service_down_time + _backoff_time"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    anti_affinity \u003d {\u0027name\u0027: \u0027fake-name-1\u0027, \u0027policies\u0027: [\u0027anti-affinity\u0027]}"},{"line_number":62,"context_line":"    affinity \u003d {\u0027name\u0027: \u0027fake-name-2\u0027, \u0027policies\u0027: [\u0027affinity\u0027]}"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_f2a23cfb","line":59,"range":{"start_line":52,"start_character":4,"end_line":59,"end_character":52},"updated":"2018-07-26 14:50:20.000000000","message":"I think we should probably just re-write these evacuate-based tests to avoid sleeps and force the service down which would be more predictable:\n\nhttps://developer.openstack.org/api-ref/compute/#update-forced-down\n\nWe have other evacuate tests that do that same thing to force the service down before evacuating servers off the compute.","commit_id":"7fcc0868bf4f3ce60d4bc82adb507e4b409451dd"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8c062606ba7ab4a77046376f5f977f9f0c03e598","unresolved":false,"context_lines":[{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        host \u003d self._get_compute_service_by_host_name("},{"line_number":424,"context_line":"            servers[1][\u0027OS-EXT-SRV-ATTR:host\u0027])"},{"line_number":425,"context_line":"        host.stop()"},{"line_number":426,"context_line":"        # Need to wait sleep amount of seconds to ensure"},{"line_number":427,"context_line":"        # nova considers the host down"},{"line_number":428,"context_line":"        time.sleep(self._sleep_time)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_9c6de031","line":425,"range":{"start_line":425,"start_character":8,"end_line":425,"end_character":19},"updated":"2018-07-30 15:39:43.000000000","message":"I just noticed this today:\n\nhttps://github.com/openstack/nova/blob/3c6f0eb49e0a86af5e451c3a715718192c4562bd/nova/test.py#L442\n\nIf we can\u0027t force the service down because the test isn\u0027t using a new enough microversion, we should probably use that helper method to restart the compute service.","commit_id":"7fcc0868bf4f3ce60d4bc82adb507e4b409451dd"}]}