)]}'
{"nova/virt/libvirt/config.py":[{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"a5c555a7e152e50d058d2c90d4a89b6ee8fbdde9","unresolved":false,"context_lines":[{"line_number":915,"context_line":"                                                         **kwargs)"},{"line_number":916,"context_line":""},{"line_number":917,"context_line":"        self.type \u003d \u0027cirrus\u0027"},{"line_number":918,"context_line":"        self.vram \u003d \u00279216\u0027"},{"line_number":919,"context_line":"        self.heads \u003d \u00271\u0027"},{"line_number":920,"context_line":""},{"line_number":921,"context_line":"    def format_dom(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BXF4%3D","line":918,"updated":"2013-11-26 22:47:59.000000000","message":"What\u0027s the significance of the default 9216 value for vram here?  It would be nice if the choice of this value was explained in a comment or in the blueprint.","commit_id":"61ab7346bc8668cd9be2cc4c1f7468d8a6a0d3a9"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"3d8333a10ea83985cab859d96f25e62cf6ffef5a","unresolved":false,"context_lines":[{"line_number":915,"context_line":"                                                         **kwargs)"},{"line_number":916,"context_line":""},{"line_number":917,"context_line":"        self.type \u003d \u0027cirrus\u0027"},{"line_number":918,"context_line":"        self.vram \u003d \u00279216\u0027"},{"line_number":919,"context_line":"        self.heads \u003d \u00271\u0027"},{"line_number":920,"context_line":""},{"line_number":921,"context_line":"    def format_dom(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BVLA%3D","line":918,"in_reply_to":"AAAATn%2F%2BXF4%3D","updated":"2013-11-27 10:13:37.000000000","message":"Well, this is a libvirt default value: http://libvirt.org/formatdomain.html#elementsVideo\nI\u0027m not changing a behaviour.","commit_id":"61ab7346bc8668cd9be2cc4c1f7468d8a6a0d3a9"},{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"ebf328034b1c4570759517a379e48df0ec2dc555","unresolved":false,"context_lines":[{"line_number":924,"context_line":"        model \u003d etree.Element(\"model\")"},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"        if self.type not in self.VALID_VIDEO_DRIVERS:"},{"line_number":927,"context_line":"            LOG.warn(\u0027%s is not a supported video driver,\u0027"},{"line_number":928,"context_line":"                     \u0027will set default cirrus driver.\u0027 % self.type)"},{"line_number":929,"context_line":"            self.type \u003d \u0027cirrus\u0027"},{"line_number":930,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BWX8%3D","line":927,"updated":"2013-11-27 02:43:01.000000000","message":"the message should be surround by _ method for i18n.","commit_id":"61ab7346bc8668cd9be2cc4c1f7468d8a6a0d3a9"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"3d8333a10ea83985cab859d96f25e62cf6ffef5a","unresolved":false,"context_lines":[{"line_number":924,"context_line":"        model \u003d etree.Element(\"model\")"},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"        if self.type not in self.VALID_VIDEO_DRIVERS:"},{"line_number":927,"context_line":"            LOG.warn(\u0027%s is not a supported video driver,\u0027"},{"line_number":928,"context_line":"                     \u0027will set default cirrus driver.\u0027 % self.type)"},{"line_number":929,"context_line":"            self.type \u003d \u0027cirrus\u0027"},{"line_number":930,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BVK4%3D","line":927,"in_reply_to":"AAAATn%2F%2BWX8%3D","updated":"2013-11-27 10:13:37.000000000","message":"Done","commit_id":"61ab7346bc8668cd9be2cc4c1f7468d8a6a0d3a9"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"aad200da7e1dc3b42d8b2ba0e965a4a791f7222a","unresolved":false,"context_lines":[{"line_number":926,"context_line":"        if self.type not in self.VALID_VIDEO_DRIVERS:"},{"line_number":927,"context_line":"            LOG.warn(_(\u0027%s is not a supported video driver,\u0027"},{"line_number":928,"context_line":"                     \u0027will set default cirrus driver.\u0027), self.type)"},{"line_number":929,"context_line":"            self.type \u003d \u0027cirrus\u0027"},{"line_number":930,"context_line":""},{"line_number":931,"context_line":"        model.set(\"type\", self.type)"},{"line_number":932,"context_line":"        model.set(\"vram\", str(self.vram))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BU9k%3D","line":929,"updated":"2013-11-27 10:52:40.000000000","message":"These classes are intended to be solely focused on data transformation, not data validation. Logging warnings \u0026 silently changing data is a really bad way to deal with user mistakes too - they should be reported as fatal errors from the driver code instead.","commit_id":"e2bba87f9bfd88aaf8b02ce59036768177f881d6"},{"author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"change_message_id":"4b6064e68c72e941c9a03382853ffffb1877cd83","unresolved":false,"context_lines":[{"line_number":910,"context_line":""},{"line_number":911,"context_line":"    def __init__(self, **kwargs):"},{"line_number":912,"context_line":"        super(LibvirtConfigGuestVideo, self).__init__(root_name\u003d\"video\","},{"line_number":913,"context_line":"                                                         **kwargs)"},{"line_number":914,"context_line":""},{"line_number":915,"context_line":"        self.type \u003d \u0027cirrus\u0027"},{"line_number":916,"context_line":"        self.vram \u003d \u00279216\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BTCY%3D","line":913,"updated":"2013-11-27 18:05:56.000000000","message":"alignment.","commit_id":"20a38b5aca532279be97048bdcfb8dc6e758f8bc"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"58ead04a56b911191234a552289954602217394c","unresolved":false,"context_lines":[{"line_number":914,"context_line":""},{"line_number":915,"context_line":"        self.type \u003d \u0027cirrus\u0027"},{"line_number":916,"context_line":"        self.vram \u003d \u00279216\u0027"},{"line_number":917,"context_line":"        self.heads \u003d \u00271\u0027"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"    def format_dom(self):"},{"line_number":920,"context_line":"        dev \u003d super(LibvirtConfigGuestVideo, self).format_dom()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BMSg%3D","line":917,"updated":"2013-11-29 12:29:01.000000000","message":"It would be preferrable if you left these both as None, so libvirt uses its own defaults here.","commit_id":"20a38b5aca532279be97048bdcfb8dc6e758f8bc"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"20c42c52bcdd7a25115bff8922a0a41780b03434","unresolved":false,"context_lines":[{"line_number":914,"context_line":""},{"line_number":915,"context_line":"        self.type \u003d \u0027cirrus\u0027"},{"line_number":916,"context_line":"        self.vram \u003d \u00279216\u0027"},{"line_number":917,"context_line":"        self.heads \u003d \u00271\u0027"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"    def format_dom(self):"},{"line_number":920,"context_line":"        dev \u003d super(LibvirtConfigGuestVideo, self).format_dom()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BLyc%3D","line":917,"in_reply_to":"AAAATn%2F%2BMSg%3D","updated":"2013-11-29 15:25:08.000000000","message":"Done","commit_id":"20a38b5aca532279be97048bdcfb8dc6e758f8bc"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"58ead04a56b911191234a552289954602217394c","unresolved":false,"context_lines":[{"line_number":922,"context_line":"        model \u003d etree.Element(\"model\")"},{"line_number":923,"context_line":"        model.set(\"type\", self.type)"},{"line_number":924,"context_line":"        model.set(\"vram\", str(self.vram))"},{"line_number":925,"context_line":"        model.set(\"heads\", str(self.heads))"},{"line_number":926,"context_line":"        dev.append(model)"},{"line_number":927,"context_line":""},{"line_number":928,"context_line":"        return dev"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BMSc%3D","line":925,"updated":"2013-11-29 12:29:01.000000000","message":"And only set vram/heads if not None","commit_id":"20a38b5aca532279be97048bdcfb8dc6e758f8bc"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"20c42c52bcdd7a25115bff8922a0a41780b03434","unresolved":false,"context_lines":[{"line_number":922,"context_line":"        model \u003d etree.Element(\"model\")"},{"line_number":923,"context_line":"        model.set(\"type\", self.type)"},{"line_number":924,"context_line":"        model.set(\"vram\", str(self.vram))"},{"line_number":925,"context_line":"        model.set(\"heads\", str(self.heads))"},{"line_number":926,"context_line":"        dev.append(model)"},{"line_number":927,"context_line":""},{"line_number":928,"context_line":"        return dev"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BLyY%3D","line":925,"in_reply_to":"AAAATn%2F%2BMSc%3D","updated":"2013-11-29 15:25:08.000000000","message":"Done","commit_id":"20a38b5aca532279be97048bdcfb8dc6e758f8bc"}]}