)]}'
{"nova/network/security_group/neutron_driver.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"53e4aa09bcfd0fabc21556b25b016adfb8de79c4","unresolved":false,"context_lines":[{"line_number":479,"context_line":"                         {\u0027security_group_id\u0027: security_group_id,"},{"line_number":480,"context_line":"                          \u0027port_id\u0027: port[\u0027id\u0027]})"},{"line_number":481,"context_line":"                neutron.update_port(port[\u0027id\u0027], {\u0027port\u0027: updated_port})"},{"line_number":482,"context_line":"                # updating instance field \u0027updated_at\u0027 after adding security"},{"line_number":483,"context_line":"                # group"},{"line_number":484,"context_line":"                update_dict \u003d {\u0027updated_at\u0027: timeutils.utcnow()}"},{"line_number":485,"context_line":"                instance.updated_at \u003d update_dict[\u0027updated_at\u0027]"},{"line_number":486,"context_line":"            except n_exc.NeutronClientException as e:"},{"line_number":487,"context_line":"                exc_info \u003d sys.exc_info()"},{"line_number":488,"context_line":"                if e.status_code \u003d\u003d 400:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_cfe725d7","line":485,"range":{"start_line":482,"start_character":16,"end_line":485,"end_character":63},"updated":"2018-07-30 04:16:10.000000000","message":"seems need instance.save() ?\n\n\nAlso, api/openstack/compute/security_groups.py\nmight be a better place to update instance.update_at?","commit_id":"b9c26546801148932bc3b6355647ee80b0cadaa6"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"956dde2d3387a3f46f8e8243e4482af23a92e6cf","unresolved":false,"context_lines":[{"line_number":479,"context_line":"                         {\u0027security_group_id\u0027: security_group_id,"},{"line_number":480,"context_line":"                          \u0027port_id\u0027: port[\u0027id\u0027]})"},{"line_number":481,"context_line":"                neutron.update_port(port[\u0027id\u0027], {\u0027port\u0027: updated_port})"},{"line_number":482,"context_line":"                # updating instance field \u0027updated_at\u0027 after adding security"},{"line_number":483,"context_line":"                # group"},{"line_number":484,"context_line":"                update_dict \u003d {\u0027updated_at\u0027: timeutils.utcnow()}"},{"line_number":485,"context_line":"                instance.updated_at \u003d update_dict[\u0027updated_at\u0027]"},{"line_number":486,"context_line":"            except n_exc.NeutronClientException as e:"},{"line_number":487,"context_line":"                exc_info \u003d sys.exc_info()"},{"line_number":488,"context_line":"                if e.status_code \u003d\u003d 400:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_ac26056a","line":485,"range":{"start_line":482,"start_character":16,"end_line":485,"end_character":63},"in_reply_to":"5f7c97a3_25efb11c","updated":"2018-08-03 03:07:13.000000000","message":"Done","commit_id":"b9c26546801148932bc3b6355647ee80b0cadaa6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"77119be110857d8cf5a48a0a500f8e76ee599d7d","unresolved":false,"context_lines":[{"line_number":479,"context_line":"                         {\u0027security_group_id\u0027: security_group_id,"},{"line_number":480,"context_line":"                          \u0027port_id\u0027: port[\u0027id\u0027]})"},{"line_number":481,"context_line":"                neutron.update_port(port[\u0027id\u0027], {\u0027port\u0027: updated_port})"},{"line_number":482,"context_line":"                # updating instance field \u0027updated_at\u0027 after adding security"},{"line_number":483,"context_line":"                # group"},{"line_number":484,"context_line":"                update_dict \u003d {\u0027updated_at\u0027: timeutils.utcnow()}"},{"line_number":485,"context_line":"                instance.updated_at \u003d update_dict[\u0027updated_at\u0027]"},{"line_number":486,"context_line":"            except n_exc.NeutronClientException as e:"},{"line_number":487,"context_line":"                exc_info \u003d sys.exc_info()"},{"line_number":488,"context_line":"                if e.status_code \u003d\u003d 400:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_25efb11c","line":485,"range":{"start_line":482,"start_character":16,"end_line":485,"end_character":63},"in_reply_to":"5f7c97a3_9df08768","updated":"2018-07-31 16:33:44.000000000","message":"why are you creating a dictionary  with one value just to immediately  lookup that value and through away the dictionary\n\nyou could just do instance.updated_at \u003d timeutils.utcnow()\ninstead.","commit_id":"b9c26546801148932bc3b6355647ee80b0cadaa6"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"752b96b2485ba1e7e62c3142383edc29d25476bd","unresolved":false,"context_lines":[{"line_number":479,"context_line":"                         {\u0027security_group_id\u0027: security_group_id,"},{"line_number":480,"context_line":"                          \u0027port_id\u0027: port[\u0027id\u0027]})"},{"line_number":481,"context_line":"                neutron.update_port(port[\u0027id\u0027], {\u0027port\u0027: updated_port})"},{"line_number":482,"context_line":"                # updating instance field \u0027updated_at\u0027 after adding security"},{"line_number":483,"context_line":"                # group"},{"line_number":484,"context_line":"                update_dict \u003d {\u0027updated_at\u0027: timeutils.utcnow()}"},{"line_number":485,"context_line":"                instance.updated_at \u003d update_dict[\u0027updated_at\u0027]"},{"line_number":486,"context_line":"            except n_exc.NeutronClientException as e:"},{"line_number":487,"context_line":"                exc_info \u003d sys.exc_info()"},{"line_number":488,"context_line":"                if e.status_code \u003d\u003d 400:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_fdcadb6c","line":485,"range":{"start_line":482,"start_character":16,"end_line":485,"end_character":63},"in_reply_to":"5f7c97a3_cfe725d7","updated":"2018-07-30 07:10:48.000000000","message":"For updating time it doesn\u0027t require instance.save()\n\nAnd I have to update the instance when a security group is added. The instance is available when func add_to_instance() is called, So this place is better to get the updation time when the security group is added to instance.","commit_id":"b9c26546801148932bc3b6355647ee80b0cadaa6"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"55a1d8b1eea3aed2aef0fec5043ba1529736dd53","unresolved":false,"context_lines":[{"line_number":479,"context_line":"                         {\u0027security_group_id\u0027: security_group_id,"},{"line_number":480,"context_line":"                          \u0027port_id\u0027: port[\u0027id\u0027]})"},{"line_number":481,"context_line":"                neutron.update_port(port[\u0027id\u0027], {\u0027port\u0027: updated_port})"},{"line_number":482,"context_line":"                # updating instance field \u0027updated_at\u0027 after adding security"},{"line_number":483,"context_line":"                # group"},{"line_number":484,"context_line":"                update_dict \u003d {\u0027updated_at\u0027: timeutils.utcnow()}"},{"line_number":485,"context_line":"                instance.updated_at \u003d update_dict[\u0027updated_at\u0027]"},{"line_number":486,"context_line":"            except n_exc.NeutronClientException as e:"},{"line_number":487,"context_line":"                exc_info \u003d sys.exc_info()"},{"line_number":488,"context_line":"                if e.status_code \u003d\u003d 400:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_9df08768","line":485,"range":{"start_line":482,"start_character":16,"end_line":485,"end_character":63},"in_reply_to":"5f7c97a3_fdcadb6c","updated":"2018-07-30 07:40:09.000000000","message":"why? I thought instance.save is going to store info into db\nwithout that ,you are only updating instance object?\n\nMy thought is you add this into API layer so only the call success totally then update updated_at? and nova-compute can also benefit though it\u0027s deprecated..","commit_id":"b9c26546801148932bc3b6355647ee80b0cadaa6"}]}