)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"69bba739e55271daa2e166d5c0141574d6473fd4","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Nova was incorrectly using the instance[\u0027availability_zone\u0027]"},{"line_number":12,"context_line":"attribute, to get the AZ of an instance use the"},{"line_number":13,"context_line":"get_instance_availability_zone method."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ied912c171100a450754d315027bf5c407ac067bb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9AW8%3D","line":13,"updated":"2013-12-17 19:38:07.000000000","message":"Can you explain why here. (-1 for this)\n\nThe answer is instance[\u0027availability_zone\u0027]  is the desired availability_zone as requested by the user, and get_instance_availability_zone is the actual AZ.\n\n\nAlso it looks like neutron and notifications have the same issue.  Do you want to expand this patch to fix those as well or add a dependent patch? If not that\u0027s fine we can file a bug for it.","commit_id":"93a7ff4ce7a55fcdbf863db341221afb1cfa216e"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"3323a51b38e01875e399bff85eda98195915765e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix instance AZ check when attaching volumes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1255347"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Nova was incorrectly using the instance[\u0027availability_zone\u0027]"},{"line_number":12,"context_line":"attribute."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAU3%2F%2Fe50%3D","line":9,"updated":"2014-02-26 11:15:42.000000000","message":"This should be at the end of the commit message, just before the Change-id line","commit_id":"84bf5b442f8fcaf84924878e43801126697c7641"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"b694ed2e2e3bad8212b982fa5317f24b542dc57b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix instance cross AZ check when attaching volumes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When checking the AZ of an instance when CONF.cinder_cross_az_attach"},{"line_number":10,"context_line":"is set to False nova was matching against instance[\u0027availability_zone\u0027]."},{"line_number":11,"context_line":"This is OK if the instance hasn\u0027t been scheduled yet as this attribute"},{"line_number":12,"context_line":"is the desired AZ. If the instances has been scheduled to a host we"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9ad9bd40_be8fb922","line":9,"updated":"2014-04-30 22:22:23.000000000","message":"This is phrased a little awkwardly. Can you make this a little more explicit.\n\nMy understanding of what you are saying is:\n\nFor CONF.cinder_cross_az_attach\u003dFalse, we currently only check the desired AZ during scheduling but don\u0027t actually check the final AZ of the node.\n\nCan you also clarify why the current check isn\u0027t adequate.","commit_id":"059189dd1797771a9c8c42be33b7729e9a12fef4"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"9a4ed1aec938fad294c3fabd15fd9400a224cb34","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix instance cross AZ check when attaching volumes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When checking the AZ of an instance when CONF.cinder_cross_az_attach"},{"line_number":10,"context_line":"is set to False nova was matching against instance[\u0027availability_zone\u0027]."},{"line_number":11,"context_line":"This is OK if the instance hasn\u0027t been scheduled yet as this attribute"},{"line_number":12,"context_line":"is the desired AZ. If the instances has been scheduled to a host we"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9ad9bd40_6179162f","line":9,"in_reply_to":"9ad9bd40_be8fb922","updated":"2014-04-30 23:30:59.000000000","message":"Yeah I agree, the commit message has been the hardest bit about this patch! I\u0027ll give it a reword","commit_id":"059189dd1797771a9c8c42be33b7729e9a12fef4"}],"nova/tests/volume/test_cinder.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"96473c93d62a736d0d5d5fe2e2538fe436281ddf","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        volume[\u0027attach_status\u0027] \u003d \"detached\""},{"line_number":111,"context_line":"        instance \u003d {\u0027availability_zone\u0027: \u0027zone1\u0027, \u0027host\u0027: \u0027fakehost\u0027}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        self.mox.StubOutWithMock(cinder, \u0027availability_zones\u0027)"},{"line_number":114,"context_line":"        cinder.availability_zones.get_instance_availability_zone("},{"line_number":115,"context_line":"            self.ctx, instance).MultipleTimes().AndReturn(\u0027zone1\u0027)"},{"line_number":116,"context_line":"        self.mox.ReplayAll()"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2FON8%3D","line":113,"updated":"2014-04-23 08:30:47.000000000","message":"Can you please use mock here","commit_id":"b6d119ae40c05d4395c5b234ec5153a7d73a6d4a"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"96473c93d62a736d0d5d5fe2e2538fe436281ddf","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        volume[\u0027attach_status\u0027] \u003d \"detached\""},{"line_number":134,"context_line":"        volume[\u0027availability_zone\u0027] \u003d \u0027zone1\u0027"},{"line_number":135,"context_line":"        instance \u003d {\u0027availability_zone\u0027: \u0027zone1\u0027, \u0027host\u0027: \u0027fakehost\u0027}"},{"line_number":136,"context_line":"        self.mox.StubOutWithMock(cinder, \u0027availability_zones\u0027)"},{"line_number":137,"context_line":"        cinder.availability_zones.get_instance_availability_zone(self.ctx,"},{"line_number":138,"context_line":"                                              instance).AndReturn(\u0027zone1\u0027)"},{"line_number":139,"context_line":"        self.mox.ReplayAll()"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2FON0%3D","line":136,"updated":"2014-04-23 08:30:47.000000000","message":"ditto","commit_id":"b6d119ae40c05d4395c5b234ec5153a7d73a6d4a"}],"nova/volume/cinder.py":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"69bba739e55271daa2e166d5c0141574d6473fd4","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from cinderclient.v1 import client as cinder_client"},{"line_number":29,"context_line":"from oslo.config import cfg"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from nova.availability_zones import get_instance_availability_zone"},{"line_number":32,"context_line":"from nova.db import base"},{"line_number":33,"context_line":"from nova import exception"},{"line_number":34,"context_line":"from nova.openstack.common.gettextutils import _"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9AZI%3D","line":31,"updated":"2013-12-17 19:38:07.000000000","message":"I would prefer from nova import availability_zones\n\nthen later availability_zones.get_... as this is how the rest of the code does it","commit_id":"93a7ff4ce7a55fcdbf863db341221afb1cfa216e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"96473c93d62a736d0d5d5fe2e2538fe436281ddf","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        if instance and not CONF.cinder_cross_az_attach:"},{"line_number":234,"context_line":"            # NOTE(sorrison): If instance is on a host we match against it\u0027s AZ"},{"line_number":235,"context_line":"            #                 else we check the intended AZ"},{"line_number":236,"context_line":"            if instance.get(\u0027host\u0027, None):"},{"line_number":237,"context_line":"                instance_az \u003d \\"},{"line_number":238,"context_line":"                        availability_zones.get_instance_availability_zone("},{"line_number":239,"context_line":"                            context, instance)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2FONc%3D","line":236,"updated":"2014-04-23 08:30:47.000000000","message":"by default get return None. You do not need it here","commit_id":"b6d119ae40c05d4395c5b234ec5153a7d73a6d4a"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"96473c93d62a736d0d5d5fe2e2538fe436281ddf","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            # NOTE(sorrison): If instance is on a host we match against it\u0027s AZ"},{"line_number":235,"context_line":"            #                 else we check the intended AZ"},{"line_number":236,"context_line":"            if instance.get(\u0027host\u0027, None):"},{"line_number":237,"context_line":"                instance_az \u003d \\"},{"line_number":238,"context_line":"                        availability_zones.get_instance_availability_zone("},{"line_number":239,"context_line":"                            context, instance)"},{"line_number":240,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2FOM8%3D","line":237,"updated":"2014-04-23 08:30:47.000000000","message":"any chance of writing this without the \\\n\nfor example:\n\nfrom nova import availability_zones as az\n instance_az \u003d az.get_instance_availability_zone(context,\n                                                                              instance)","commit_id":"b6d119ae40c05d4395c5b234ec5153a7d73a6d4a"}]}