)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b120dbfaa09d421880f5069918215948f4820dbf","unresolved":false,"context_lines":[{"line_number":6552,"context_line":"        # Releasing vlan."},{"line_number":6553,"context_line":"        # (not necessary in current implementation?)"},{"line_number":6554,"context_line":""},{"line_number":6555,"context_line":"        network_info \u003d self.network_api.get_instance_nw_info(ctxt, instance)"},{"line_number":6556,"context_line":""},{"line_number":6557,"context_line":"        self._notify_about_instance_usage(ctxt, instance,"},{"line_number":6558,"context_line":"                                          \"live_migration._post.start\","}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_d195a732","line":6555,"updated":"2018-07-27 14:20:00.000000000","message":"Alternatively, we can just avoid this call if we pull the source vifs out of the migrate_data, and then use that for network_info throughout the rest of the method.","commit_id":"64b030ffaf578dee925a6ac2d47264346843ba2d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0ccace09b2e0958f44405d015c9ed53f19ca57c5","unresolved":false,"context_lines":[{"line_number":6552,"context_line":"        # Releasing vlan."},{"line_number":6553,"context_line":"        # (not necessary in current implementation?)"},{"line_number":6554,"context_line":""},{"line_number":6555,"context_line":"        network_info \u003d self.network_api.get_instance_nw_info(ctxt, instance)"},{"line_number":6556,"context_line":""},{"line_number":6557,"context_line":"        self._notify_about_instance_usage(ctxt, instance,"},{"line_number":6558,"context_line":"                                          \"live_migration._post.start\","}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_71513363","line":6555,"in_reply_to":"5f7c97a3_31ebbba5","updated":"2018-07-27 14:43:44.000000000","message":"I was thinking, the only reason it would make sense to send the source vifs in the notifications are if the notifications listener would want to know *which* vifs are being acted upon (unplugged etc) during this action.\n\nAnother note from the IRC discussion, legacy notifications in this method will use the source vifs (from the local network info) and the versioned notifications will use the \"current state\" vifs from instance.info_cache.","commit_id":"64b030ffaf578dee925a6ac2d47264346843ba2d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ef077c7f9041974b84c66407a87c3954587ae0a4","unresolved":false,"context_lines":[{"line_number":6552,"context_line":"        # Releasing vlan."},{"line_number":6553,"context_line":"        # (not necessary in current implementation?)"},{"line_number":6554,"context_line":""},{"line_number":6555,"context_line":"        network_info \u003d self.network_api.get_instance_nw_info(ctxt, instance)"},{"line_number":6556,"context_line":""},{"line_number":6557,"context_line":"        self._notify_about_instance_usage(ctxt, instance,"},{"line_number":6558,"context_line":"                                          \"live_migration._post.start\","}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_11631f43","line":6555,"in_reply_to":"5f7c97a3_31ebbba5","updated":"2018-07-27 14:29:37.000000000","message":"Note that the versioned notifications would use instance.info_cache regardless because we don\u0027t pass network_info through for building those payloads.","commit_id":"64b030ffaf578dee925a6ac2d47264346843ba2d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6d270dedcb1edb726d7a3c51a5a2726df121d655","unresolved":false,"context_lines":[{"line_number":6552,"context_line":"        # Releasing vlan."},{"line_number":6553,"context_line":"        # (not necessary in current implementation?)"},{"line_number":6554,"context_line":""},{"line_number":6555,"context_line":"        network_info \u003d self.network_api.get_instance_nw_info(ctxt, instance)"},{"line_number":6556,"context_line":""},{"line_number":6557,"context_line":"        self._notify_about_instance_usage(ctxt, instance,"},{"line_number":6558,"context_line":"                                          \"live_migration._post.start\","}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_31ebbba5","line":6555,"in_reply_to":"5f7c97a3_d195a732","updated":"2018-07-27 14:26:01.000000000","message":"I think the notification sending below needs to use the current state of the network_info instead of the old source_vif info.","commit_id":"64b030ffaf578dee925a6ac2d47264346843ba2d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b5c0812b8b5a6db21e7f013d3c9a7d2745f8b0cd","unresolved":false,"context_lines":[{"line_number":6552,"context_line":"        # Releasing vlan."},{"line_number":6553,"context_line":"        # (not necessary in current implementation?)"},{"line_number":6554,"context_line":""},{"line_number":6555,"context_line":"        network_info \u003d self.network_api.get_instance_nw_info(ctxt, instance)"},{"line_number":6556,"context_line":""},{"line_number":6557,"context_line":"        self._notify_about_instance_usage(ctxt, instance,"},{"line_number":6558,"context_line":"                                          \"live_migration._post.start\","}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_71f5b383","line":6555,"in_reply_to":"5f7c97a3_d195a732","updated":"2018-07-27 14:25:07.000000000","message":"Yeah, initially I was thinking the network info used throughout should be consistent, but I was also thinking, maybe for the notifications, we should be reflecting the state of the vif as queried from neutron here, and not artificially show the source vifs. So maybe this is indeed how it should be.","commit_id":"64b030ffaf578dee925a6ac2d47264346843ba2d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"70ddcfc3c60dd866113ba55dc9b5c9351df1a335","unresolved":false,"context_lines":[{"line_number":6624,"context_line":"        if do_cleanup:"},{"line_number":6625,"context_line":"            LOG.debug(\u0027Calling driver.cleanup from _post_live_migration\u0027,"},{"line_number":6626,"context_line":"                      instance\u003dinstance)"},{"line_number":6627,"context_line":"            self.driver.cleanup(ctxt, instance, unplug_nw_info,"},{"line_number":6628,"context_line":"                                destroy_disks\u003ddestroy_disks,"},{"line_number":6629,"context_line":"                                migrate_data\u003dmigrate_data,"},{"line_number":6630,"context_line":"                                destroy_vifs\u003ddestroy_vifs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_364de898","line":6627,"range":{"start_line":6627,"start_character":48,"end_line":6627,"end_character":62},"updated":"2018-07-27 21:41:24.000000000","message":"is this cleanup runing against the destination node or source? if this is the dest node this is incorrect if its the source node it is correct but i dont know what there is to clean up on the host for the vifs at this point?","commit_id":"64b030ffaf578dee925a6ac2d47264346843ba2d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e94f0fa73c30cd284a562a3a3613c703a13b7b39","unresolved":false,"context_lines":[{"line_number":6624,"context_line":"        if do_cleanup:"},{"line_number":6625,"context_line":"            LOG.debug(\u0027Calling driver.cleanup from _post_live_migration\u0027,"},{"line_number":6626,"context_line":"                      instance\u003dinstance)"},{"line_number":6627,"context_line":"            self.driver.cleanup(ctxt, instance, unplug_nw_info,"},{"line_number":6628,"context_line":"                                destroy_disks\u003ddestroy_disks,"},{"line_number":6629,"context_line":"                                migrate_data\u003dmigrate_data,"},{"line_number":6630,"context_line":"                                destroy_vifs\u003ddestroy_vifs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_39007900","line":6627,"range":{"start_line":6627,"start_character":48,"end_line":6627,"end_character":62},"in_reply_to":"5f7c97a3_364de898","updated":"2018-07-27 21:45:40.000000000","message":"This is running on the source host. Last night when I asked you about this you said there could be ovs hybrid plug things that need to be cleaned up on the source host even though we\u0027ve activated the (plugged) dest host port bindings.","commit_id":"64b030ffaf578dee925a6ac2d47264346843ba2d"}]}