)]}'
{"nova/tests/functional/test_servers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c16b2bb3c8f7badb3b31eda28fa3198de326f2de","unresolved":false,"context_lines":[{"line_number":3158,"context_line":"        self._delete_and_check_allocations(server)"},{"line_number":3159,"context_line":""},{"line_number":3160,"context_line":"    def test_migrate_with_sharing_provider(self):"},{"line_number":3161,"context_line":"        source_hostname \u003d self.compute1.host"},{"line_number":3162,"context_line":"        dest_hostname \u003d self.compute2.host"},{"line_number":3163,"context_line":"        source_rp_uuid \u003d self._get_provider_uuid_by_host(source_hostname)"},{"line_number":3164,"context_line":"        dest_rp_uuid \u003d self._get_provider_uuid_by_host(dest_hostname)"},{"line_number":3165,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_2489376f","line":3162,"range":{"start_line":3161,"start_character":8,"end_line":3162,"end_character":42},"updated":"2018-07-27 14:52:05.000000000","message":"These are going to be using the fake virt driver which *is* reporting DISK_GB, yeah? I guess you\u0027re deleting it below, but it will be re-populated when the periodic runs. I\u0027d just write a fake virt driver that doesn\u0027t report DISK_GB and use that...","commit_id":"76915c1d7652a3f07d5efefd2ebe15d888a099ec"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"348a5e5f8401ecbf8846bbf85f8d363bff9dc8c9","unresolved":false,"context_lines":[{"line_number":3182,"context_line":"                               {\u0027inventories\u0027: {"},{"line_number":3183,"context_line":"                                   \u0027DISK_GB\u0027: {"},{"line_number":3184,"context_line":"                                       \u0027allocation_ratio\u0027: 1.0,"},{"line_number":3185,"context_line":"                                       \u0027max_unit\u0027: 1,"},{"line_number":3186,"context_line":"                                       \u0027min_unit\u0027: 1,"},{"line_number":3187,"context_line":"                                       \u0027step_size\u0027: 1,"},{"line_number":3188,"context_line":"                                       \u0027total\u0027: 1024,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_e4001fb4","line":3185,"range":{"start_line":3185,"start_character":51,"end_line":3185,"end_character":52},"updated":"2018-07-27 14:55:06.000000000","message":"shouldn\u0027t this be 1024?","commit_id":"76915c1d7652a3f07d5efefd2ebe15d888a099ec"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"348a5e5f8401ecbf8846bbf85f8d363bff9dc8c9","unresolved":false,"context_lines":[{"line_number":3207,"context_line":"                               {\u0027inventories\u0027: {"},{"line_number":3208,"context_line":"                                   \u0027DISK_GB\u0027: {"},{"line_number":3209,"context_line":"                                       \u0027allocation_ratio\u0027: 1.0,"},{"line_number":3210,"context_line":"                                       \u0027max_unit\u0027: 1,"},{"line_number":3211,"context_line":"                                       \u0027min_unit\u0027: 1,"},{"line_number":3212,"context_line":"                                       \u0027step_size\u0027: 1,"},{"line_number":3213,"context_line":"                                       \u0027total\u0027: 1024,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_84f12be1","line":3210,"range":{"start_line":3210,"start_character":51,"end_line":3210,"end_character":52},"updated":"2018-07-27 14:55:06.000000000","message":"same, also, why do you need to do this again?","commit_id":"76915c1d7652a3f07d5efefd2ebe15d888a099ec"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"fc96e8a3db04fe720dcceff2d03b35addaef83d5","unresolved":false,"context_lines":[{"line_number":3199,"context_line":""},{"line_number":3200,"context_line":"        inv \u003d self.placement_api.get(\u0027/resource_providers/%s/inventories\u0027 % source_rp_uuid).body"},{"line_number":3201,"context_line":"        print(inv)"},{"line_number":3202,"context_line":"        del inv[\u0027inventories\u0027][\u0027DISK_GB\u0027]"},{"line_number":3203,"context_line":"        print(inv)"},{"line_number":3204,"context_line":"        self.placement_api.put(\u0027/resource_providers/%s/inventories\u0027 % source_rp_uuid,"},{"line_number":3205,"context_line":"                               inv)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_a66d2b31","line":3202,"updated":"2018-07-30 14:33:43.000000000","message":"we cannot do this until we\u0027ve moved the DISK_GB allocations that referred to the compute nodes and placed them on the sharing provider. this was not going to be done \"automatically\" in the resource tracker because we didn\u0027t want to put that kind of code in there. Instead, we said it would need to be a manual operation the operator performed.","commit_id":"79ac1228dbd4ad2ea1e022a3b809d0c101fce51d"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c16b2bb3c8f7badb3b31eda28fa3198de326f2de","unresolved":false,"context_lines":[{"line_number":6435,"context_line":"        # the compute node provider."},{"line_number":6436,"context_line":"        if not provider_tree.has_sharing_provider("},{"line_number":6437,"context_line":"                rc_fields.ResourceClass.DISK_GB):"},{"line_number":6438,"context_line":"            print(\u0027NOT SHARING\u0027)"},{"line_number":6439,"context_line":"            result[rc_fields.ResourceClass.DISK_GB] \u003d {"},{"line_number":6440,"context_line":"                \u0027total\u0027: disk_gb,"},{"line_number":6441,"context_line":"                \u0027min_unit\u0027: 1,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_64c16f81","line":6438,"updated":"2018-07-27 14:52:05.000000000","message":"This won\u0027t be hit in your functional test b/c you\u0027re not using the libvirt driver.","commit_id":"76915c1d7652a3f07d5efefd2ebe15d888a099ec"}]}