)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"4dc7af829d5257d5cf10b51e0709192be9a9203a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dan Smith \u003cdansmith@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-07-27 12:32:09 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Force oslo.privsep.daemon logging to INFO level"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This avoids us logging the output of potentially-sensitive operations"},{"line_number":10,"context_line":"performed with privilege."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_5a3987cc","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"updated":"2018-07-30 17:05:18.000000000","message":"Agreed from the non-inline comments, this isn\u0027t really true, we\u0027re just setting a default value.","commit_id":"6a7cef8773d0841ca9da70e7321f717ca09a607a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7156b1446caf3985a8ffcc6155d169ea2cc927e7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dan Smith \u003cdansmith@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-07-27 12:32:09 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Force oslo.privsep.daemon logging to INFO level"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This avoids us logging the output of potentially-sensitive operations"},{"line_number":10,"context_line":"performed with privilege."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_3ad84b7e","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"in_reply_to":"5f7c97a3_5a3987cc","updated":"2018-07-30 17:10:40.000000000","message":"Ah, yeah poor choice of words on my part, I see.","commit_id":"6a7cef8773d0841ca9da70e7321f717ca09a607a"}],"nova/config.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"37681e4a9ace89c8672b72b3ba70ee5b5a579c00","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    # NOTE(danms): DEBUG logging in privsep will result in some large"},{"line_number":44,"context_line":"    # and potentially sensitive things being logged."},{"line_number":45,"context_line":"    extra_default_log_levels.append(\u0027oslo.privsep.daemon\u003dINFO\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    log.set_defaults(default_log_levels\u003dlog.get_default_log_levels() +"},{"line_number":48,"context_line":"                     extra_default_log_levels)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_1ce56b3e","line":45,"updated":"2018-07-27 23:41:28.000000000","message":"Do we need to be concerned about the possibility of oslo.privsep.daemon already being in the default_log_levels by way of the operators config? What happens if it appears in the list twice, which value takes precedence?","commit_id":"6a7cef8773d0841ca9da70e7321f717ca09a607a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"525a922df69f22d7671336cb3edcc899f81614b1","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    # NOTE(danms): DEBUG logging in privsep will result in some large"},{"line_number":44,"context_line":"    # and potentially sensitive things being logged."},{"line_number":45,"context_line":"    extra_default_log_levels.append(\u0027oslo.privsep.daemon\u003dINFO\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    log.set_defaults(default_log_levels\u003dlog.get_default_log_levels() +"},{"line_number":48,"context_line":"                     extra_default_log_levels)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_4b854009","line":45,"in_reply_to":"5f7c97a3_1ce56b3e","updated":"2018-07-30 13:39:46.000000000","message":"Just like glanceclient above, we\u0027re setting these as defaults, then loading the config files. The later value (in their config) should take precedence.","commit_id":"6a7cef8773d0841ca9da70e7321f717ca09a607a"}]}