)]}'
{"nova/compute/api.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d5455078141d8df77e63e0a77601db38616e83b2","unresolved":false,"context_lines":[{"line_number":2369,"context_line":"                        expected_attrs\u003dexpected_attrs)"},{"line_number":2370,"context_line":"                else:"},{"line_number":2371,"context_line":"                    raise exception.InstanceNotFound(instance_id\u003dinstance_uuid)"},{"line_number":2372,"context_line":"        else:"},{"line_number":2373,"context_line":"            raise exception.InstanceNotFound(instance_id\u003dinstance_uuid)"},{"line_number":2374,"context_line":""},{"line_number":2375,"context_line":"        return instance"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_413d218b","line":2372,"range":{"start_line":2372,"start_character":8,"end_line":2372,"end_character":13},"updated":"2018-07-30 14:59:10.000000000","message":"Haven\u0027t you just turned this into dead code now?\n\nHonestly, I\u0027m not sure how I feel about this change as it\u0027s really testing for a case that shouldn\u0027t happen. Further, once this is merged, anyone that has stale BuildRequests in their database will suddenly start to be able to see those. Right now, they could list said instances, but 404 if they try to get them. After this change, they would see the real instance in a detailed listing, but would get the original \"this is still scheduling\" BuildRequest-based one if they do a get on it.\n\nThe way all this code was supposed to work was that BuildRequest was just a placeholder that we never show once we make it past a certain point and that was only supposed to live for a short period of time. If we failed to create a mapping then we\u0027ve destroyed that process (which apparently is happening, granted), but I\u0027d rather try to fix it instead of making this code path more ambiguous.","commit_id":"563a31d168ae58ddcb9c2bb84f9450fc796ecb77"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"0a7e70671fd4bb96074b701f6a124e71504eadd5","unresolved":false,"context_lines":[{"line_number":2369,"context_line":"                        expected_attrs\u003dexpected_attrs)"},{"line_number":2370,"context_line":"                else:"},{"line_number":2371,"context_line":"                    raise exception.InstanceNotFound(instance_id\u003dinstance_uuid)"},{"line_number":2372,"context_line":"        else:"},{"line_number":2373,"context_line":"            raise exception.InstanceNotFound(instance_id\u003dinstance_uuid)"},{"line_number":2374,"context_line":""},{"line_number":2375,"context_line":"        return instance"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_dc67d851","line":2372,"range":{"start_line":2372,"start_character":8,"end_line":2372,"end_character":13},"in_reply_to":"5f7c97a3_413d218b","updated":"2018-07-30 15:39:35.000000000","message":"I think I might have by doing this actually. The patch after this was a more brute-force transactional fix that might be a better alternative that\u0027ll make sure we never *hit* that state ever.","commit_id":"563a31d168ae58ddcb9c2bb84f9450fc796ecb77"}]}