)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7808,"name":"Xavier Queralt","email":"xqueralt@gmail.com","username":"xqueralt"},"change_message_id":"db86c089552718bc4f8e39c5c3ef7333b1098bfc","unresolved":false,"context_lines":[{"line_number":12,"context_line":"hard_reboot() should use image_meta, if it exist, when constructing"},{"line_number":13,"context_line":"the disk_info"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes Bug: #1255449"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I477f69c47515ad22165421b4d23ac865c7869873"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2BVZI%3D","line":15,"updated":"2013-11-27 09:29:10.000000000","message":"It\u0027s Closes-Bug with a dash","commit_id":"06741a9fd452ab511f09897cd83f4266e73f8a30"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"25782ec9227d330f8cbe6969ef821a9dffd1b6fc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vladik Romanovsky \u003cvladik.romanovsky@enovance.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-04 11:06:17 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Libvirt Driver - Custom disk_bus setting is being lost on hard_reboot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, a non-default disk_bus setting of and image will not be used,"},{"line_number":10,"context_line":"when powering on an instance (or _hard_reboot)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAATn%2F9pLY%3D","line":7,"updated":"2013-12-09 11:37:27.000000000","message":"This is overly verbose.  s/Libvirt Driver - /libvirt:/","commit_id":"83d47a7d70441261fa47214acca1b026f7f02300"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"573134a849c59293f2b560ab11ca451af1b1bb42","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vladik Romanovsky \u003cvladik.romanovsky@enovance.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-04 11:06:17 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Libvirt Driver - Custom disk_bus setting is being lost on hard_reboot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, a non-default disk_bus setting of and image will not be used,"},{"line_number":10,"context_line":"when powering on an instance (or _hard_reboot)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAATn%2F9oi4%3D","line":7,"in_reply_to":"AAAATn%2F9pLY%3D","updated":"2013-12-09 14:09:51.000000000","message":"Done","commit_id":"83d47a7d70441261fa47214acca1b026f7f02300"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7808,"name":"Xavier Queralt","email":"xqueralt@gmail.com","username":"xqueralt"},"change_message_id":"db86c089552718bc4f8e39c5c3ef7333b1098bfc","unresolved":false,"context_lines":[{"line_number":1984,"context_line":"        image_meta \u003d None"},{"line_number":1985,"context_line":"        if instance.get(\u0027image_ref\u0027):"},{"line_number":1986,"context_line":"            image_meta \u003d _get_image_meta(context, instance[\u0027image_ref\u0027])"},{"line_number":1987,"context_line":""},{"line_number":1988,"context_line":"        disk_info \u003d blockinfo.get_disk_info(CONF.libvirt.virt_type,"},{"line_number":1989,"context_line":"                                            instance,"},{"line_number":1990,"context_line":"                                            block_device_info,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BVYI%3D","line":1987,"updated":"2013-11-27 09:29:10.000000000","message":"Please, use the method get_image_metadata from nova.compute.utils. It will take care of handling the errors for when the image has been deleted and use the image metadata stored in the instance\u0027s system metadata.","commit_id":"06741a9fd452ab511f09897cd83f4266e73f8a30"},{"author":{"_account_id":7808,"name":"Xavier Queralt","email":"xqueralt@gmail.com","username":"xqueralt"},"change_message_id":"e1587715cfaa7aff915e5b7237db4e1d6d803288","unresolved":false,"context_lines":[{"line_number":1984,"context_line":"            return meta"},{"line_number":1985,"context_line":""},{"line_number":1986,"context_line":"        self._destroy(instance)"},{"line_number":1987,"context_line":"        image_meta \u003d _get_image_meta(context, instance)"},{"line_number":1988,"context_line":""},{"line_number":1989,"context_line":"        disk_info \u003d blockinfo.get_disk_info(CONF.libvirt.virt_type,"},{"line_number":1990,"context_line":"                                            instance,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BU1Y%3D","line":1987,"updated":"2013-11-27 11:25:30.000000000","message":"Why do you need a separate method for this? It\u0027s not used anywhere else, can\u0027t you just move its code outside?","commit_id":"0ea1208a539a0ecee7950f914031c6b484d8ab3b"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"1aa4031b5f9f90d7900862304a10dddbfecdedbc","unresolved":false,"context_lines":[{"line_number":1979,"context_line":"        image_service, image_id \u003d glance.get_remote_image_service(context,"},{"line_number":1980,"context_line":"                                                                  image_ref)"},{"line_number":1981,"context_line":"        image_meta \u003d compute_utils.get_image_metadata(context, image_service,"},{"line_number":1982,"context_line":"                                                      image_id, instance)"},{"line_number":1983,"context_line":""},{"line_number":1984,"context_line":"        disk_info \u003d blockinfo.get_disk_info(CONF.libvirt.virt_type,"},{"line_number":1985,"context_line":"                                            instance,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BSn0%3D","line":1982,"updated":"2013-11-27 19:48:05.000000000","message":"It is unfortunate we need to make the extra Glance call here. Wondering if we should be caching the image_meta in system_metadata passing that into this function from one level up?","commit_id":"bef5c9489cb0f8685660d624c560a7b82bee1902"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"6c5aa3f6aa50cea66766e801a34daf472ece344b","unresolved":false,"context_lines":[{"line_number":1979,"context_line":"        image_service, image_id \u003d glance.get_remote_image_service(context,"},{"line_number":1980,"context_line":"                                                                  image_ref)"},{"line_number":1981,"context_line":"        image_meta \u003d compute_utils.get_image_metadata(context, image_service,"},{"line_number":1982,"context_line":"                                                      image_id, instance)"},{"line_number":1983,"context_line":""},{"line_number":1984,"context_line":"        disk_info \u003d blockinfo.get_disk_info(CONF.libvirt.virt_type,"},{"line_number":1985,"context_line":"                                            instance,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F998s%3D","line":1982,"in_reply_to":"AAAATn%2F%2BSPo%3D","updated":"2013-12-03 22:20:26.000000000","message":"Thanks, I see. However, this way it makes it impossible to update the image metadata before instance power on.","commit_id":"bef5c9489cb0f8685660d624c560a7b82bee1902"},{"author":{"_account_id":7808,"name":"Xavier Queralt","email":"xqueralt@gmail.com","username":"xqueralt"},"change_message_id":"facb3cc3844ac9aec7394d6be56b30a97878453f","unresolved":false,"context_lines":[{"line_number":1979,"context_line":"        image_service, image_id \u003d glance.get_remote_image_service(context,"},{"line_number":1980,"context_line":"                                                                  image_ref)"},{"line_number":1981,"context_line":"        image_meta \u003d compute_utils.get_image_metadata(context, image_service,"},{"line_number":1982,"context_line":"                                                      image_id, instance)"},{"line_number":1983,"context_line":""},{"line_number":1984,"context_line":"        disk_info \u003d blockinfo.get_disk_info(CONF.libvirt.virt_type,"},{"line_number":1985,"context_line":"                                            instance,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BSPo%3D","line":1982,"in_reply_to":"AAAATn%2F%2BSS4%3D","updated":"2013-11-27 23:08:38.000000000","message":"Since Havana, the properties in image_meta (including hw_disk_bus) are already saved in the instance system_metadata on boot (See http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/api.py#n1124)\n\nThis is already handled by get_image_metadata, which will merge the image_meta from the system_metadata with the one in glance if the image is present.\n\nThis was done to be able to get the image_meta from the image if the instance was booted before this change was applied (without image information in the system metadata).\n\nIt might be worth changing that method (in another bug/patch) to not call glance if the instance has already the image metadata.","commit_id":"bef5c9489cb0f8685660d624c560a7b82bee1902"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"e6414b3565157d3c8279420e91f5893d910cbd40","unresolved":false,"context_lines":[{"line_number":1979,"context_line":"        image_service, image_id \u003d glance.get_remote_image_service(context,"},{"line_number":1980,"context_line":"                                                                  image_ref)"},{"line_number":1981,"context_line":"        image_meta \u003d compute_utils.get_image_metadata(context, image_service,"},{"line_number":1982,"context_line":"                                                      image_id, instance)"},{"line_number":1983,"context_line":""},{"line_number":1984,"context_line":"        disk_info \u003d blockinfo.get_disk_info(CONF.libvirt.virt_type,"},{"line_number":1985,"context_line":"                                            instance,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BSS4%3D","line":1982,"in_reply_to":"AAAATn%2F%2BSn0%3D","updated":"2013-11-27 20:57:08.000000000","message":"I don\u0027t see any previous calls to glance, on this route:\n\nmanager.start_instance()-\u003emanager._power_on()-\u003edriver.power_on()-\u003edriver._hard_reboot()\n\nAs I see it, in order to store the disk_bus in system_metadata, it will have to be done during spawn()\n\nIs that what you meant? Or am I missing something?","commit_id":"bef5c9489cb0f8685660d624c560a7b82bee1902"}]}