)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f04fea28aa522178b8fe24f1496b2fddaba10391","unresolved":false,"context_lines":[{"line_number":7,"context_line":"XenAPI: get_info was very expensive"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Getting the whole VM record is expensive and slowed down Tempest tests"},{"line_number":10,"context_line":"significantly."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I93bcef5b692a531aac41518dc29d5d4f46cded65"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F%2BHwI%3D","line":10,"updated":"2013-12-02 11:30:18.000000000","message":"I am not sure this covers the change in the code.\n\nSomething like, \"no need to get full record when only waiting the power state of the VM\" makes sense.","commit_id":"429cf2b4cb4ce408516f9cc44ae4c27770118565"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"878ca48d340d59d87b93bebddd07f50e257fd87e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"XenAPI: get_info was very expensive"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Getting the whole VM record is expensive and slowed down Tempest tests"},{"line_number":10,"context_line":"significantly."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I93bcef5b692a531aac41518dc29d5d4f46cded65"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F%2BHbM%3D","line":10,"in_reply_to":"AAAATn%2F%2BHwI%3D","updated":"2013-12-02 14:17:33.000000000","message":"Added.","commit_id":"429cf2b4cb4ce408516f9cc44ae4c27770118565"}],"nova/tests/virt/xenapi/test_vm_utils.py":[{"author":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"change_message_id":"e4cfc236e892715750b6c3dfe4211fd33db4466b","unresolved":false,"context_lines":[{"line_number":1900,"context_line":"        super(VMInfoTests, self).setUp()"},{"line_number":1901,"context_line":"        self.session \u003d mock.Mock()"},{"line_number":1902,"context_line":""},{"line_number":1903,"context_line":"    def test_get_power_state_valid(self):"},{"line_number":1904,"context_line":"        # Save on test setup calls by having these simple tests in one method"},{"line_number":1905,"context_line":"        self.session.call_xenapi.return_value \u003d \"Running\""},{"line_number":1906,"context_line":"        self.assertEqual(vm_utils.get_power_state(self.session, \"ref\"),"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2BFnc%3D","line":1903,"updated":"2013-12-02 17:32:28.000000000","message":"I kind of wish each of these assertions were separate tests, but this will do.","commit_id":"0a70c5aabd9fb46bb3272c2e9b20db4247665365"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"55d2e7e3e43beee03cce32f404daef88ea352627","unresolved":false,"context_lines":[{"line_number":1900,"context_line":"        super(VMInfoTests, self).setUp()"},{"line_number":1901,"context_line":"        self.session \u003d mock.Mock()"},{"line_number":1902,"context_line":""},{"line_number":1903,"context_line":"    def test_get_power_state_valid(self):"},{"line_number":1904,"context_line":"        # Save on test setup calls by having these simple tests in one method"},{"line_number":1905,"context_line":"        self.session.call_xenapi.return_value \u003d \"Running\""},{"line_number":1906,"context_line":"        self.assertEqual(vm_utils.get_power_state(self.session, \"ref\"),"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2BFl0%3D","line":1903,"in_reply_to":"AAAATn%2F%2BFnc%3D","updated":"2013-12-02 17:39:07.000000000","message":"If there are reasons to have separate calls I\u0027m happy to split it out.\n\nI just thought since they are all testing the same thing (the mapping between XAPI state and power_state.XXX) that we could save unit test run time by having them all in one test case.\n\nOne reason I did it this way is I think it\u0027s harder to \"lose\" one of the cases in future changes / refactoring which is easier to do with a method if another one gets accidentally added between two of these methods.","commit_id":"0a70c5aabd9fb46bb3272c2e9b20db4247665365"}],"nova/tests/virt/xenapi/test_vmops.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a03451773cee27643ffceebff9828beac2d84908","unresolved":false,"context_lines":[{"line_number":529,"context_line":"        instance \u003d {\"uuid\": \"uuid\"}"},{"line_number":530,"context_line":"        vm_ref \u003d \"vm_ref\""},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"        self.mox.StubOutWithMock(vm_utils, \u0027get_power_state\u0027)"},{"line_number":533,"context_line":"        self.mox.StubOutWithMock(greenthread, \u0027sleep\u0027)"},{"line_number":534,"context_line":"        vm_utils.get_power_state(self._session, vm_ref).AndReturn("},{"line_number":535,"context_line":"                                             power_state.SHUTDOWN)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BHwg%3D","line":532,"updated":"2013-12-02 11:29:00.000000000","message":"I would say convert to Mock, but that seems a bit silly, so I will not say that.","commit_id":"429cf2b4cb4ce408516f9cc44ae4c27770118565"}],"nova/virt/xenapi/vm_utils.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5fdfe0f27b121e188a8e5eaa5208adda5073aef3","unresolved":false,"context_lines":[{"line_number":1698,"context_line":"        return False"},{"line_number":1699,"context_line":""},{"line_number":1700,"context_line":""},{"line_number":1701,"context_line":"def get_power_state(session, vm_ref):"},{"line_number":1702,"context_line":"    xapi_state \u003d session.call_xenapi(\"VM.get_power_state\", vm_ref)"},{"line_number":1703,"context_line":"    return XENAPI_POWER_STATE[xapi_state]"},{"line_number":1704,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BHvI%3D","line":1701,"updated":"2013-12-02 11:33:01.000000000","message":"can we add a unit test for this?","commit_id":"429cf2b4cb4ce408516f9cc44ae4c27770118565"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"878ca48d340d59d87b93bebddd07f50e257fd87e","unresolved":false,"context_lines":[{"line_number":1698,"context_line":"        return False"},{"line_number":1699,"context_line":""},{"line_number":1700,"context_line":""},{"line_number":1701,"context_line":"def get_power_state(session, vm_ref):"},{"line_number":1702,"context_line":"    xapi_state \u003d session.call_xenapi(\"VM.get_power_state\", vm_ref)"},{"line_number":1703,"context_line":"    return XENAPI_POWER_STATE[xapi_state]"},{"line_number":1704,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BHbc%3D","line":1701,"in_reply_to":"AAAATn%2F%2BHvI%3D","updated":"2013-12-02 14:17:33.000000000","message":"Done","commit_id":"429cf2b4cb4ce408516f9cc44ae4c27770118565"},{"author":{"_account_id":8430,"name":"Christopher Lefelhocz","email":"christopher.lefelhoc@rackspace.com","username":"leif"},"change_message_id":"77a0dde9f4f5c334f3d8a158097d7cb03eb1fdd2","unresolved":false,"context_lines":[{"line_number":1705,"context_line":""},{"line_number":1706,"context_line":"def compile_info(session, vm_ref, record\u003dNone):"},{"line_number":1707,"context_line":"    \"\"\"Fill record with VM status information.\"\"\""},{"line_number":1708,"context_line":"    if record:"},{"line_number":1709,"context_line":"        return {\u0027state\u0027: XENAPI_POWER_STATE[record[\u0027power_state\u0027]],"},{"line_number":1710,"context_line":"                \u0027max_mem\u0027: long(record[\u0027memory_static_max\u0027]) \u003e\u003e 10,"},{"line_number":1711,"context_line":"                \u0027mem\u0027: long(record[\u0027memory_dynamic_max\u0027]) \u003e\u003e 10,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BLbY%3D","line":1708,"updated":"2013-11-29 16:39:41.000000000","message":"What about if record is none: (load record)\nand single return?\n\nWould that be better?","commit_id":"429cf2b4cb4ce408516f9cc44ae4c27770118565"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"878ca48d340d59d87b93bebddd07f50e257fd87e","unresolved":false,"context_lines":[{"line_number":1705,"context_line":""},{"line_number":1706,"context_line":"def compile_info(session, vm_ref, record\u003dNone):"},{"line_number":1707,"context_line":"    \"\"\"Fill record with VM status information.\"\"\""},{"line_number":1708,"context_line":"    if record:"},{"line_number":1709,"context_line":"        return {\u0027state\u0027: XENAPI_POWER_STATE[record[\u0027power_state\u0027]],"},{"line_number":1710,"context_line":"                \u0027max_mem\u0027: long(record[\u0027memory_static_max\u0027]) \u003e\u003e 10,"},{"line_number":1711,"context_line":"                \u0027mem\u0027: long(record[\u0027memory_dynamic_max\u0027]) \u003e\u003e 10,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BHbo%3D","line":1708,"in_reply_to":"AAAATn%2F%2BLbY%3D","updated":"2013-12-02 14:17:33.000000000","message":"It would be notably slower - and is effectively what the previous code did (compile_info was called with the output of VM.get_record)","commit_id":"429cf2b4cb4ce408516f9cc44ae4c27770118565"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a03451773cee27643ffceebff9828beac2d84908","unresolved":false,"context_lines":[{"line_number":1706,"context_line":"def compile_info(session, vm_ref, record\u003dNone):"},{"line_number":1707,"context_line":"    \"\"\"Fill record with VM status information.\"\"\""},{"line_number":1708,"context_line":"    if record:"},{"line_number":1709,"context_line":"        return {\u0027state\u0027: XENAPI_POWER_STATE[record[\u0027power_state\u0027]],"},{"line_number":1710,"context_line":"                \u0027max_mem\u0027: long(record[\u0027memory_static_max\u0027]) \u003e\u003e 10,"},{"line_number":1711,"context_line":"                \u0027mem\u0027: long(record[\u0027memory_dynamic_max\u0027]) \u003e\u003e 10,"},{"line_number":1712,"context_line":"                \u0027num_cpu\u0027: record[\u0027VCPUs_max\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BHw4%3D","line":1709,"updated":"2013-12-02 11:29:00.000000000","message":"I almost want to share this code with the above method, but maybe thats silly.","commit_id":"429cf2b4cb4ce408516f9cc44ae4c27770118565"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"878ca48d340d59d87b93bebddd07f50e257fd87e","unresolved":false,"context_lines":[{"line_number":1706,"context_line":"def compile_info(session, vm_ref, record\u003dNone):"},{"line_number":1707,"context_line":"    \"\"\"Fill record with VM status information.\"\"\""},{"line_number":1708,"context_line":"    if record:"},{"line_number":1709,"context_line":"        return {\u0027state\u0027: XENAPI_POWER_STATE[record[\u0027power_state\u0027]],"},{"line_number":1710,"context_line":"                \u0027max_mem\u0027: long(record[\u0027memory_static_max\u0027]) \u003e\u003e 10,"},{"line_number":1711,"context_line":"                \u0027mem\u0027: long(record[\u0027memory_dynamic_max\u0027]) \u003e\u003e 10,"},{"line_number":1712,"context_line":"                \u0027num_cpu\u0027: record[\u0027VCPUs_max\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BHbg%3D","line":1709,"in_reply_to":"AAAATn%2F%2BHw4%3D","updated":"2013-12-02 14:17:33.000000000","message":"Since it\u0027s just a dictionary lookup I don\u0027t think that\u0027s worth it.","commit_id":"429cf2b4cb4ce408516f9cc44ae4c27770118565"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5fdfe0f27b121e188a8e5eaa5208adda5073aef3","unresolved":false,"context_lines":[{"line_number":1715,"context_line":"    max_mem \u003d session.call_xenapi(\"VM.get_memory_static_max\", vm_ref)"},{"line_number":1716,"context_line":"    mem \u003d session.call_xenapi(\"VM.get_memory_dynamic_max\", vm_ref)"},{"line_number":1717,"context_line":"    num_cpu \u003d session.call_xenapi(\"VM.get_VCPUs_max\", vm_ref)"},{"line_number":1718,"context_line":"    return {\u0027state\u0027: get_power_state(session, vm_ref),"},{"line_number":1719,"context_line":"            \u0027max_mem\u0027: long(max_mem) \u003e\u003e 10,"},{"line_number":1720,"context_line":"            \u0027mem\u0027: long(mem) \u003e\u003e 10,"},{"line_number":1721,"context_line":"            \u0027num_cpu\u0027: num_cpu,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BHvA%3D","line":1718,"updated":"2013-12-02 11:33:01.000000000","message":"Same here, might be nice to add a unit test.","commit_id":"429cf2b4cb4ce408516f9cc44ae4c27770118565"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"878ca48d340d59d87b93bebddd07f50e257fd87e","unresolved":false,"context_lines":[{"line_number":1715,"context_line":"    max_mem \u003d session.call_xenapi(\"VM.get_memory_static_max\", vm_ref)"},{"line_number":1716,"context_line":"    mem \u003d session.call_xenapi(\"VM.get_memory_dynamic_max\", vm_ref)"},{"line_number":1717,"context_line":"    num_cpu \u003d session.call_xenapi(\"VM.get_VCPUs_max\", vm_ref)"},{"line_number":1718,"context_line":"    return {\u0027state\u0027: get_power_state(session, vm_ref),"},{"line_number":1719,"context_line":"            \u0027max_mem\u0027: long(max_mem) \u003e\u003e 10,"},{"line_number":1720,"context_line":"            \u0027mem\u0027: long(mem) \u003e\u003e 10,"},{"line_number":1721,"context_line":"            \u0027num_cpu\u0027: num_cpu,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BHbY%3D","line":1718,"in_reply_to":"AAAATn%2F%2BHvA%3D","updated":"2013-12-02 14:17:33.000000000","message":"Done","commit_id":"429cf2b4cb4ce408516f9cc44ae4c27770118565"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7e464af15a0df127294b1738547f3f9f2480dd46","unresolved":false,"context_lines":[{"line_number":1706,"context_line":""},{"line_number":1707,"context_line":"def compile_info(session, vm_ref, record\u003dNone):"},{"line_number":1708,"context_line":"    \"\"\"Fill record with VM status information.\"\"\""},{"line_number":1709,"context_line":"    if record:"},{"line_number":1710,"context_line":"        return {\u0027state\u0027: XENAPI_POWER_STATE[record[\u0027power_state\u0027]],"},{"line_number":1711,"context_line":"                \u0027max_mem\u0027: long(record[\u0027memory_static_max\u0027]) \u003e\u003e 10,"},{"line_number":1712,"context_line":"                \u0027mem\u0027: long(record[\u0027memory_dynamic_max\u0027]) \u003e\u003e 10,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9DTs%3D","line":1709,"updated":"2013-12-17 09:23:26.000000000","message":"Maybe it is worth while reading these all into local vars and then return the dictionary at the end of the method. That is:\n\nif record:\n    state \u003d XENAPI_POWER_STATE[record[\u0027power_state\u0027]]\n    max_mem \u003d ...\nelse:\n   state \u003d get_power_state(session, vm_ref),\n\nreturn {\u0027state\u0027: state, ...}","commit_id":"39e8afb5861e29540cd63a6124b07ec83bdc183c"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"1c8a450d92f9b42c7179cdc4f878e053ccc68b02","unresolved":false,"context_lines":[{"line_number":1706,"context_line":""},{"line_number":1707,"context_line":"def compile_info(session, vm_ref, record\u003dNone):"},{"line_number":1708,"context_line":"    \"\"\"Fill record with VM status information.\"\"\""},{"line_number":1709,"context_line":"    if record:"},{"line_number":1710,"context_line":"        return {\u0027state\u0027: XENAPI_POWER_STATE[record[\u0027power_state\u0027]],"},{"line_number":1711,"context_line":"                \u0027max_mem\u0027: long(record[\u0027memory_static_max\u0027]) \u003e\u003e 10,"},{"line_number":1712,"context_line":"                \u0027mem\u0027: long(record[\u0027memory_dynamic_max\u0027]) \u003e\u003e 10,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9DF8%3D","line":1709,"in_reply_to":"AAAATn%2F9DTs%3D","updated":"2013-12-17 10:34:37.000000000","message":"Agreed that this could be a useful simplication.","commit_id":"39e8afb5861e29540cd63a6124b07ec83bdc183c"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"9c9eebd4cd65e1b8381eaac1375afeaf5088a691","unresolved":false,"context_lines":[{"line_number":1709,"context_line":"    if record:"},{"line_number":1710,"context_line":"        power_state \u003d XENAPI_POWER_STATE[record[\u0027power_state\u0027]]"},{"line_number":1711,"context_line":"        max_mem \u003d record[\u0027memory_static_max\u0027]"},{"line_number":1712,"context_line":"        mem \u003d record[\u0027memory_dynamic_max\u0027]"},{"line_number":1713,"context_line":"        num_cpu \u003d record[\u0027VCPUs_max\u0027]"},{"line_number":1714,"context_line":"    else:"},{"line_number":1715,"context_line":"        power_state \u003d get_power_state(session, vm_ref)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2FyBc%3D","line":1712,"updated":"2014-01-08 14:55:25.000000000","message":"It\u0027s not entirely clear to me why the long cast and bitshift is no longer necessary.  And after a quick search it looks like there are no cases of record being passed in.  Should this just be removed?","commit_id":"048d275be0eaf4bd3504c11c7a398e8be7f6c6bb"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"367a62e8ae2c2b14b77f2c81435b91529241243a","unresolved":false,"context_lines":[{"line_number":1709,"context_line":"    if record:"},{"line_number":1710,"context_line":"        power_state \u003d XENAPI_POWER_STATE[record[\u0027power_state\u0027]]"},{"line_number":1711,"context_line":"        max_mem \u003d record[\u0027memory_static_max\u0027]"},{"line_number":1712,"context_line":"        mem \u003d record[\u0027memory_dynamic_max\u0027]"},{"line_number":1713,"context_line":"        num_cpu \u003d record[\u0027VCPUs_max\u0027]"},{"line_number":1714,"context_line":"    else:"},{"line_number":1715,"context_line":"        power_state \u003d get_power_state(session, vm_ref)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2FxQc%3D","line":1712,"in_reply_to":"AAAAUH%2F%2FxXI%3D","updated":"2014-01-08 17:10:43.000000000","message":"Cool, good spot, its worth a tidy.","commit_id":"048d275be0eaf4bd3504c11c7a398e8be7f6c6bb"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"b527fbf07052407341d5a9e90b7f52d0701dc675","unresolved":false,"context_lines":[{"line_number":1709,"context_line":"    if record:"},{"line_number":1710,"context_line":"        power_state \u003d XENAPI_POWER_STATE[record[\u0027power_state\u0027]]"},{"line_number":1711,"context_line":"        max_mem \u003d record[\u0027memory_static_max\u0027]"},{"line_number":1712,"context_line":"        mem \u003d record[\u0027memory_dynamic_max\u0027]"},{"line_number":1713,"context_line":"        num_cpu \u003d record[\u0027VCPUs_max\u0027]"},{"line_number":1714,"context_line":"    else:"},{"line_number":1715,"context_line":"        power_state \u003d get_power_state(session, vm_ref)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2FxKs%3D","line":1712,"in_reply_to":"AAAAUH%2F%2Fxao%3D","updated":"2014-01-08 17:31:10.000000000","message":"Ahh, I see it now.  The way the diff is formatted threw me off.","commit_id":"048d275be0eaf4bd3504c11c7a398e8be7f6c6bb"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"bae869923aadcd5dcd46e5bc724660bfd805798c","unresolved":false,"context_lines":[{"line_number":1709,"context_line":"    if record:"},{"line_number":1710,"context_line":"        power_state \u003d XENAPI_POWER_STATE[record[\u0027power_state\u0027]]"},{"line_number":1711,"context_line":"        max_mem \u003d record[\u0027memory_static_max\u0027]"},{"line_number":1712,"context_line":"        mem \u003d record[\u0027memory_dynamic_max\u0027]"},{"line_number":1713,"context_line":"        num_cpu \u003d record[\u0027VCPUs_max\u0027]"},{"line_number":1714,"context_line":"    else:"},{"line_number":1715,"context_line":"        power_state \u003d get_power_state(session, vm_ref)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2FxXI%3D","line":1712,"in_reply_to":"AAAAUH%2F%2Fxao%3D","updated":"2014-01-08 16:54:06.000000000","message":"record is not passed in by anyone currently - I left it in for future callers as the performance of the new code is significantly worse if you have a record already.\n\nAs it\u0027s currently unused code, I\u0027ll remove it and post a new patch tomorrow.","commit_id":"048d275be0eaf4bd3504c11c7a398e8be7f6c6bb"},{"author":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"change_message_id":"5aa61e5e399d2163e0e26ba67fa61e9030f0d7b0","unresolved":false,"context_lines":[{"line_number":1709,"context_line":"    if record:"},{"line_number":1710,"context_line":"        power_state \u003d XENAPI_POWER_STATE[record[\u0027power_state\u0027]]"},{"line_number":1711,"context_line":"        max_mem \u003d record[\u0027memory_static_max\u0027]"},{"line_number":1712,"context_line":"        mem \u003d record[\u0027memory_dynamic_max\u0027]"},{"line_number":1713,"context_line":"        num_cpu \u003d record[\u0027VCPUs_max\u0027]"},{"line_number":1714,"context_line":"    else:"},{"line_number":1715,"context_line":"        power_state \u003d get_power_state(session, vm_ref)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2Fxao%3D","line":1712,"in_reply_to":"AAAAUH%2F%2FyBc%3D","updated":"2014-01-08 16:41:58.000000000","message":"He moved the entire return, including bitshifts, down a few lines.\n\nBut if the code isn\u0027t being used, I\u0027d agree we should remove it.","commit_id":"048d275be0eaf4bd3504c11c7a398e8be7f6c6bb"}]}