)]}'
{"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"31c930c2103f70f9379c3835a72c37f052cfe204","unresolved":false,"context_lines":[{"line_number":7122,"context_line":"        self._check_xml_and_disk_bus(image_meta,"},{"line_number":7123,"context_line":"                                     block_device_info,"},{"line_number":7124,"context_line":"                                     (expected,))"},{"line_number":7125,"context_line":""},{"line_number":7126,"context_line":"    def test_xml_disk_bus_ide_and_virtio(self):"},{"line_number":7127,"context_line":"        # It\u0027s necessary to check if the architecture is power, because"},{"line_number":7128,"context_line":"        # power doesn\u0027t have support to ide, and so libvirt translate"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ef163a4a","line":7125,"updated":"2018-08-28 21:12:08.000000000","message":"We don\u0027t usually use this regression func test style for unit tests, though it does make sense what you\u0027ve done here. If we need to backport this bug fix, we\u0027d have to backport both of these patches (obviously).","commit_id":"7ff198619030685d14d739dee645bf44eee30c22"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"91e6531033e68cb99ebec60cc149e3c5c45645b4","unresolved":false,"context_lines":[{"line_number":7122,"context_line":"        self._check_xml_and_disk_bus(image_meta,"},{"line_number":7123,"context_line":"                                     block_device_info,"},{"line_number":7124,"context_line":"                                     (expected,))"},{"line_number":7125,"context_line":""},{"line_number":7126,"context_line":"    def test_xml_disk_bus_ide_and_virtio(self):"},{"line_number":7127,"context_line":"        # It\u0027s necessary to check if the architecture is power, because"},{"line_number":7128,"context_line":"        # power doesn\u0027t have support to ide, and so libvirt translate"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_3609b794","line":7125,"in_reply_to":"3f79a3b5_bbd5b2b9","updated":"2018-08-30 16:40:31.000000000","message":"The pattern we\u0027ve been using for tests under nova/tests/functional/regressions/ is to write a test that asserts the buggy/wrong behavior in one change, then update the test in a second change that fixes the bug. Which is what Sean has done here. I was just saying that we don\u0027t normally do that with unit tests (for whatever reason) and that this would usually be squashed into one change.","commit_id":"7ff198619030685d14d739dee645bf44eee30c22"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"adcbe2082c11a2d04e000570e6293aa9be0e1fda","unresolved":false,"context_lines":[{"line_number":7122,"context_line":"        self._check_xml_and_disk_bus(image_meta,"},{"line_number":7123,"context_line":"                                     block_device_info,"},{"line_number":7124,"context_line":"                                     (expected,))"},{"line_number":7125,"context_line":""},{"line_number":7126,"context_line":"    def test_xml_disk_bus_ide_and_virtio(self):"},{"line_number":7127,"context_line":"        # It\u0027s necessary to check if the architecture is power, because"},{"line_number":7128,"context_line":"        # power doesn\u0027t have support to ide, and so libvirt translate"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_bbd5b2b9","line":7125,"in_reply_to":"3f79a3b5_ef163a4a","updated":"2018-08-30 16:09:07.000000000","message":"Not sure what you mean by \"regression func test style\" but if we used the @unittest.expectedFailure decorator here, we\u0027d avoid needing to write this \"false\" test.","commit_id":"7ff198619030685d14d739dee645bf44eee30c22"}]}