)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"9eaf54a8f336e862a04b589f99cecc56e7b4b4d3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Destroy evacuated instance while unset nova-compute forced_down"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"While the nova-compute was setted forced_down the instances running"},{"line_number":10,"context_line":"on it could be evacuated to another host. While unset nova-compute"},{"line_number":11,"context_line":"forced_down it should destroy these evacuated instances, just like"},{"line_number":12,"context_line":"restart nova-compute service did."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_1fecd9c5","line":9,"range":{"start_line":9,"start_character":23,"end_line":9,"end_character":45},"updated":"2018-08-07 18:29:48.000000000","message":"s/While the nova-compute was setted forced_down/When a nova-compute is forced down, /","commit_id":"ec502de9224ecc414257c591bff40f4a4501fda0"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"9eaf54a8f336e862a04b589f99cecc56e7b4b4d3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Destroy evacuated instance while unset nova-compute forced_down"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"While the nova-compute was setted forced_down the instances running"},{"line_number":10,"context_line":"on it could be evacuated to another host. While unset nova-compute"},{"line_number":11,"context_line":"forced_down it should destroy these evacuated instances, just like"},{"line_number":12,"context_line":"restart nova-compute service did."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_bff92581","line":10,"range":{"start_line":10,"start_character":42,"end_line":10,"end_character":47},"updated":"2018-08-07 18:29:48.000000000","message":"s/While .../When the nova-compute is brought up after being forced down/","commit_id":"ec502de9224ecc414257c591bff40f4a4501fda0"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"9eaf54a8f336e862a04b589f99cecc56e7b4b4d3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"While the nova-compute was setted forced_down the instances running"},{"line_number":10,"context_line":"on it could be evacuated to another host. While unset nova-compute"},{"line_number":11,"context_line":"forced_down it should destroy these evacuated instances, just like"},{"line_number":12,"context_line":"restart nova-compute service did."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-bug: #1784826"},{"line_number":15,"context_line":"Change-Id: Idbeca76ad11fdb82a2a134fa8283c19ab7a66f5d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_9ff0e992","line":12,"range":{"start_line":12,"start_character":29,"end_line":12,"end_character":32},"updated":"2018-08-07 18:29:48.000000000","message":"s/did/would/","commit_id":"ec502de9224ecc414257c591bff40f4a4501fda0"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"9eaf54a8f336e862a04b589f99cecc56e7b4b4d3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"While the nova-compute was setted forced_down the instances running"},{"line_number":10,"context_line":"on it could be evacuated to another host. While unset nova-compute"},{"line_number":11,"context_line":"forced_down it should destroy these evacuated instances, just like"},{"line_number":12,"context_line":"restart nova-compute service did."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-bug: #1784826"},{"line_number":15,"context_line":"Change-Id: Idbeca76ad11fdb82a2a134fa8283c19ab7a66f5d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_5f301157","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":7},"updated":"2018-08-07 18:29:48.000000000","message":"s/restart/restarting/","commit_id":"ec502de9224ecc414257c591bff40f4a4501fda0"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4cbf9b9ddc5f915d7dcac9c060fed505ac3b39b2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Destroy evacuated instance while unset nova-compute forced_down"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a nova-compute is forced down, the instances running on it"},{"line_number":10,"context_line":"could be evacuated to another host. When the nova-compute is"},{"line_number":11,"context_line":"brought up after being forced down it should destroy these"},{"line_number":12,"context_line":"evacuated instances, just like restarting nova-compute service would."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-bug: #1784826"},{"line_number":15,"context_line":"Change-Id: Idbeca76ad11fdb82a2a134fa8283c19ab7a66f5d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_d3292e8a","line":12,"range":{"start_line":9,"start_character":1,"end_line":12,"end_character":69},"updated":"2018-08-10 08:36:02.000000000","message":"The intention of forced_down flag is to give a way to the deployer to state that she made sure thatt the service is dead. So if the deployer sets forced_down flag but does not make sure that the service is dead the she does not use the API as intended.\n\nFor me the use case described in this commit message is invalid.","commit_id":"1d9f139150c82d9998b98e6e187f1b79e4dcba6d"}],"nova/compute/api.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"9eaf54a8f336e862a04b589f99cecc56e7b4b4d3","unresolved":false,"context_lines":[{"line_number":4974,"context_line":"        service \u003d objects.Service.get_by_args(context, host_name, binary)"},{"line_number":4975,"context_line":"        try:"},{"line_number":4976,"context_line":"            forced_down \u003d service.forced_down"},{"line_number":4977,"context_line":"        except Exception:"},{"line_number":4978,"context_line":"            forced_down \u003d False"},{"line_number":4979,"context_line":"        service.update(params_to_update)"},{"line_number":4980,"context_line":"        service.save()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_1f8859e5","line":4977,"updated":"2018-08-07 18:29:48.000000000","message":"this is not how to check an attribute on an object.\n\nInstead, do this:\n\n forced_down \u003d \u0027forced_down\u0027 in service and service.forced_down","commit_id":"ec502de9224ecc414257c591bff40f4a4501fda0"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"9eaf54a8f336e862a04b589f99cecc56e7b4b4d3","unresolved":false,"context_lines":[{"line_number":4982,"context_line":"        # Unset nova-compute service forced-down should destroy evacuated"},{"line_number":4983,"context_line":"        # instances on the host."},{"line_number":4984,"context_line":"        if binary \u003d\u003d \u0027nova-compute\u0027 and forced_down and \\"},{"line_number":4985,"context_line":"                not params_to_update.get(\u0027forced_down\u0027, True):"},{"line_number":4986,"context_line":"            self.rpcapi.destroy_evacuated_instances(context, host\u003dhost_name)"},{"line_number":4987,"context_line":""},{"line_number":4988,"context_line":"        return service"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_ffd0fdcb","line":4985,"updated":"2018-08-07 18:29:48.000000000","message":"how about adding a LOG.debug() message here explaining that a nova-compute service is being brought back up after being forced down and that we will destroy evacuated instances.","commit_id":"ec502de9224ecc414257c591bff40f4a4501fda0"}],"nova/compute/manager.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"9eaf54a8f336e862a04b589f99cecc56e7b4b4d3","unresolved":false,"context_lines":[{"line_number":490,"context_line":"class ComputeManager(manager.Manager):"},{"line_number":491,"context_line":"    \"\"\"Manages the running instances from creation to destruction.\"\"\""},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    target \u003d messaging.Target(version\u003d\u00275.0\u0027)"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"    def __init__(self, compute_driver\u003dNone, *args, **kwargs):"},{"line_number":496,"context_line":"        \"\"\"Load configuration options and connect to the hypervisor.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_ca945e8e","line":493,"updated":"2018-08-07 18:29:48.000000000","message":"this needs to be updated to 5.1 and a comment added in the rpcapi.py file explaining the new RPC API version.","commit_id":"ec502de9224ecc414257c591bff40f4a4501fda0"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"9eaf54a8f336e862a04b589f99cecc56e7b4b4d3","unresolved":false,"context_lines":[{"line_number":1219,"context_line":"        try:"},{"line_number":1220,"context_line":"            # checking that instance was not already evacuated to other host"},{"line_number":1221,"context_line":"            self._destroy_evacuated_instances(context)"},{"line_number":1222,"context_line":"        except Exception as e:"},{"line_number":1223,"context_line":"            LOG.exception(\u0027Destroy evacuated instances failed as %s\u0027, e)"},{"line_number":1224,"context_line":""},{"line_number":1225,"context_line":"    def cleanup_host(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_2a9b92c9","line":1222,"updated":"2018-08-07 18:29:48.000000000","message":"Please break these out into specific exceptions that are raised from _destroy_evacuated_instances().","commit_id":"ec502de9224ecc414257c591bff40f4a4501fda0"}],"nova/compute/rpcapi.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"9eaf54a8f336e862a04b589f99cecc56e7b4b4d3","unresolved":false,"context_lines":[{"line_number":852,"context_line":"                   migrate_data\u003dmigrate_data)"},{"line_number":853,"context_line":""},{"line_number":854,"context_line":"    def destroy_evacuated_instances(self, ctxt, host):"},{"line_number":855,"context_line":"        version \u003d \u00275.0\u0027"},{"line_number":856,"context_line":"        cctxt \u003d self.router.client(ctxt).prepare("},{"line_number":857,"context_line":"                server\u003dhost, version\u003dversion)"},{"line_number":858,"context_line":"        return cctxt.call(ctxt, \u0027destroy_evacuated_instances\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_8ab50634","line":855,"range":{"start_line":855,"start_character":18,"end_line":855,"end_character":23},"updated":"2018-08-07 18:29:48.000000000","message":"you need to increment the RPC API version when you add new functionality. This should be 5.1 and you should add a comment at the top of this file where the other RPC API versions are defined.","commit_id":"ec502de9224ecc414257c591bff40f4a4501fda0"}]}