)]}'
{"nova/api/openstack/placement/objects/resource_provider.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"989973ccbaebfce7e653d43d0b03f01106ab7c8f","unresolved":false,"context_lines":[{"line_number":4036,"context_line":"    def _get_by_requests(cls, context, requests, limit\u003dNone,"},{"line_number":4037,"context_line":"                         group_policy\u003dNone):"},{"line_number":4038,"context_line":"        candidates \u003d {}"},{"line_number":4039,"context_line":"        this_req \u003d 1"},{"line_number":4040,"context_line":"        num_reqs \u003d len(requests)"},{"line_number":4041,"context_line":"        for suffix, request in requests.items():"},{"line_number":4042,"context_line":"            alloc_reqs, summaries \u003d cls._get_by_one_request(context, request)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_cc34a1ae","line":4039,"range":{"start_line":4039,"start_character":8,"end_line":4039,"end_character":20},"updated":"2018-08-03 03:02:03.000000000","message":"just print the \u0027suffix\u0027 is enough I think?","commit_id":"62ef1e9c50acd1e11a58afb0cff62b8516b062da"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a590705cda36bc9c2089a07473dbd764289b6873","unresolved":false,"context_lines":[{"line_number":4036,"context_line":"    def _get_by_requests(cls, context, requests, limit\u003dNone,"},{"line_number":4037,"context_line":"                         group_policy\u003dNone):"},{"line_number":4038,"context_line":"        candidates \u003d {}"},{"line_number":4039,"context_line":"        this_req \u003d 1"},{"line_number":4040,"context_line":"        num_reqs \u003d len(requests)"},{"line_number":4041,"context_line":"        for suffix, request in requests.items():"},{"line_number":4042,"context_line":"            alloc_reqs, summaries \u003d cls._get_by_one_request(context, request)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_c00c5d98","line":4039,"range":{"start_line":4039,"start_character":8,"end_line":4039,"end_character":20},"in_reply_to":"5f7c97a3_92b004e2","updated":"2018-08-03 13:42:16.000000000","message":"That\u0027s a good idea, in case it\u0027s not obvious based on the querystring (which is in the debug log just above these).","commit_id":"62ef1e9c50acd1e11a58afb0cff62b8516b062da"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c2d1be86449fc871861fcab89f8efcd15e086f01","unresolved":false,"context_lines":[{"line_number":4036,"context_line":"    def _get_by_requests(cls, context, requests, limit\u003dNone,"},{"line_number":4037,"context_line":"                         group_policy\u003dNone):"},{"line_number":4038,"context_line":"        candidates \u003d {}"},{"line_number":4039,"context_line":"        this_req \u003d 1"},{"line_number":4040,"context_line":"        num_reqs \u003d len(requests)"},{"line_number":4041,"context_line":"        for suffix, request in requests.items():"},{"line_number":4042,"context_line":"            alloc_reqs, summaries \u003d cls._get_by_one_request(context, request)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_92b004e2","line":4039,"range":{"start_line":4039,"start_character":8,"end_line":4039,"end_character":20},"in_reply_to":"5f7c97a3_cc34a1ae","updated":"2018-08-03 06:45:15.000000000","message":"request group ids doesn\u0027t have to be sequential. However I agree that printing the suffix helps to identify the given group easier.","commit_id":"62ef1e9c50acd1e11a58afb0cff62b8516b062da"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"989973ccbaebfce7e653d43d0b03f01106ab7c8f","unresolved":false,"context_lines":[{"line_number":4040,"context_line":"        num_reqs \u003d len(requests)"},{"line_number":4041,"context_line":"        for suffix, request in requests.items():"},{"line_number":4042,"context_line":"            alloc_reqs, summaries \u003d cls._get_by_one_request(context, request)"},{"line_number":4043,"context_line":"            LOG.debug(\"%s (%d of %d) returned %d matches\","},{"line_number":4044,"context_line":"                      str(request), this_req, num_reqs, len(alloc_reqs))"},{"line_number":4045,"context_line":"            this_req +\u003d 1"},{"line_number":4046,"context_line":"            if not alloc_reqs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_cccfc1b0","line":4043,"range":{"start_line":4043,"start_character":49,"end_line":4043,"end_character":56},"updated":"2018-08-03 03:02:03.000000000","message":"Maybe it should be clear, it doesn\u0027t mean three hosts matched, just three RPs matched. Not sure the operator understand those detail.","commit_id":"62ef1e9c50acd1e11a58afb0cff62b8516b062da"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"dbda3575de3f09658c7de19e5891f1116b5f39c4","unresolved":false,"context_lines":[{"line_number":4040,"context_line":"        num_reqs \u003d len(requests)"},{"line_number":4041,"context_line":"        for suffix, request in requests.items():"},{"line_number":4042,"context_line":"            alloc_reqs, summaries \u003d cls._get_by_one_request(context, request)"},{"line_number":4043,"context_line":"            LOG.debug(\"%s (%d of %d) returned %d matches\","},{"line_number":4044,"context_line":"                      str(request), this_req, num_reqs, len(alloc_reqs))"},{"line_number":4045,"context_line":"            this_req +\u003d 1"},{"line_number":4046,"context_line":"            if not alloc_reqs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_afbb5be3","line":4043,"range":{"start_line":4043,"start_character":49,"end_line":4043,"end_character":56},"in_reply_to":"5f7c97a3_20e991aa","updated":"2018-08-06 05:23:37.000000000","message":"Yea, actually I\u0027m thinking we should clear that \u0027return 3 matches allocation requests\u0027. I just thought the operator can\u0027t think about \u00273 matches\u0027 as hosts in the beginning.","commit_id":"62ef1e9c50acd1e11a58afb0cff62b8516b062da"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a590705cda36bc9c2089a07473dbd764289b6873","unresolved":false,"context_lines":[{"line_number":4040,"context_line":"        num_reqs \u003d len(requests)"},{"line_number":4041,"context_line":"        for suffix, request in requests.items():"},{"line_number":4042,"context_line":"            alloc_reqs, summaries \u003d cls._get_by_one_request(context, request)"},{"line_number":4043,"context_line":"            LOG.debug(\"%s (%d of %d) returned %d matches\","},{"line_number":4044,"context_line":"                      str(request), this_req, num_reqs, len(alloc_reqs))"},{"line_number":4045,"context_line":"            this_req +\u003d 1"},{"line_number":4046,"context_line":"            if not alloc_reqs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_20e991aa","line":4043,"range":{"start_line":4043,"start_character":49,"end_line":4043,"end_character":56},"in_reply_to":"5f7c97a3_52dfcc0a","updated":"2018-08-03 13:42:16.000000000","message":"Right.\n\nIt\u0027s not even necessarily three different providers. It\u0027s three allocation requests. They could be on any combination of different/same providers; and the matches for the unnumbered group could in fact span multiple providers.\n\nNote that I was considering adding TRACE output that would print the actual allocation requests here; left it out for expediency.","commit_id":"62ef1e9c50acd1e11a58afb0cff62b8516b062da"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c2d1be86449fc871861fcab89f8efcd15e086f01","unresolved":false,"context_lines":[{"line_number":4040,"context_line":"        num_reqs \u003d len(requests)"},{"line_number":4041,"context_line":"        for suffix, request in requests.items():"},{"line_number":4042,"context_line":"            alloc_reqs, summaries \u003d cls._get_by_one_request(context, request)"},{"line_number":4043,"context_line":"            LOG.debug(\"%s (%d of %d) returned %d matches\","},{"line_number":4044,"context_line":"                      str(request), this_req, num_reqs, len(alloc_reqs))"},{"line_number":4045,"context_line":"            this_req +\u003d 1"},{"line_number":4046,"context_line":"            if not alloc_reqs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_d2a43ca7","line":4043,"range":{"start_line":4043,"start_character":49,"end_line":4043,"end_character":56},"in_reply_to":"5f7c97a3_cccfc1b0","updated":"2018-08-03 06:45:15.000000000","message":"RP does not have the notion of compute host so deployer has to adapt in this case.","commit_id":"62ef1e9c50acd1e11a58afb0cff62b8516b062da"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c50ecdcd3f665c3d68fe465d03e5af1db5bd033a","unresolved":false,"context_lines":[{"line_number":4040,"context_line":"        num_reqs \u003d len(requests)"},{"line_number":4041,"context_line":"        for suffix, request in requests.items():"},{"line_number":4042,"context_line":"            alloc_reqs, summaries \u003d cls._get_by_one_request(context, request)"},{"line_number":4043,"context_line":"            LOG.debug(\"%s (%d of %d) returned %d matches\","},{"line_number":4044,"context_line":"                      str(request), this_req, num_reqs, len(alloc_reqs))"},{"line_number":4045,"context_line":"            this_req +\u003d 1"},{"line_number":4046,"context_line":"            if not alloc_reqs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_52dfcc0a","line":4043,"range":{"start_line":4043,"start_character":49,"end_line":4043,"end_character":56},"in_reply_to":"5f7c97a3_d2a43ca7","updated":"2018-08-03 06:45:53.000000000","message":"I mean placement does not have the notion.","commit_id":"62ef1e9c50acd1e11a58afb0cff62b8516b062da"}]}