)]}'
{"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8d048a1ee8ca604e41af3b07c7f274da77a01f03","unresolved":false,"context_lines":[{"line_number":6267,"context_line":"                requested_networks\u003drequested_networks)"},{"line_number":6268,"context_line":""},{"line_number":6269,"context_line":"    @mock.patch(\u0027oslo_service.loopingcall._ThreadingEvent.wait\u0027,"},{"line_number":6270,"context_line":"                new\u003dmock.Mock())"},{"line_number":6271,"context_line":"    @mock.patch(\u0027nova.compute.manager.ComputeManager._deallocate_network\u0027)"},{"line_number":6272,"context_line":"    @mock.patch(\u0027nova.compute.manager.LOG.warning\u0027)"},{"line_number":6273,"context_line":"    def test_try_deallocate_network_retry_direct(self, warning_mock,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_b7c17b52","line":6270,"updated":"2018-08-02 19:40:31.000000000","message":"Why pass the new kwarg instead of just letting it default to mock.MagicMock?","commit_id":"7b42be7893e324908005a5fcd827a9b186e04094"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"44dc458b8c7646314caf8e0fe715e4984382ba14","unresolved":false,"context_lines":[{"line_number":6267,"context_line":"                requested_networks\u003drequested_networks)"},{"line_number":6268,"context_line":""},{"line_number":6269,"context_line":"    @mock.patch(\u0027oslo_service.loopingcall._ThreadingEvent.wait\u0027,"},{"line_number":6270,"context_line":"                new\u003dmock.Mock())"},{"line_number":6271,"context_line":"    @mock.patch(\u0027nova.compute.manager.ComputeManager._deallocate_network\u0027)"},{"line_number":6272,"context_line":"    @mock.patch(\u0027nova.compute.manager.LOG.warning\u0027)"},{"line_number":6273,"context_line":"    def test_try_deallocate_network_retry_direct(self, warning_mock,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_77120367","line":6270,"in_reply_to":"5f7c97a3_b7197bd3","updated":"2018-08-02 20:01:02.000000000","message":"Derp, I used to know that about new avoiding the mock arg to the test method.","commit_id":"7b42be7893e324908005a5fcd827a9b186e04094"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"aa5cfcd948e853ea510d7a718ef466e32c1c5a2c","unresolved":false,"context_lines":[{"line_number":6267,"context_line":"                requested_networks\u003drequested_networks)"},{"line_number":6268,"context_line":""},{"line_number":6269,"context_line":"    @mock.patch(\u0027oslo_service.loopingcall._ThreadingEvent.wait\u0027,"},{"line_number":6270,"context_line":"                new\u003dmock.Mock())"},{"line_number":6271,"context_line":"    @mock.patch(\u0027nova.compute.manager.ComputeManager._deallocate_network\u0027)"},{"line_number":6272,"context_line":"    @mock.patch(\u0027nova.compute.manager.LOG.warning\u0027)"},{"line_number":6273,"context_line":"    def test_try_deallocate_network_retry_direct(self, warning_mock,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_b7197bd3","line":6270,"in_reply_to":"5f7c97a3_b7c17b52","updated":"2018-08-02 19:52:04.000000000","message":"Since I\u0027m not going to use the mock, I use `new` to make it not create a param to the decorated method.\n\nMock vs MagicMock doesn\u0027t make a difference in this case. The latter only differs in that it has defaults for magic methods, which only matters when you\u0027re mocking a type (and even then only sometimes).","commit_id":"7b42be7893e324908005a5fcd827a9b186e04094"}]}