)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"08b480019048735f4c3c7c5205a04f3505a82003","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Pass allocations to virt drivers when resizing"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some features like vGPUs require to have allocations to be checked locally"},{"line_number":10,"context_line":"by the virt driver but resize (and cold migrate) was passing them."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This change just gives the allocations to the target node when the resize"},{"line_number":13,"context_line":"is done by adding the allocations to the finish_migration() interface."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9fb8cfa7_71b1b1e1","line":10,"range":{"start_line":10,"start_character":49,"end_line":10,"end_character":52},"updated":"2019-06-03 18:50:30.000000000","message":"was not?","commit_id":"f727d69081fdb7c86b01541e8e337d1c5e85fb0f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"08b480019048735f4c3c7c5205a04f3505a82003","unresolved":false,"context_lines":[{"line_number":12,"context_line":"This change just gives the allocations to the target node when the resize"},{"line_number":13,"context_line":"is done by adding the allocations to the finish_migration() interface."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Related-Bug: #1778563"},{"line_number":16,"context_line":"Change-Id: Ifd76289964d513e9544544e5787f5f8999589475"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9fb8cfa7_f1f2819a","line":15,"updated":"2019-06-03 18:50:30.000000000","message":"So I guess this is just plumbing and you\u0027ll handle the libvirt and xenapi specific driver changes in another patch?\n\nWhen you do, or at some point, we should update the caveats section in the docs about this:\n\nhttps://docs.openstack.org/nova/latest/admin/virtual-gpu.html#caveats","commit_id":"f727d69081fdb7c86b01541e8e337d1c5e85fb0f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3bb4c1bc400f11575804ae5eb664d6d02025c28a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"This change just gives the allocations to the target node when the resize"},{"line_number":13,"context_line":"is done by adding the allocations to the finish_migration() interface."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Related-Bug: #1778563"},{"line_number":16,"context_line":"Change-Id: Ifd76289964d513e9544544e5787f5f8999589475"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9fb8cfa7_b85ff73f","line":15,"in_reply_to":"9fb8cfa7_f1f2819a","updated":"2019-06-04 15:33:31.000000000","message":"Correct, a next change will use those allocations for the resize.\nWe will also have another change for the resize revert migration once Zuul is +1 with this change :-)","commit_id":"f727d69081fdb7c86b01541e8e337d1c5e85fb0f"}],"nova/compute/manager.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3442a14c9815cd0de75f93632d5417e7f4f916d9","unresolved":false,"context_lines":[{"line_number":4672,"context_line":"        # the migration UUID while the target allocation (for the destination"},{"line_number":4673,"context_line":"        # node) is related to the instance UUID, so here we need to pass the"},{"line_number":4674,"context_line":"        # new ones."},{"line_number":4675,"context_line":"        allocations \u003d self.reportclient.get_allocations_for_consumer("},{"line_number":4676,"context_line":"            context, instance.uuid)"},{"line_number":4677,"context_line":""},{"line_number":4678,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_9531305d","line":4675,"updated":"2019-05-13 15:02:50.000000000","message":"As per the comment top of the definition \nof the get_allocations_for_consumer function the reportclient.get_allocs_for_consumer() call should be used instead.","commit_id":"cd9285937f4f5fc7b7f27a08b06fdc1a0dc17c25"}],"nova/tests/unit/compute/test_shelve.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5bc673334468166af46480c87e480fb34ed5b12e","unresolved":false,"context_lines":[{"line_number":369,"context_line":"                test.MatchType(objects.ImageMeta), injected_files\u003d[],"},{"line_number":370,"context_line":"                admin_password\u003dNone, allocations\u003d{}, network_info\u003d[],"},{"line_number":371,"context_line":"                block_device_info\u003d\u0027fake_bdm\u0027)"},{"line_number":372,"context_line":"        self.mock_get_allocations.assert_called_once_with(self.context,"},{"line_number":373,"context_line":"                                                          instance.uuid)"},{"line_number":374,"context_line":"        mock_get_power_state.assert_called_once_with(self.context, instance)"},{"line_number":375,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_d992f8ac","line":372,"range":{"start_line":372,"start_character":13,"end_line":372,"end_character":33},"updated":"2020-02-19 11:45:58.000000000","message":"Weird. What changed?\n\nLater: ah, we changed the base class [1]\n\n[1] https://review.opendev.org/#/c/589085/6/nova/tests/unit/compute/test_compute.py","commit_id":"edb13bac602b250b986d0e47dca1b7057f754924"}],"nova/virt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"08b480019048735f4c3c7c5205a04f3505a82003","unresolved":false,"context_lines":[{"line_number":685,"context_line":"        \"\"\""},{"line_number":686,"context_line":"        pass"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"    def finish_migration(self, context, migration, instance, disk_info,"},{"line_number":689,"context_line":"                         network_info, image_meta, resize_instance,"},{"line_number":690,"context_line":"                         allocations, block_device_info\u003dNone, power_on\u003dTrue):"},{"line_number":691,"context_line":"        \"\"\"Completes a resize/migration."}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_d10add88","line":688,"range":{"start_line":688,"start_character":8,"end_line":688,"end_character":24},"updated":"2019-06-03 18:50:30.000000000","message":"Should probably have a courtesy email to the ML for out of tree drivers about this interface change.","commit_id":"f727d69081fdb7c86b01541e8e337d1c5e85fb0f"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"46ea901b5860684b5740c33ecbbb51a917ae160a","unresolved":false,"context_lines":[{"line_number":685,"context_line":"        \"\"\""},{"line_number":686,"context_line":"        pass"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"    def finish_migration(self, context, migration, instance, disk_info,"},{"line_number":689,"context_line":"                         network_info, image_meta, resize_instance,"},{"line_number":690,"context_line":"                         allocations, block_device_info\u003dNone, power_on\u003dTrue):"},{"line_number":691,"context_line":"        \"\"\"Completes a resize/migration."}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_713a0335","line":688,"range":{"start_line":688,"start_character":8,"end_line":688,"end_character":24},"in_reply_to":"9fb8cfa7_184ba384","updated":"2019-07-23 22:43:00.000000000","message":"Do this and I\u0027m +2.","commit_id":"f727d69081fdb7c86b01541e8e337d1c5e85fb0f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3bb4c1bc400f11575804ae5eb664d6d02025c28a","unresolved":false,"context_lines":[{"line_number":685,"context_line":"        \"\"\""},{"line_number":686,"context_line":"        pass"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"    def finish_migration(self, context, migration, instance, disk_info,"},{"line_number":689,"context_line":"                         network_info, image_meta, resize_instance,"},{"line_number":690,"context_line":"                         allocations, block_device_info\u003dNone, power_on\u003dTrue):"},{"line_number":691,"context_line":"        \"\"\"Completes a resize/migration."}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_184ba384","line":688,"range":{"start_line":688,"start_character":8,"end_line":688,"end_character":24},"in_reply_to":"9fb8cfa7_d10add88","updated":"2019-06-04 15:33:31.000000000","message":"Yup, good point","commit_id":"f727d69081fdb7c86b01541e8e337d1c5e85fb0f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"08b480019048735f4c3c7c5205a04f3505a82003","unresolved":false,"context_lines":[{"line_number":701,"context_line":"                                False otherwise"},{"line_number":702,"context_line":"        :param allocations: Information about resources allocated to the"},{"line_number":703,"context_line":"                            instance via placement, of the form returned by"},{"line_number":704,"context_line":"                            SchedulerReportClient.get_allocations_for_consumer."},{"line_number":705,"context_line":"        :param block_device_info: instance volume block device info"},{"line_number":706,"context_line":"        :param power_on: True if the instance should be powered on, False"},{"line_number":707,"context_line":"                         otherwise"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_b105e97c","line":704,"range":{"start_line":704,"start_character":50,"end_line":704,"end_character":78},"updated":"2019-06-03 18:50:30.000000000","message":"get_allocs_for_consumer","commit_id":"f727d69081fdb7c86b01541e8e337d1c5e85fb0f"}]}