)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"1a48ee3380a319d45cc5bbcb74b3397bc628bc2f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Haomai Wang \u003chaomai@unitedstack.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-02 23:16:28 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix rbd backend not working for none admin ceph user"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If user make use of non-admin ceph user as \u0027rbd_user\u0027, it can\u0027t work with list"},{"line_number":10,"context_line":"and remove rbd functions. It lack of necessary arguments \"--id\" and \"--conf\" to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2BGjI%3D","line":7,"updated":"2013-12-02 15:29:51.000000000","message":"This reads poorly - can you rephrase it ?","commit_id":"639137152fe3114cb4a8886917f2bd2e224c6c48"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"5efbaa40b7298f2be1b8bc3ab0433a4d4bc3c3cf","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If user make use of non-admin ceph user as \u0027rbd_user\u0027 option,"},{"line_number":10,"context_line":"it can\u0027t work with list and remove rbd functions. For example, now nova"},{"line_number":11,"context_line":"only worked well with \u0027admin\u0027 defined in \u0027rbd_user\u0027. It lack of necessary"},{"line_number":12,"context_line":"arguments \"--id\" and \"--conf\" to specify user and config path."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Id99aa303791143360ad78074184583048e4878f0"},{"line_number":15,"context_line":"Closes-Bug: #1255536"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAATn%2F9b1g%3D","line":12,"updated":"2013-12-11 15:02:55.000000000","message":"This commit message could do with a DocImpact flag explaining to the tech writers what needs to be updated in the docs. Something like:\n\nDocImpact: rbd users no longer need to have admin rights.","commit_id":"b61a513e3fdd506b0215dd712d39e5b432aac0b3"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"e73514f829418b537d5aac829b790a82d079c542","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If user make use of non-admin ceph user as \u0027rbd_user\u0027 option,"},{"line_number":10,"context_line":"it can\u0027t work with list and remove rbd functions. For example, now nova"},{"line_number":11,"context_line":"only worked well with \u0027admin\u0027 defined in \u0027rbd_user\u0027. It lack of necessary"},{"line_number":12,"context_line":"arguments \"--id\" and \"--conf\" to specify user and config path."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Id99aa303791143360ad78074184583048e4878f0"},{"line_number":15,"context_line":"Closes-Bug: #1255536"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAATn%2F9G2M%3D","line":12,"updated":"2013-12-16 18:33:32.000000000","message":"This description doesn\u0027t really read very clearly. I think it would be better written as\n\n  \"The \u0027rbd_user\u0027 option allows nova administrators to override the default user account \nused for RBD operations, with one that has potentially lower privileges.  Not all parts \nof the Nova code honoured the \u0027rbd_user\u0027 option, which resulted in failures when \nattempting to use a lesser privileged user for RBD. This fix ensures the \u0027--id\u0027 and \n\u0027--config\u0027 parameters are passed to the RBD command line tools in all cases\"","commit_id":"b61a513e3fdd506b0215dd712d39e5b432aac0b3"},{"author":{"_account_id":7593,"name":"Haomai Wang","email":"haomaiwang@gmail.com","username":"HaomaiWang"},"change_message_id":"f082fc9d57432c9445813a5f0c134dc289a3f8ca","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If user make use of non-admin ceph user as \u0027rbd_user\u0027 option,"},{"line_number":10,"context_line":"it can\u0027t work with list and remove rbd functions. For example, now nova"},{"line_number":11,"context_line":"only worked well with \u0027admin\u0027 defined in \u0027rbd_user\u0027. It lack of necessary"},{"line_number":12,"context_line":"arguments \"--id\" and \"--conf\" to specify user and config path."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Id99aa303791143360ad78074184583048e4878f0"},{"line_number":15,"context_line":"Closes-Bug: #1255536"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAATn%2F9D6k%3D","line":12,"in_reply_to":"AAAATn%2F9G2M%3D","updated":"2013-12-17 06:45:39.000000000","message":"Thanks!","commit_id":"b61a513e3fdd506b0215dd712d39e5b432aac0b3"}],"nova/tests/virt/libvirt/test_libvirt_utils.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"ce29715bf0dcdaf80c923d4b96d3812f612237c4","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        user \u003d \u0027user\u0027"},{"line_number":61,"context_line":"        self.flags(images_rbd_ceph_conf\u003dconf, group\u003d\u0027libvirt\u0027)"},{"line_number":62,"context_line":"        self.flags(rbd_user\u003duser, group\u003d\u0027libvirt\u0027)"},{"line_number":63,"context_line":"        fn \u003d self.mox.CreateMockAnything()"},{"line_number":64,"context_line":"        self.mox.StubOutWithMock(libvirt_utils.utils,"},{"line_number":65,"context_line":"                                 \u0027execute\u0027)"},{"line_number":66,"context_line":"        libvirt_utils.utils.execute(\u0027rbd\u0027, \u0027-p\u0027, pool, \u0027ls\u0027, \u0027--id\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2FkeA%3D","line":63,"updated":"2014-01-10 22:40:29.000000000","message":"I\u0027d encourage you to use mock for new tests…","commit_id":"4afc6d78d9264f6449dfe012f8da1fffb718bec2"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7219a7873802553e07634a47087d8caae85bc2b1","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        user \u003d \u0027user\u0027"},{"line_number":61,"context_line":"        self.flags(images_rbd_ceph_conf\u003dconf, group\u003d\u0027libvirt\u0027)"},{"line_number":62,"context_line":"        self.flags(rbd_user\u003duser, group\u003d\u0027libvirt\u0027)"},{"line_number":63,"context_line":"        fn \u003d self.mox.CreateMockAnything()"},{"line_number":64,"context_line":"        self.mox.StubOutWithMock(libvirt_utils.utils,"},{"line_number":65,"context_line":"                                 \u0027execute\u0027)"},{"line_number":66,"context_line":"        libvirt_utils.utils.execute(\u0027rbd\u0027, \u0027-p\u0027, pool, \u0027ls\u0027, \u0027--id\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2B7Rw%3D","line":63,"updated":"2014-01-20 17:33:14.000000000","message":"Again, I\u0027d encourage you to use mock for new tests…","commit_id":"7104a6d8b1885f04d3012d621ec14f4be5145994"}],"nova/virt/libvirt/imagebackend.py":[{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"ae676c04b8165a866215d9415978a6a70c198678","unresolved":false,"context_lines":[{"line_number":504,"context_line":"        args \u003d []"},{"line_number":505,"context_line":"        if self.rbd_user:"},{"line_number":506,"context_line":"            args.extend([\u0027--id\u0027, self.rbd_user])"},{"line_number":507,"context_line":"        if self.ceph_conf:"},{"line_number":508,"context_line":"            args.extend([\u0027--conf\u0027, self.ceph_conf])"},{"line_number":509,"context_line":"        return args"},{"line_number":510,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BGxU%3D","line":507,"updated":"2013-12-02 15:06:22.000000000","message":"Same, the name should be images_rbd_ceph_conf","commit_id":"a93e1fd2d9f92471fdf5e83d675496ea30ed1a8f"},{"author":{"_account_id":7593,"name":"Haomai Wang","email":"haomaiwang@gmail.com","username":"HaomaiWang"},"change_message_id":"542615c9d3accde478f30b3d25527db968b5c2fe","unresolved":false,"context_lines":[{"line_number":473,"context_line":"            raise RuntimeError(_(\u0027You should specify\u0027"},{"line_number":474,"context_line":"                                 \u0027 images_rbd_pool\u0027"},{"line_number":475,"context_line":"                                 \u0027 flag to use rbd images.\u0027))"},{"line_number":476,"context_line":"        self.pool \u003d CONF.libvirt.images_rbd_pool"},{"line_number":477,"context_line":"        self.ceph_conf \u003d ascii_str(CONF.libvirt.images_rbd_ceph_conf)"},{"line_number":478,"context_line":"        self.rbd_user \u003d ascii_str(CONF.rbd_user)"},{"line_number":479,"context_line":"        self.rbd \u003d kwargs.get(\u0027rbd\u0027, rbd)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BGn4%3D","line":476,"updated":"2013-12-02 15:22:37.000000000","message":"see here. :)","commit_id":"639137152fe3114cb4a8886917f2bd2e224c6c48"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"55cda1e3556bf5fb234cf2307620dc885c192355","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        if self.rbd_user:"},{"line_number":506,"context_line":"            args.extend([\u0027--id\u0027, self.rbd_user])"},{"line_number":507,"context_line":"        if self.ceph_conf:"},{"line_number":508,"context_line":"            args.extend([\u0027--conf\u0027, self.ceph_conf])"},{"line_number":509,"context_line":"        return args"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def _get_mon_addrs(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BGps%3D","line":508,"updated":"2013-12-02 15:19:18.000000000","message":"You forgot this one :)\n\nimages_rbd_ceph_conf","commit_id":"639137152fe3114cb4a8886917f2bd2e224c6c48"},{"author":{"_account_id":7593,"name":"Haomai Wang","email":"haomaiwang@gmail.com","username":"HaomaiWang"},"change_message_id":"70e1055f64efb6e5666658575b909204fefca516","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        if self.rbd_user:"},{"line_number":506,"context_line":"            args.extend([\u0027--id\u0027, self.rbd_user])"},{"line_number":507,"context_line":"        if self.ceph_conf:"},{"line_number":508,"context_line":"            args.extend([\u0027--conf\u0027, self.ceph_conf])"},{"line_number":509,"context_line":"        return args"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def _get_mon_addrs(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F99E8%3D","line":508,"in_reply_to":"AAAATn%2F%2BGmY%3D","updated":"2013-12-04 02:25:30.000000000","message":"Sorry....I can\u0027t understand. Why should I rename \"self.ceph_conf\" to \"CONF.libvirt.images_rbd_ceph_conf\"?","commit_id":"639137152fe3114cb4a8886917f2bd2e224c6c48"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"3b6e803e51b1a87b683c7e8b5a3af40814df7a18","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        if self.rbd_user:"},{"line_number":506,"context_line":"            args.extend([\u0027--id\u0027, self.rbd_user])"},{"line_number":507,"context_line":"        if self.ceph_conf:"},{"line_number":508,"context_line":"            args.extend([\u0027--conf\u0027, self.ceph_conf])"},{"line_number":509,"context_line":"        return args"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def _get_mon_addrs(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BGmY%3D","line":508,"in_reply_to":"AAAATn%2F%2BGn8%3D","updated":"2013-12-02 15:28:03.000000000","message":"Oops sorry. But then you should rename it images_rbd_ceph_conf :).","commit_id":"639137152fe3114cb4a8886917f2bd2e224c6c48"},{"author":{"_account_id":7593,"name":"Haomai Wang","email":"haomaiwang@gmail.com","username":"HaomaiWang"},"change_message_id":"542615c9d3accde478f30b3d25527db968b5c2fe","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        if self.rbd_user:"},{"line_number":506,"context_line":"            args.extend([\u0027--id\u0027, self.rbd_user])"},{"line_number":507,"context_line":"        if self.ceph_conf:"},{"line_number":508,"context_line":"            args.extend([\u0027--conf\u0027, self.ceph_conf])"},{"line_number":509,"context_line":"        return args"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def _get_mon_addrs(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BGn8%3D","line":508,"in_reply_to":"AAAATn%2F%2BGps%3D","updated":"2013-12-02 15:22:37.000000000","message":"Hi han,\nline 477 already define it. ---","commit_id":"639137152fe3114cb4a8886917f2bd2e224c6c48"}],"nova/virt/libvirt/utils.py":[{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"ae676c04b8165a866215d9415978a6a70c198678","unresolved":false,"context_lines":[{"line_number":273,"context_line":"    args \u003d []"},{"line_number":274,"context_line":"    if CONF.rbd_user:"},{"line_number":275,"context_line":"        args.extend([\u0027--id\u0027, str(CONF.rbd_user)])"},{"line_number":276,"context_line":"    if CONF.ceph_conf:"},{"line_number":277,"context_line":"        args.extend([\u0027--conf\u0027, str(CONF.ceph_conf)])"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    out, err \u003d utils.execute(\u0027rbd\u0027, \u0027-p\u0027, pool, \u0027ls\u0027, \u0027--id\u0027, *args)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BGyQ%3D","line":276,"updated":"2013-12-02 15:06:22.000000000","message":"This should be \"images_rbd_ceph_conf\".\nNames changed, please see https://github.com/openstack/nova/commit/e6f737bae7be9db6188def295af9ba53205d743e\n\nSame for all ceph_conf statements.","commit_id":"a93e1fd2d9f92471fdf5e83d675496ea30ed1a8f"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"ae676c04b8165a866215d9415978a6a70c198678","unresolved":false,"context_lines":[{"line_number":276,"context_line":"    if CONF.ceph_conf:"},{"line_number":277,"context_line":"        args.extend([\u0027--conf\u0027, str(CONF.ceph_conf)])"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    out, err \u003d utils.execute(\u0027rbd\u0027, \u0027-p\u0027, pool, \u0027ls\u0027, \u0027--id\u0027, *args)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    return [line.strip() for line in out.splitlines()]"},{"line_number":282,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BGx4%3D","line":279,"updated":"2013-12-02 15:06:22.000000000","message":"You already have --id from the args, duplicate option.\n\nrbd: extraneous parameter nova","commit_id":"a93e1fd2d9f92471fdf5e83d675496ea30ed1a8f"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"3b6e803e51b1a87b683c7e8b5a3af40814df7a18","unresolved":false,"context_lines":[{"line_number":273,"context_line":"    args \u003d []"},{"line_number":274,"context_line":"    if CONF.rbd_user:"},{"line_number":275,"context_line":"        args.extend([\u0027--id\u0027, str(CONF.rbd_user)])"},{"line_number":276,"context_line":"    if CONF.ceph_conf:"},{"line_number":277,"context_line":"        args.extend([\u0027--conf\u0027, str(CONF.images_rbd_ceph_conf)])"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    out, err \u003d utils.execute(\u0027rbd\u0027, \u0027-p\u0027, pool, \u0027ls\u0027, *args)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BGkw%3D","line":276,"updated":"2013-12-02 15:28:03.000000000","message":"this one needs to updated too.","commit_id":"639137152fe3114cb4a8886917f2bd2e224c6c48"},{"author":{"_account_id":8810,"name":"Francisco Demontiê dos Santos Junior","email":"demontie@lsd.ufcg.edu.br","username":"demontiejr"},"change_message_id":"543aeaebb4061f1831151178f496a43fad359b3d","unresolved":false,"context_lines":[{"line_number":284,"context_line":"def remove_rbd_volumes(pool, *names):"},{"line_number":285,"context_line":"    \"\"\"Remove one or more rbd volume.\"\"\""},{"line_number":286,"context_line":"    args \u003d []"},{"line_number":287,"context_line":"    if CONF.libvirt.rbd_user:"},{"line_number":288,"context_line":"        args.extend([\u0027--id\u0027, str(CONF.libvirt.rbd_user)])"},{"line_number":289,"context_line":"    if CONF.libvirt.images_rbd_ceph_conf:"},{"line_number":290,"context_line":"        args.extend([\u0027--conf\u0027, str(CONF.libvirt.images_rbd_ceph_conf)])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9PLs%3D","line":287,"updated":"2013-12-13 16:56:56.000000000","message":"Why do not put the ifs in the loop? I think would be better do something like:\n\nfor name in names:\n    rbd_remove \u003d [\u0027rbd\u0027, \u0027-p\u0027, pool, \u0027rm\u0027, name]\n    if CONF.libvirt.rbd_user:\n        rbd_remove.extend([\u0027--id\u0027, str(CONF.libvirt.rbd_user)])\n    ...","commit_id":"b61a513e3fdd506b0215dd712d39e5b432aac0b3"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"e73514f829418b537d5aac829b790a82d079c542","unresolved":false,"context_lines":[{"line_number":288,"context_line":"        args.extend([\u0027--id\u0027, str(CONF.libvirt.rbd_user)])"},{"line_number":289,"context_line":"    if CONF.libvirt.images_rbd_ceph_conf:"},{"line_number":290,"context_line":"        args.extend([\u0027--conf\u0027, str(CONF.libvirt.images_rbd_ceph_conf)])"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    for name in names:"},{"line_number":293,"context_line":"        rbd_remove \u003d [\u0027rbd\u0027, \u0027-p\u0027, pool, \u0027rm\u0027, name]"},{"line_number":294,"context_line":"        rbd_remove.extend(args)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9G3o%3D","line":291,"updated":"2013-12-16 18:33:32.000000000","message":"Rather than duplicating this logic in multiple places it\u0027d be better to introduce a shared helper eg\n\n def _run_rbd(args)\n    ....add --id and --conf...\n\nand just have list_rbd_volumes and remove_rbd_volumes call this same helper. That way the username/config only need to be dealt with in one place","commit_id":"b61a513e3fdd506b0215dd712d39e5b432aac0b3"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"ed2b053f8e361011e77bc70bdee9afb69deffbf2","unresolved":false,"context_lines":[{"line_number":289,"context_line":"def remove_rbd_volumes(pool, *names):"},{"line_number":290,"context_line":"    \"\"\"Remove one or more rbd volume.\"\"\""},{"line_number":291,"context_line":"    args \u003d []"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    for name in names:"},{"line_number":294,"context_line":"        rbd_remove \u003d [\u0027rbd\u0027, \u0027-p\u0027, pool, \u0027rm\u0027, name]"},{"line_number":295,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F9DIE%3D","line":292,"updated":"2013-12-17 10:00:31.000000000","message":"This variable is unused now.","commit_id":"ecd61ebb9af5e487a15117650b560b95a916fac8"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"ce29715bf0dcdaf80c923d4b96d3812f612237c4","unresolved":false,"context_lines":[{"line_number":293,"context_line":"def remove_rbd_volumes(pool, *names):"},{"line_number":294,"context_line":"    \"\"\"Remove one or more rbd volume.\"\"\""},{"line_number":295,"context_line":"    for name in names:"},{"line_number":296,"context_line":"        rbd_remove \u003d [\u0027rbd\u0027, \u0027-p\u0027, pool, \u0027rm\u0027, name]"},{"line_number":297,"context_line":"        try:"},{"line_number":298,"context_line":"            _run_rbd(*rbd_remove, attempts\u003d3, run_as_root\u003dTrue)"},{"line_number":299,"context_line":"        except processutils.ProcessExecutionError:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2FkdU%3D","line":296,"updated":"2014-01-10 22:40:29.000000000","message":"The change from tuple to list shouldn\u0027t have any effect here…","commit_id":"4afc6d78d9264f6449dfe012f8da1fffb718bec2"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"7219a7873802553e07634a47087d8caae85bc2b1","unresolved":false,"context_lines":[{"line_number":293,"context_line":"def remove_rbd_volumes(pool, *names):"},{"line_number":294,"context_line":"    \"\"\"Remove one or more rbd volume.\"\"\""},{"line_number":295,"context_line":"    for name in names:"},{"line_number":296,"context_line":"        rbd_remove \u003d [\u0027rbd\u0027, \u0027-p\u0027, pool, \u0027rm\u0027, name]"},{"line_number":297,"context_line":"        try:"},{"line_number":298,"context_line":"            _run_rbd(*rbd_remove, attempts\u003d3, run_as_root\u003dTrue)"},{"line_number":299,"context_line":"        except processutils.ProcessExecutionError:"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2B7RE%3D","line":296,"updated":"2014-01-20 17:33:14.000000000","message":"I don\u0027t see any reason to switch from a tuple to a list here; it will have no effect whatsoever on this function…","commit_id":"7104a6d8b1885f04d3012d621ec14f4be5145994"}],"nova/virt/libvirt/volume.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"016e968592bd246d6248359ee0b153772fdaaca9","unresolved":false,"context_lines":[{"line_number":52,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027rbd_user\u0027,"},{"line_number":54,"context_line":"               help\u003d\u0027the RADOS client name for accessing rbd volumes\u0027,"},{"line_number":55,"context_line":"               default\u003dNone,"},{"line_number":56,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":57,"context_line":"    cfg.StrOpt(\u0027rbd_secret_uuid\u0027,"},{"line_number":58,"context_line":"               help\u003d\u0027the libvirt uuid of the secret for the rbd_user\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9CPM%3D","line":55,"updated":"2013-12-17 13:25:24.000000000","message":"this is the default value. You do not need this to be set as None","commit_id":"5208a67ae34648db3214d20dbc5eaf238d1cf3ea"}]}