)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"44c8cd84109ecc2debbfcc8a595cca39661b6aa6","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2018-08-08 17:14:53 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Skip CPU comparison in Aarch64"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-bug: #1756118"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I0ef4b954b7f4ae65b6c0f96580c5f9472a2b873c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_18f03cc9","line":8,"updated":"2019-10-09 08:39:46.000000000","message":"I would also expand the commit message with the background and the reason why we\u0027re doing; a variant of text from my previous comment can be used here too.","commit_id":"f5a3af100c1c91a9937a42573cd07298811e9142"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"5095e3e70088e8f761716822de29de9403af4922","unresolved":false,"context_lines":[{"line_number":6888,"context_line":"            ret \u003d self._host.compare_cpu(cpu_xml)"},{"line_number":6889,"context_line":"        except libvirt.libvirtError as e:"},{"line_number":6890,"context_line":"            if cpu.arch \u003d\u003d fields.Architecture.AARCH64:"},{"line_number":6891,"context_line":"                LOG.debug(\"Libvirt doesn\u0027t know how to detect the host CPU \""},{"line_number":6892,"context_line":"                          \"model on AArch64. Skipping CPU comparison\")"},{"line_number":6893,"context_line":"                return"},{"line_number":6894,"context_line":"            error_code \u003d e.get_error_code()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_271b9d81","line":6891,"range":{"start_line":6891,"start_character":35,"end_line":6891,"end_character":47},"updated":"2018-08-09 11:30:51.000000000","message":"maybe say something like \u0027xxx is not supported\u0027 etc is better?","commit_id":"f5a3af100c1c91a9937a42573cd07298811e9142"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"101517037cdb047c39b2c4dc5325ebaddb34c130","unresolved":false,"context_lines":[{"line_number":6888,"context_line":"            ret \u003d self._host.compare_cpu(cpu_xml)"},{"line_number":6889,"context_line":"        except libvirt.libvirtError as e:"},{"line_number":6890,"context_line":"            if cpu.arch \u003d\u003d fields.Architecture.AARCH64:"},{"line_number":6891,"context_line":"                LOG.debug(\"Libvirt doesn\u0027t know how to detect the host CPU \""},{"line_number":6892,"context_line":"                          \"model on AArch64. Skipping CPU comparison\")"},{"line_number":6893,"context_line":"                return"},{"line_number":6894,"context_line":"            error_code \u003d e.get_error_code()"},{"line_number":6895,"context_line":"            if error_code \u003d\u003d libvirt.VIR_ERR_NO_SUPPORT:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_f878c08f","line":6892,"range":{"start_line":6891,"start_character":27,"end_line":6892,"end_character":69},"updated":"2019-10-09 08:37:22.000000000","message":"I\u0027d rephrase the error message, because of the following.  (Maybe even add it as a NOTE.)\n\nIt is true that libvirt does not know how to detect host CPU model on AArch64, but even if it _wants_ to know, it cannot, because even the `/proc/cpuinfo` on AArch64 doesn\u0027t show anything interesting.  There are lots of vendors making different AArch64 CPUs, and they are not easily comparable.  They all differ in various ways.  (This is also confirmed by Jiri Denemark of libvirt.)\n\nSo it doesn\u0027t make sense to do CPU compatability check on AArch64.  And the AArch64 folks themselves recommend that the way to run KVM guests on AArch64 is via \u0027host-passthrough\u0027.\n\nSo with that in mind, I\u0027d suggest something like:\n\n  \"Host CPU compatibility check does not make \n   sense on AArch64; skip CPU comparison\"","commit_id":"f5a3af100c1c91a9937a42573cd07298811e9142"}]}