)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"af1dc43a4f6753a7f0f3f2ca6843356ae47cb124","unresolved":false,"context_lines":[{"line_number":3046,"context_line":"            # with @base_api.refresh_cache and then we wouldn\u0027t need this"},{"line_number":3047,"context_line":"            # explicit call to get_instance_nw_info."},{"line_number":3048,"context_line":"            network_info \u003d self.network_api.get_instance_nw_info(context,"},{"line_number":3049,"context_line":"                                                                 instance)"},{"line_number":3050,"context_line":"        else:"},{"line_number":3051,"context_line":"            network_info \u003d instance.get_network_info()"},{"line_number":3052,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_510a0f8a","line":3049,"updated":"2018-08-09 14:45:37.000000000","message":"It seems like the best thing to do here would be to stick this on the instance and save it right away. I was thinking that the save on L3109 would do that, but at this point at least, we haven\u0027t actually set it on the instance. That may happen somewhere in between, which may be in driver.rebuild(), which may mean it differs for each driver.\n\nSince we\u0027re taking the hit to call neutron here, seems like we might as well save the info we got with the instance explicitly to avoid either needing to do it again, or making it through this without saving the updated info_cache.\n\nAm I missing something?","commit_id":"559de0d0a3df92ef9dca21edfaa754a2848013c3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1b828d474b15cb0ef6b3040e1769a54c14a2e03c","unresolved":false,"context_lines":[{"line_number":3046,"context_line":"            # with @base_api.refresh_cache and then we wouldn\u0027t need this"},{"line_number":3047,"context_line":"            # explicit call to get_instance_nw_info."},{"line_number":3048,"context_line":"            network_info \u003d self.network_api.get_instance_nw_info(context,"},{"line_number":3049,"context_line":"                                                                 instance)"},{"line_number":3050,"context_line":"        else:"},{"line_number":3051,"context_line":"            network_info \u003d instance.get_network_info()"},{"line_number":3052,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_72314aec","line":3049,"in_reply_to":"3f79a3b5_510a0f8a","updated":"2018-08-09 15:25:58.000000000","message":"get_instance_nw_info refreshes the cache:\n\nhttps://github.com/openstack/nova/blob/93888df0da6adfa0c5f448692e5a480364dbe675/nova/network/base_api.py#L255\n\nhttps://github.com/openstack/nova/blob/93888df0da6adfa0c5f448692e5a480364dbe675/nova/network/base_api.py#L55","commit_id":"559de0d0a3df92ef9dca21edfaa754a2848013c3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ec26e93de3d8ed9d5927d353c80a9438c53b24a0","unresolved":false,"context_lines":[{"line_number":3046,"context_line":"            # with @base_api.refresh_cache and then we wouldn\u0027t need this"},{"line_number":3047,"context_line":"            # explicit call to get_instance_nw_info."},{"line_number":3048,"context_line":"            network_info \u003d self.network_api.get_instance_nw_info(context,"},{"line_number":3049,"context_line":"                                                                 instance)"},{"line_number":3050,"context_line":"        else:"},{"line_number":3051,"context_line":"            network_info \u003d instance.get_network_info()"},{"line_number":3052,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b2f4c2d0","line":3049,"in_reply_to":"3f79a3b5_72314aec","updated":"2018-08-09 15:32:49.000000000","message":"Ah right okay.","commit_id":"559de0d0a3df92ef9dca21edfaa754a2848013c3"}]}