)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"62848a00d3a268bebd70daa78ab14ba372880102","unresolved":false,"context_lines":[{"line_number":2510,"context_line":"                    self.volume_api.terminate_connection(context,"},{"line_number":2511,"context_line":"                                                         bdm.volume_id,"},{"line_number":2512,"context_line":"                                                         connector)"},{"line_number":2513,"context_line":"                    self.volume_api.detach(context, bdm.volume_id,"},{"line_number":2514,"context_line":"                                           instance.uuid)"},{"line_number":2515,"context_line":""},{"line_number":2516,"context_line":"            except exception.VolumeAttachmentNotFound as exc:"},{"line_number":2517,"context_line":"                LOG.debug(\u0027Ignoring VolumeAttachmentNotFound: %s\u0027, exc,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_d1461f22","side":"PARENT","line":2514,"range":{"start_line":2513,"start_character":20,"end_line":2514,"end_character":57},"updated":"2018-08-09 14:38:40.000000000","message":"Umm, don\u0027t you still need this?","commit_id":"7e767e22fd81d897192f45356ab9c9bce475b71b"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"25d2943e7df13634a1d6d718191d8971d282ffe0","unresolved":false,"context_lines":[{"line_number":2510,"context_line":"                    self.volume_api.terminate_connection(context,"},{"line_number":2511,"context_line":"                                                         bdm.volume_id,"},{"line_number":2512,"context_line":"                                                         connector)"},{"line_number":2513,"context_line":"                    self.volume_api.detach(context, bdm.volume_id,"},{"line_number":2514,"context_line":"                                           instance.uuid)"},{"line_number":2515,"context_line":""},{"line_number":2516,"context_line":"            except exception.VolumeAttachmentNotFound as exc:"},{"line_number":2517,"context_line":"                LOG.debug(\u0027Ignoring VolumeAttachmentNotFound: %s\u0027, exc,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_71c62b4b","side":"PARENT","line":2514,"range":{"start_line":2513,"start_character":20,"end_line":2514,"end_character":57},"in_reply_to":"3f79a3b5_11ba57dd","updated":"2018-08-09 14:44:10.000000000","message":"Hmm, I don\u0027t think so, otherwise the volume becomes in-use briefly. We do need to clean this up eventually, though, same as for the v3 case.","commit_id":"7e767e22fd81d897192f45356ab9c9bce475b71b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8105fb3a253b370a4c75277eeea574a95ca35f3d","unresolved":false,"context_lines":[{"line_number":2510,"context_line":"                    self.volume_api.terminate_connection(context,"},{"line_number":2511,"context_line":"                                                         bdm.volume_id,"},{"line_number":2512,"context_line":"                                                         connector)"},{"line_number":2513,"context_line":"                    self.volume_api.detach(context, bdm.volume_id,"},{"line_number":2514,"context_line":"                                           instance.uuid)"},{"line_number":2515,"context_line":""},{"line_number":2516,"context_line":"            except exception.VolumeAttachmentNotFound as exc:"},{"line_number":2517,"context_line":"                LOG.debug(\u0027Ignoring VolumeAttachmentNotFound: %s\u0027, exc,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b1fa8372","side":"PARENT","line":2514,"range":{"start_line":2513,"start_character":20,"end_line":2514,"end_character":57},"in_reply_to":"3f79a3b5_71c62b4b","updated":"2018-08-09 14:46:01.000000000","message":"I know, and noted that in the other change (in detail):\n\nhttps://review.openstack.org/#/c/587071/3/nova/compute/manager.py@1631\n\nBut that\u0027s not something we should do for a backportable fix.","commit_id":"7e767e22fd81d897192f45356ab9c9bce475b71b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"eee32ebf95b25b0821bbeaffd303de6f0237f4f5","unresolved":false,"context_lines":[{"line_number":2510,"context_line":"                    self.volume_api.terminate_connection(context,"},{"line_number":2511,"context_line":"                                                         bdm.volume_id,"},{"line_number":2512,"context_line":"                                                         connector)"},{"line_number":2513,"context_line":"                    self.volume_api.detach(context, bdm.volume_id,"},{"line_number":2514,"context_line":"                                           instance.uuid)"},{"line_number":2515,"context_line":""},{"line_number":2516,"context_line":"            except exception.VolumeAttachmentNotFound as exc:"},{"line_number":2517,"context_line":"                LOG.debug(\u0027Ignoring VolumeAttachmentNotFound: %s\u0027, exc,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_11ba57dd","side":"PARENT","line":2514,"range":{"start_line":2513,"start_character":20,"end_line":2514,"end_character":57},"in_reply_to":"3f79a3b5_d1461f22","updated":"2018-08-09 14:40:17.000000000","message":"FYI, all this does is change the volume status to \u0027available\u0027. It\u0027s just a hook to update the volume status, it doesn\u0027t touch the volume backend (that\u0027s what terminate_connection does).","commit_id":"7e767e22fd81d897192f45356ab9c9bce475b71b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"05f2ca6979fbb00f5553b7a9cc4759b0e25ad854","unresolved":false,"context_lines":[{"line_number":1928,"context_line":"                    instance\u003dinstance)"},{"line_number":1929,"context_line":"                self._cleanup_allocated_networks(context, instance,"},{"line_number":1930,"context_line":"                    requested_networks)"},{"line_number":1931,"context_line":"                self._cleanup_volumes(context, instance,"},{"line_number":1932,"context_line":"                    block_device_mapping, raise_exc\u003dFalse)"},{"line_number":1933,"context_line":"                compute_utils.add_instance_fault_from_exc(context,"},{"line_number":1934,"context_line":"                        instance, e, sys.exc_info(),"},{"line_number":1935,"context_line":"                        fault_message\u003de.kwargs[\u0027reason\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_91a8a777","line":1932,"range":{"start_line":1931,"start_character":16,"end_line":1932,"end_character":58},"updated":"2018-08-09 14:43:25.000000000","message":"You\u0027d have to cleanup placement attachments in here if we didn\u0027t reschedule. And you\u0027d need to add something like this to build_instances in conductor if we hit MaxRetriesExceeded (note that conductor already does port cleanup in that case, like that _cleanup_allocated_networks method above).","commit_id":"ccb61d4047c620b68453cd13a3e7f44125f8aa0f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"999fb8a0c13813558767e053e9974e3a8001a979","unresolved":false,"context_lines":[{"line_number":2547,"context_line":"                    LOG.debug(\"Detaching volume: %s\", bdm.volume_id,"},{"line_number":2548,"context_line":"                              instance_uuid\u003dinstance.uuid)"},{"line_number":2549,"context_line":"                    destroy \u003d bdm.delete_on_termination"},{"line_number":2550,"context_line":"                    self._detach_volume(context, bdm, instance,"},{"line_number":2551,"context_line":"                                        destroy_bdm\u003ddestroy)"},{"line_number":2552,"context_line":"                except Exception as exc:"},{"line_number":2553,"context_line":"                    exc_info \u003d sys.exc_info()"},{"line_number":2554,"context_line":"                    LOG.warning(\u0027Failed to detach volume: %(volume_id)s \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_1139f73f","line":2551,"range":{"start_line":2550,"start_character":20,"end_line":2551,"end_character":60},"updated":"2018-08-09 14:50:57.000000000","message":"This might actually delete the attachment associated with the bdm, so maybe you\u0027d be OK. This was a relatively new change.\n\nI8b1c05317734e14ea73dc868941351bb31210bf0","commit_id":"ccb61d4047c620b68453cd13a3e7f44125f8aa0f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"62848a00d3a268bebd70daa78ab14ba372880102","unresolved":false,"context_lines":[{"line_number":4439,"context_line":"                        context, bdm.volume_id, instance.uuid)[\u0027id\u0027]"},{"line_number":4440,"context_line":"                    self.volume_api.attachment_delete(context,"},{"line_number":4441,"context_line":"                                                      bdm.attachment_id)"},{"line_number":4442,"context_line":"                    bdm.attachment_id \u003d attachment_id"},{"line_number":4443,"context_line":"                    bdm.save()"},{"line_number":4444,"context_line":""},{"line_number":4445,"context_line":"                else:"},{"line_number":4446,"context_line":"                    if connector is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_91fe67ac","line":4443,"range":{"start_line":4442,"start_character":20,"end_line":4443,"end_character":30},"updated":"2018-08-09 14:38:40.000000000","message":"So if we exhaust our retries, or aren\u0027t doing retries at all, what is going to clean this up?","commit_id":"ccb61d4047c620b68453cd13a3e7f44125f8aa0f"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"25d2943e7df13634a1d6d718191d8971d282ffe0","unresolved":false,"context_lines":[{"line_number":4439,"context_line":"                        context, bdm.volume_id, instance.uuid)[\u0027id\u0027]"},{"line_number":4440,"context_line":"                    self.volume_api.attachment_delete(context,"},{"line_number":4441,"context_line":"                                                      bdm.attachment_id)"},{"line_number":4442,"context_line":"                    bdm.attachment_id \u003d attachment_id"},{"line_number":4443,"context_line":"                    bdm.save()"},{"line_number":4444,"context_line":""},{"line_number":4445,"context_line":"                else:"},{"line_number":4446,"context_line":"                    if connector is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_71786b29","line":4443,"range":{"start_line":4442,"start_character":20,"end_line":4443,"end_character":30},"in_reply_to":"3f79a3b5_91fe67ac","updated":"2018-08-09 14:44:10.000000000","message":"If this leaks, then it has always leaked for all the reasons that we can fail in compute manager currently which don\u0027t delete volumes.\n\nIOW, if it leaks we need to fix it anyway, regardless of this change.","commit_id":"ccb61d4047c620b68453cd13a3e7f44125f8aa0f"}]}