)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"a0dbf7e4d5e1be7adf8e95275f17b5855b58e0fb","unresolved":false,"context_lines":[{"line_number":11,"context_line":"for scope type enforcement, ignore those warnings."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Note that the same warnings filter in the placement WarningsFixture"},{"line_number":14,"context_line":"is left intact because the deploy code, where we\u0027ve added the"},{"line_number":15,"context_line":"new filter, is not used in the functional tests."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I34e4e550c9c31a654308e555210588156418f9e3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_84204b4a","line":14,"range":{"start_line":14,"start_character":23,"end_line":14,"end_character":38},"updated":"2018-08-10 13:57:16.000000000","message":"This isn\u0027t quite accurate. The deploy code is used. That method which sets the middleware is hit by the fixtures and the functional tests.\n\nWhat\u0027s not hit is the change to wsgi.py which sets the policy conf defaults. Some of your earlier comments suggested that without that conf handling, the warnings filter is not added.\n\nThus the fixture-based warning fixture is still needed.","commit_id":"2967aba0a4a6000d7aeb68d215010c05e9dae544"}],"nova/api/openstack/placement/deploy.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"79446f2704cbb0d44e7e45f8066ee56b956696a7","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        if middleware:"},{"line_number":82,"context_line":"            application \u003d middleware(application)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    # NOTE(mriedem): Ignore scope check UserWarnings from oslo.policy."},{"line_number":85,"context_line":"    if not conf.oslo_policy.enforce_scope:"},{"line_number":86,"context_line":"        import warnings"},{"line_number":87,"context_line":"        warnings.filterwarnings(\u0027ignore\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_06d4581f","line":84,"updated":"2018-08-09 17:41:12.000000000","message":"If this works, we can drop this from the warnings fixture:\n\nhttps://github.com/openstack/nova/blob/93888df0da6adfa0c5f448692e5a480364dbe675/nova/tests/functional/api/openstack/placement/fixtures/capture.py#L72","commit_id":"ba34a3934ca2b477d17a0a8ed1a9124af42fffae"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3c3da995121c663d2852cacef66a7035fb545cd8","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            application \u003d middleware(application)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    # NOTE(mriedem): Ignore scope check UserWarnings from oslo.policy."},{"line_number":85,"context_line":"    if not conf.oslo_policy.enforce_scope:"},{"line_number":86,"context_line":"        import warnings"},{"line_number":87,"context_line":"        warnings.filterwarnings(\u0027ignore\u0027,"},{"line_number":88,"context_line":"                                message\u003d\"Policy .* failed scope check\","}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_2c661553","line":85,"range":{"start_line":85,"start_character":16,"end_line":85,"end_character":27},"updated":"2018-08-09 18:50:48.000000000","message":"Hmm, apparently config isn\u0027t loaded up enough at this point?\n\nhttp://logs.openstack.org/45/590445/2/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/20f54c6/controller/logs/screen-placement-api.txt.gz?level\u003dWARNING#_Aug_09_18_33_35_817468","commit_id":"ba34a3934ca2b477d17a0a8ed1a9124af42fffae"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c207f6de4953ee447ae1c0f63447bb5831c345c5","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        if middleware:"},{"line_number":82,"context_line":"            application \u003d middleware(application)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    # NOTE(mriedem): Ignore scope check UserWarnings from oslo.policy."},{"line_number":85,"context_line":"    if not conf.oslo_policy.enforce_scope:"},{"line_number":86,"context_line":"        import warnings"},{"line_number":87,"context_line":"        warnings.filterwarnings(\u0027ignore\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_47f1eacc","line":84,"updated":"2018-08-09 19:12:20.000000000","message":"I don\u0027t really know if this is the best place for this, cdent would have to direct me.","commit_id":"82f0af8a6d9190b2d611248b08b6a751e772a203"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"da085de42aaed90f018ef186a1bd24c2dd9f8ed5","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    # NOTE(mriedem): Ignore scope check UserWarnings from oslo.policy."},{"line_number":85,"context_line":"    if not conf.oslo_policy.enforce_scope:"},{"line_number":86,"context_line":"        import warnings"},{"line_number":87,"context_line":"        warnings.filterwarnings(\u0027ignore\u0027,"},{"line_number":88,"context_line":"                                message\u003d\"Policy .* failed scope check\","},{"line_number":89,"context_line":"                                category\u003dUserWarning)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_bc357048","line":86,"updated":"2018-08-09 20:29:33.000000000","message":"is there something you\u0027re saving by not just importing warnings in top-level module scope?","commit_id":"82f0af8a6d9190b2d611248b08b6a751e772a203"}],"nova/api/openstack/placement/wsgi.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"2414fce6b0cfcce8b8e23a0bb9f97cc8f5e44fc9","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    # This is needed so we can check [oslo_policy]/enforce_scope in the"},{"line_number":70,"context_line":"    # deploy module."},{"line_number":71,"context_line":"    policy_opts.set_defaults(conf.CONF)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    conf.CONF(argv[1:], project\u003d\u0027nova\u0027, version\u003dversion_info.version_string(),"},{"line_number":74,"context_line":"              default_config_files\u003ddefault_config_files)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_a7723ee2","line":71,"updated":"2018-08-09 19:27:59.000000000","message":"None of this file is called by the functional tests and the fixtures they use, so either:\n\n* they should\n* this line needs to be set somewhere in those fixtures for the conf handling you put in deploy to be prepped\n* the lines in the capture fixture need to come back\n\nThis is related to the issue described in https://bugs.launchpad.net/nova/+bug/1784663\n\nIf you want to do option three and I\u0027ll do 1 or 2 later, that\u0027s cool with me.","commit_id":"82f0af8a6d9190b2d611248b08b6a751e772a203"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a39cf9ed0da7e62df93b6a70522d007391effb51","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    # This is needed so we can check [oslo_policy]/enforce_scope in the"},{"line_number":70,"context_line":"    # deploy module."},{"line_number":71,"context_line":"    policy_opts.set_defaults(conf.CONF)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    conf.CONF(argv[1:], project\u003d\u0027nova\u0027, version\u003dversion_info.version_string(),"},{"line_number":74,"context_line":"              default_config_files\u003ddefault_config_files)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_af5a14f0","line":71,"in_reply_to":"3f79a3b5_a7723ee2","updated":"2018-08-09 20:50:37.000000000","message":"\u003e the lines in the capture fixture need to come back\n\nWill do.","commit_id":"82f0af8a6d9190b2d611248b08b6a751e772a203"}]}