)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"af59132254913aef5b7f6ab44defe3d24dea5cbc","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"As detailed in the bug, this is overly racy, waiting for the event"},{"line_number":12,"context_line":"potentially a long ways (and a couple RPC calls) away from where"},{"line_number":13,"context_line":"the event will be triggered. This is now handled in compute"},{"line_number":14,"context_line":"manager where the event sequencing can be correct, and also which"},{"line_number":15,"context_line":"conflicts with this if enabled."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Conflicts:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_52e0c396","line":14,"range":{"start_line":13,"start_character":29,"end_line":14,"end_character":49},"updated":"2018-08-09 21:56:02.000000000","message":"but only if [compute]/live_migration_wait_for_vif_plug\u003dTrue (which is False by default). Not sure how that should be worked into this, or what the plan is for the original bug - I\u0027m guessing for people that hit the original bug, the answer is with this reverted now, you\u0027ll want to set live_migration_wait_for_vif_plug\u003dTrue - so maybe we need a release note for this? Otherwise people that were relying on that fix in stable and upgrading to rocky will be regressed (assuming the fix was even reliable for them on stable).","commit_id":"2ecffc59e440d63e4f4affca9b868741c7681901"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f5affcfd8101433257bd3dd59da4353daed685f5","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"As detailed in the bug, this is overly racy, waiting for the event"},{"line_number":12,"context_line":"potentially a long ways (and a couple RPC calls) away from where"},{"line_number":13,"context_line":"the event will be triggered. This is now handled in compute"},{"line_number":14,"context_line":"manager where the event sequencing can be correct, and also which"},{"line_number":15,"context_line":"conflicts with this if enabled."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Conflicts:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_2dca8c6c","line":14,"range":{"start_line":13,"start_character":29,"end_line":14,"end_character":49},"in_reply_to":"3f79a3b5_52e0c396","updated":"2018-08-09 22:07:20.000000000","message":"Given we know it\u0027s not reliable, and given we\u0027re adding a reno, I think we\u0027re covered here.","commit_id":"2ecffc59e440d63e4f4affca9b868741c7681901"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"af59132254913aef5b7f6ab44defe3d24dea5cbc","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\tnova/virt/libvirt/driver.py"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ibf2b5eeafd962e93ae4ab6290015d58c33024132"},{"line_number":22,"context_line":"Related-Bug: #1786346"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_72561f5f","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":7},"updated":"2018-08-09 21:56:02.000000000","message":"Closes yeah?","commit_id":"2ecffc59e440d63e4f4affca9b868741c7681901"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"af59132254913aef5b7f6ab44defe3d24dea5cbc","unresolved":false,"context_lines":[{"line_number":11363,"context_line":"    def test_live_migration_main(self, mock_copy_disk_path, mock_running,"},{"line_number":11364,"context_line":"                                 mock_guest, mock_monitor, mock_thread,"},{"line_number":11365,"context_line":"                                 mock_conn):"},{"line_number":11366,"context_line":"        virtapi \u003d manager.ComputeVirtAPI(mock.MagicMock())"},{"line_number":11367,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(virtapi, False)"},{"line_number":11368,"context_line":""},{"line_number":11369,"context_line":"        instance \u003d objects.Instance(**self.test_instance)"},{"line_number":11370,"context_line":"        instance.info_cache \u003d objects.InstanceInfoCache("},{"line_number":11371,"context_line":"            network_info\u003dnetwork_model.NetworkInfo(["},{"line_number":11372,"context_line":"                network_model.VIF(id\u003duuids.vif_1,"},{"line_number":11373,"context_line":"                                  type\u003dnetwork_model.VIF_TYPE_BRIDGE)]))"},{"line_number":11374,"context_line":""},{"line_number":11375,"context_line":"        dom \u003d fakelibvirt.Domain(drvr._get_connection(),"},{"line_number":11376,"context_line":"                                 \"\u003cdomain\u003e\u003cname\u003edemo\u003c/name\u003e\u003c/domain\u003e\", True)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_4d3108ec","line":11373,"range":{"start_line":11366,"start_character":8,"end_line":11373,"end_character":72},"updated":"2018-08-09 21:56:02.000000000","message":"Looks like some of this was added in the patch being reverted and won\u0027t be needed anymore:\n\nhttps://review.openstack.org/#/c/497457/30/nova/tests/unit/virt/libvirt/test_driver.py@10516","commit_id":"2ecffc59e440d63e4f4affca9b868741c7681901"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"af59132254913aef5b7f6ab44defe3d24dea5cbc","unresolved":false,"context_lines":[{"line_number":11381,"context_line":"        mock_copy_disk_path.return_value \u003d disks_to_copy"},{"line_number":11382,"context_line":""},{"line_number":11383,"context_line":"        mock_guest.return_value \u003d guest"},{"line_number":11384,"context_line":"        guest.migrate_configure_max_speed \u003d mock.MagicMock()"},{"line_number":11385,"context_line":""},{"line_number":11386,"context_line":"        generated_events \u003d []"},{"line_number":11387,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_ed281487","line":11384,"range":{"start_line":11384,"start_character":8,"end_line":11384,"end_character":60},"updated":"2018-08-09 21:56:02.000000000","message":"This isn\u0027t needed anymore.\n\nIf we\u0027re removing this stuff, I think it means we can also revert https://review.openstack.org/#/c/497456/ later separately and then we just remove these other the tests when we remove the migrate_configure_max_speed method.","commit_id":"2ecffc59e440d63e4f4affca9b868741c7681901"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"af59132254913aef5b7f6ab44defe3d24dea5cbc","unresolved":false,"context_lines":[{"line_number":11383,"context_line":"        mock_guest.return_value \u003d guest"},{"line_number":11384,"context_line":"        guest.migrate_configure_max_speed \u003d mock.MagicMock()"},{"line_number":11385,"context_line":""},{"line_number":11386,"context_line":"        generated_events \u003d []"},{"line_number":11387,"context_line":""},{"line_number":11388,"context_line":"        def fake_post():"},{"line_number":11389,"context_line":"            pass"},{"line_number":11390,"context_line":""},{"line_number":11391,"context_line":"        def fake_recover():"},{"line_number":11392,"context_line":"            pass"},{"line_number":11393,"context_line":""},{"line_number":11394,"context_line":"        def fake_prepare(instance, name, tag):"},{"line_number":11395,"context_line":"            ev \u003d mock.MagicMock(instance\u003dinstance,"},{"line_number":11396,"context_line":"                                event_name\u003d\u0027%s-%s\u0027 % (name, tag))"},{"line_number":11397,"context_line":"            ev.wait.return_value \u003d mock.MagicMock(status\u003d\u0027completed\u0027)"},{"line_number":11398,"context_line":"            generated_events.append(ev)"},{"line_number":11399,"context_line":"            return ev"},{"line_number":11400,"context_line":""},{"line_number":11401,"context_line":"        prepare \u003d virtapi._compute.instance_events.prepare_for_instance_event"},{"line_number":11402,"context_line":"        prepare.side_effect \u003d fake_prepare"},{"line_number":11403,"context_line":""},{"line_number":11404,"context_line":"        drvr._live_migration(self.context, instance, \"fakehost\","},{"line_number":11405,"context_line":"                             fake_post, fake_recover, True,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_cd5af828","line":11402,"range":{"start_line":11386,"start_character":8,"end_line":11402,"end_character":42},"updated":"2018-08-09 21:56:02.000000000","message":"yeah this stuff","commit_id":"2ecffc59e440d63e4f4affca9b868741c7681901"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"33d975163b1a094ebef00d980dc4a9944c5e105e","unresolved":false,"context_lines":[{"line_number":10307,"context_line":"        # Since we are passing the VIR_MIGRATE_TUNNELLED flag, the"},{"line_number":10308,"context_line":"        # \u0027parms\u0027 dict will not (as expected) contain \u0027migrate_disks\u0027"},{"line_number":10309,"context_line":"        params \u003d {"},{"line_number":10310,"context_line":"            \u0027bandwidth\u0027: _bandwidth"},{"line_number":10311,"context_line":"        }"},{"line_number":10312,"context_line":"        # Start test"},{"line_number":10313,"context_line":"        migrate_data \u003d objects.LibvirtLiveMigrateData("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_aa3d092c","line":10310,"range":{"start_line":10310,"start_character":25,"end_line":10310,"end_character":35},"updated":"2018-08-10 18:23:14.000000000","message":"Looks like technically this should be:\n\n CONF.libvirt.live_migration_bandwidth\n\nand remove L10306, according to the original change diff [1].\n\n[1] https://review.openstack.org/#/c/497457/30/nova/tests/unit/virt/libvirt/test_driver.py@9410","commit_id":"536469ad0f1f4c97c37c2a5ec87e600582d2738e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"33d975163b1a094ebef00d980dc4a9944c5e105e","unresolved":false,"context_lines":[{"line_number":11363,"context_line":"    def test_live_migration_main(self, mock_copy_disk_path, mock_running,"},{"line_number":11364,"context_line":"                                 mock_guest, mock_monitor, mock_thread,"},{"line_number":11365,"context_line":"                                 mock_conn):"},{"line_number":11366,"context_line":"        virtapi \u003d manager.ComputeVirtAPI(mock.MagicMock())"},{"line_number":11367,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(virtapi, False)"},{"line_number":11368,"context_line":""},{"line_number":11369,"context_line":"        instance \u003d objects.Instance(**self.test_instance)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_4ae235a2","line":11366,"range":{"start_line":11366,"start_character":8,"end_line":11366,"end_character":58},"updated":"2018-08-10 18:23:14.000000000","message":"According to the original change diff [1], a lot of removal was missed here.\n\nThis line is supposed to be removed (unless something has changed since that needs it).\n\n[1] https://review.openstack.org/#/c/497457/30/nova/tests/unit/virt/libvirt/test_driver.py@10516","commit_id":"536469ad0f1f4c97c37c2a5ec87e600582d2738e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"33d975163b1a094ebef00d980dc4a9944c5e105e","unresolved":false,"context_lines":[{"line_number":11364,"context_line":"                                 mock_guest, mock_monitor, mock_thread,"},{"line_number":11365,"context_line":"                                 mock_conn):"},{"line_number":11366,"context_line":"        virtapi \u003d manager.ComputeVirtAPI(mock.MagicMock())"},{"line_number":11367,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(virtapi, False)"},{"line_number":11368,"context_line":""},{"line_number":11369,"context_line":"        instance \u003d objects.Instance(**self.test_instance)"},{"line_number":11370,"context_line":"        instance.info_cache \u003d objects.InstanceInfoCache("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_6a54d121","line":11367,"range":{"start_line":11367,"start_character":44,"end_line":11367,"end_character":51},"updated":"2018-08-10 18:23:14.000000000","message":"This should be fake.FakeVirtAPI()","commit_id":"536469ad0f1f4c97c37c2a5ec87e600582d2738e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"33d975163b1a094ebef00d980dc4a9944c5e105e","unresolved":false,"context_lines":[{"line_number":11367,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(virtapi, False)"},{"line_number":11368,"context_line":""},{"line_number":11369,"context_line":"        instance \u003d objects.Instance(**self.test_instance)"},{"line_number":11370,"context_line":"        instance.info_cache \u003d objects.InstanceInfoCache("},{"line_number":11371,"context_line":"            network_info\u003dnetwork_model.NetworkInfo(["},{"line_number":11372,"context_line":"                network_model.VIF(id\u003duuids.vif_1,"},{"line_number":11373,"context_line":"                                  type\u003dnetwork_model.VIF_TYPE_BRIDGE)]))"},{"line_number":11374,"context_line":""},{"line_number":11375,"context_line":"        dom \u003d fakelibvirt.Domain(drvr._get_connection(),"},{"line_number":11376,"context_line":"                                 \"\u003cdomain\u003e\u003cname\u003edemo\u003c/name\u003e\u003c/domain\u003e\", True)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_ca43a56b","line":11373,"range":{"start_line":11370,"start_character":8,"end_line":11373,"end_character":72},"updated":"2018-08-10 18:23:14.000000000","message":"These lines should be removed.","commit_id":"536469ad0f1f4c97c37c2a5ec87e600582d2738e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"33d975163b1a094ebef00d980dc4a9944c5e105e","unresolved":false,"context_lines":[{"line_number":11381,"context_line":"        mock_copy_disk_path.return_value \u003d disks_to_copy"},{"line_number":11382,"context_line":""},{"line_number":11383,"context_line":"        mock_guest.return_value \u003d guest"},{"line_number":11384,"context_line":"        guest.migrate_configure_max_speed \u003d mock.MagicMock()"},{"line_number":11385,"context_line":""},{"line_number":11386,"context_line":"        generated_events \u003d []"},{"line_number":11387,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_ca9c0510","line":11384,"range":{"start_line":11384,"start_character":8,"end_line":11384,"end_character":60},"updated":"2018-08-10 18:23:14.000000000","message":"This should be removed.","commit_id":"536469ad0f1f4c97c37c2a5ec87e600582d2738e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"33d975163b1a094ebef00d980dc4a9944c5e105e","unresolved":false,"context_lines":[{"line_number":11383,"context_line":"        mock_guest.return_value \u003d guest"},{"line_number":11384,"context_line":"        guest.migrate_configure_max_speed \u003d mock.MagicMock()"},{"line_number":11385,"context_line":""},{"line_number":11386,"context_line":"        generated_events \u003d []"},{"line_number":11387,"context_line":""},{"line_number":11388,"context_line":"        def fake_post():"},{"line_number":11389,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_8a8a8dbc","line":11386,"range":{"start_line":11386,"start_character":8,"end_line":11386,"end_character":29},"updated":"2018-08-10 18:23:14.000000000","message":"And this.","commit_id":"536469ad0f1f4c97c37c2a5ec87e600582d2738e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"33d975163b1a094ebef00d980dc4a9944c5e105e","unresolved":false,"context_lines":[{"line_number":11391,"context_line":"        def fake_recover():"},{"line_number":11392,"context_line":"            pass"},{"line_number":11393,"context_line":""},{"line_number":11394,"context_line":"        def fake_prepare(instance, name, tag):"},{"line_number":11395,"context_line":"            ev \u003d mock.MagicMock(instance\u003dinstance,"},{"line_number":11396,"context_line":"                                event_name\u003d\u0027%s-%s\u0027 % (name, tag))"},{"line_number":11397,"context_line":"            ev.wait.return_value \u003d mock.MagicMock(status\u003d\u0027completed\u0027)"},{"line_number":11398,"context_line":"            generated_events.append(ev)"},{"line_number":11399,"context_line":"            return ev"},{"line_number":11400,"context_line":""},{"line_number":11401,"context_line":"        prepare \u003d virtapi._compute.instance_events.prepare_for_instance_event"},{"line_number":11402,"context_line":"        prepare.side_effect \u003d fake_prepare"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_8a260dce","line":11399,"range":{"start_line":11394,"start_character":8,"end_line":11399,"end_character":21},"updated":"2018-08-10 18:23:14.000000000","message":"This should be removed.","commit_id":"536469ad0f1f4c97c37c2a5ec87e600582d2738e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"33d975163b1a094ebef00d980dc4a9944c5e105e","unresolved":false,"context_lines":[{"line_number":11398,"context_line":"            generated_events.append(ev)"},{"line_number":11399,"context_line":"            return ev"},{"line_number":11400,"context_line":""},{"line_number":11401,"context_line":"        prepare \u003d virtapi._compute.instance_events.prepare_for_instance_event"},{"line_number":11402,"context_line":"        prepare.side_effect \u003d fake_prepare"},{"line_number":11403,"context_line":""},{"line_number":11404,"context_line":"        drvr._live_migration(self.context, instance, \"fakehost\","},{"line_number":11405,"context_line":"                             fake_post, fake_recover, True,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_a53a1ac9","line":11402,"range":{"start_line":11401,"start_character":8,"end_line":11402,"end_character":42},"updated":"2018-08-10 18:23:14.000000000","message":"This should be removed.","commit_id":"536469ad0f1f4c97c37c2a5ec87e600582d2738e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"33d975163b1a094ebef00d980dc4a9944c5e105e","unresolved":false,"context_lines":[{"line_number":11427,"context_line":"    @mock.patch.object(fakelibvirt.Connection, \"_mark_running\")"},{"line_number":11428,"context_line":"    @mock.patch.object(libvirt_driver.LibvirtDriver,"},{"line_number":11429,"context_line":"                       \"_live_migration_copy_disk_paths\")"},{"line_number":11430,"context_line":"    def test_live_migration_ovs_vif(self, mock_copy_disk_path, mock_running,"},{"line_number":11431,"context_line":"                                    mock_guest, mock_monitor, mock_thread,"},{"line_number":11432,"context_line":"                                    mock_conn):"},{"line_number":11433,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_05d50e1c","line":11430,"updated":"2018-08-10 18:23:14.000000000","message":"This test was new in the original patch, so I think the entire test should be removed. I think it was added because test_live_migration_main was made linuxbridge-specific, so this test was added to cover the ovs vif type. The part that makes it \"ovs_vif\" is the part you removed L11462-11466","commit_id":"536469ad0f1f4c97c37c2a5ec87e600582d2738e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b6248f7ec601693559d831143c186952d55e840e","unresolved":false,"context_lines":[{"line_number":11363,"context_line":"                                 mock_guest, mock_monitor, mock_thread,"},{"line_number":11364,"context_line":"                                 mock_conn):"},{"line_number":11365,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":11366,"context_line":""},{"line_number":11367,"context_line":"        instance \u003d objects.Instance(**self.test_instance)"},{"line_number":11368,"context_line":""},{"line_number":11369,"context_line":"        dom \u003d fakelibvirt.Domain(drvr._get_connection(),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_10ba2ac0","line":11366,"updated":"2018-08-10 19:00:07.000000000","message":"*gasp* extra blank line","commit_id":"59e5fd8aceb82b4ab1052a5e4d3fcd43a169bbf4"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e36b4deaee78f449141e7f617dbe466affb8dc75","unresolved":false,"context_lines":[{"line_number":7523,"context_line":"                                       migrate_data, guest,"},{"line_number":7524,"context_line":"                                       device_names, bandwidth)"},{"line_number":7525,"context_line":"        except eventlet.timeout.Timeout:"},{"line_number":7526,"context_line":"            msg \u003d (\u0027Timeout waiting for VIF plugging events, \u0027"},{"line_number":7527,"context_line":"                   \u0027canceling migration\u0027)"},{"line_number":7528,"context_line":"            raise exception.MigrationError(reason\u003dmsg)"},{"line_number":7529,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_0ee45ce0","side":"PARENT","line":7526,"updated":"2018-08-10 12:44:31.000000000","message":"From the CI test patch results:\n\n1. here is where the compute manager starts waiting for network-vif-plugged on the source host prior to calling pre_live_migration:\n\nhttp://logs.openstack.org/08/553608/10/check/neutron-tempest-linuxbridge/2b303c2/logs/screen-n-cpu.txt.gz#_Aug_10_01_06_08_026382\n\n2. pre_live_migration ends:\n\nhttp://logs.openstack.org/08/553608/10/check/neutron-tempest-linuxbridge/2b303c2/logs/screen-n-cpu.txt.gz#_Aug_10_01_06_13_472241\n\n3. got the network-vif-plugged event:\n\nhttp://logs.openstack.org/08/553608/10/check/neutron-tempest-linuxbridge/2b303c2/logs/screen-n-cpu.txt.gz#_Aug_10_01_06_16_209386\n\n4. libvirt driver prepares to wait for event:\n\nhttp://logs.openstack.org/08/553608/10/check/neutron-tempest-linuxbridge/2b303c2/logs/screen-n-cpu.txt.gz#_Aug_10_01_06_16_249392\n\n5. live migration starts on the hypervisor:\n\nhttp://logs.openstack.org/08/553608/10/check/neutron-tempest-linuxbridge/2b303c2/logs/screen-n-cpu.txt.gz#_Aug_10_01_06_16_466861\n\n6. live migration is done:\n\nhttp://logs.openstack.org/08/553608/10/check/neutron-tempest-linuxbridge/2b303c2/logs/screen-n-cpu.txt.gz#_Aug_10_01_06_46_765536\n\ntook about 30 seconds to transfer the guest\n\n7. tempest starts cleaning up the instance, note the pending waiting event:\n\nhttp://logs.openstack.org/08/553608/10/check/neutron-tempest-linuxbridge/2b303c2/logs/screen-n-cpu.txt.gz#_Aug_10_01_09_24_515958\n\n8. and finally we get the event timeout:\n\nhttp://logs.openstack.org/08/553608/10/check/neutron-tempest-linuxbridge/2b303c2/logs/screen-n-cpu.txt.gz#_Aug_10_01_11_16_254260\n\nThe vif_plugging_timeout is not getting set to 30 seconds for some reason in the CI run - maybe devstack is overriding it? But anyway, we see the pattern and failure.","commit_id":"c52c2caf97a90de8770e9296d553e0e4a65ac946"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7386dc0b6b6e33602d1cd83ee843282847affa0e","unresolved":false,"context_lines":[{"line_number":7523,"context_line":"                                       migrate_data, guest,"},{"line_number":7524,"context_line":"                                       device_names, bandwidth)"},{"line_number":7525,"context_line":"        except eventlet.timeout.Timeout:"},{"line_number":7526,"context_line":"            msg \u003d (\u0027Timeout waiting for VIF plugging events, \u0027"},{"line_number":7527,"context_line":"                   \u0027canceling migration\u0027)"},{"line_number":7528,"context_line":"            raise exception.MigrationError(reason\u003dmsg)"},{"line_number":7529,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ae32085d","side":"PARENT","line":7526,"in_reply_to":"3f79a3b5_0ee45ce0","updated":"2018-08-10 12:46:13.000000000","message":"Yup devstack hardcodes the vif_plugging_timeout to 300 so that\u0027s why my dependent nova patch isn\u0027t taking effect\n\nhttp://logs.openstack.org/08/553608/10/check/neutron-tempest-linuxbridge/2b303c2/logs/devstacklog.txt.gz#_2018-08-10_00_50_06_570","commit_id":"c52c2caf97a90de8770e9296d553e0e4a65ac946"}],"releasenotes/notes/libvirt-live-migration-speed-limit-revert-81a9d29d60b0df4b.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"edf2d981c69dfe84ef6c37c6cde188edf46f8473","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Note that the original fix for bug 1414559 committed early in rocky was automatic and always"},{"line_number":5,"context_line":"    enabled. Because of bug 1786346 that fix has since been reverted and superseded by an opt-in"},{"line_number":6,"context_line":"    mechanism which must be enabled. Setting `[compute]/live_migration_wait_for_vif_plug\u003dTrue``"},{"line_number":7,"context_line":"    will restore the behavior of waiting for neutron events during the live migration process."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_03cbdf1d","line":4,"range":{"start_line":4,"start_character":35,"end_line":4,"end_character":46},"updated":"2018-08-10 00:52:01.000000000","message":"nit: link to https://bugs.launchpad.net/neutron/+bug/1414559","commit_id":"cf0dc88382e7ecc48b82a88f0af14f70cbf8ab09"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"edf2d981c69dfe84ef6c37c6cde188edf46f8473","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Note that the original fix for bug 1414559 committed early in rocky was automatic and always"},{"line_number":5,"context_line":"    enabled. Because of bug 1786346 that fix has since been reverted and superseded by an opt-in"},{"line_number":6,"context_line":"    mechanism which must be enabled. Setting `[compute]/live_migration_wait_for_vif_plug\u003dTrue``"},{"line_number":7,"context_line":"    will restore the behavior of waiting for neutron events during the live migration process."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_a3d1cbcf","line":5,"range":{"start_line":5,"start_character":24,"end_line":5,"end_character":35},"updated":"2018-08-10 00:52:01.000000000","message":"same https://bugs.launchpad.net/nova/+bug/1786346","commit_id":"cf0dc88382e7ecc48b82a88f0af14f70cbf8ab09"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"edf2d981c69dfe84ef6c37c6cde188edf46f8473","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Note that the original fix for bug 1414559 committed early in rocky was automatic and always"},{"line_number":5,"context_line":"    enabled. Because of bug 1786346 that fix has since been reverted and superseded by an opt-in"},{"line_number":6,"context_line":"    mechanism which must be enabled. Setting `[compute]/live_migration_wait_for_vif_plug\u003dTrue``"},{"line_number":7,"context_line":"    will restore the behavior of waiting for neutron events during the live migration process."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_83d60fc3","line":6,"range":{"start_line":6,"start_character":45,"end_line":6,"end_character":46},"updated":"2018-08-10 00:52:01.000000000","message":"missing back-tick\n\ncould also link to https://docs.openstack.org/nova/latest/configuration/config.html#compute.live_migration_wait_for_vif_plug for more details","commit_id":"cf0dc88382e7ecc48b82a88f0af14f70cbf8ab09"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"980125e91b99a6fa1d8a6f6b3ed44ab1b4791caf","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Note that the original fix for bug 1414559 committed early in rocky was automatic and always"},{"line_number":5,"context_line":"    enabled. Because of bug 1786346 that fix has since been reverted and superseded by an opt-in"},{"line_number":6,"context_line":"    mechanism which must be enabled. Setting `[compute]/live_migration_wait_for_vif_plug\u003dTrue``"},{"line_number":7,"context_line":"    will restore the behavior of waiting for neutron events during the live migration process."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_f500c703","line":6,"range":{"start_line":6,"start_character":45,"end_line":6,"end_character":46},"in_reply_to":"3f79a3b5_83d60fc3","updated":"2018-08-10 15:39:42.000000000","message":"\u003e could also link to https://docs.openstack.org/nova/latest/configuration/config.html#compute.live_migration_wait_for_vif_plug for more details\n\nThat\u0027s maybe unnecessary, up to you.","commit_id":"cf0dc88382e7ecc48b82a88f0af14f70cbf8ab09"}]}