)]}'
{"nova/exception.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"6b23582ed6284effadf6da81f3e33506a6cfa242","unresolved":false,"context_lines":[{"line_number":1484,"context_line":""},{"line_number":1485,"context_line":""},{"line_number":1486,"context_line":"class KeyManagerError(NovaException):"},{"line_number":1487,"context_line":"    msg_fmt \u003d _(\"key manager error: %(reason)s\")"},{"line_number":1488,"context_line":""},{"line_number":1489,"context_line":""},{"line_number":1490,"context_line":"class InvalidVideoMode(Invalid):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9pLo%3D","line":1487,"updated":"2013-12-09 11:35:36.000000000","message":"Please don\u0027t change unrelated code lines","commit_id":"56d201df7413c98e150424b892bf1ee9c5081d08"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"89a83d3315a5033024a2052d4fc4a288f60d337d","unresolved":false,"context_lines":[{"line_number":1484,"context_line":""},{"line_number":1485,"context_line":""},{"line_number":1486,"context_line":"class KeyManagerError(NovaException):"},{"line_number":1487,"context_line":"    msg_fmt \u003d _(\"key manager error: %(reason)s\")"},{"line_number":1488,"context_line":""},{"line_number":1489,"context_line":""},{"line_number":1490,"context_line":"class InvalidVideoMode(Invalid):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9og0%3D","line":1487,"in_reply_to":"AAAATn%2F9pLo%3D","updated":"2013-12-09 14:11:25.000000000","message":"Done","commit_id":"56d201df7413c98e150424b892bf1ee9c5081d08"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"6f87cbcc9a8421a1b754957a3218e20977944324","unresolved":false,"context_lines":[{"line_number":2965,"context_line":"            VALID_VIDEO_DEVICES \u003d (\"vga\", \"cirrus\", \"vmvga\", \"xen\", \"qxl\")"},{"line_number":2966,"context_line":"            video \u003d vconfig.LibvirtConfigGuestVideo()"},{"line_number":2967,"context_line":"            meta_prop \u003d image_meta.get(\u0027properties\u0027, {}) if image_meta else {}"},{"line_number":2968,"context_line":"            video.vram \u003d meta_prop.get(\u0027hw_video_vram\u0027, video.vram)"},{"line_number":2969,"context_line":""},{"line_number":2970,"context_line":"            if meta_prop.get(\u0027hw_video_model\u0027):"},{"line_number":2971,"context_line":"                video.type \u003d meta_prop.get(\u0027hw_video_model\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BMRc%3D","line":2968,"updated":"2013-11-29 12:32:17.000000000","message":"This is actually a security flaw here because video RAM is not accounted for in the flavour max ram limits and we\u0027re not placing any limit on what hw_video_ram can set.\n\nI think that we\u0027ll need to have a property against the flavour to specify what the max permitted video RAM is. If this property is not set, then we should not honour the hw_video_ram field at all.","commit_id":"0274e24991102200a52a09a8e95256cdfdc45b07"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"b8bea270c99d94efcd29d531f0c7a178bbba1727","unresolved":false,"context_lines":[{"line_number":2965,"context_line":"            VALID_VIDEO_DEVICES \u003d (\"vga\", \"cirrus\", \"vmvga\", \"xen\", \"qxl\")"},{"line_number":2966,"context_line":"            video \u003d vconfig.LibvirtConfigGuestVideo()"},{"line_number":2967,"context_line":"            meta_prop \u003d image_meta.get(\u0027properties\u0027, {}) if image_meta else {}"},{"line_number":2968,"context_line":"            video.vram \u003d meta_prop.get(\u0027hw_video_vram\u0027, video.vram)"},{"line_number":2969,"context_line":""},{"line_number":2970,"context_line":"            if meta_prop.get(\u0027hw_video_model\u0027):"},{"line_number":2971,"context_line":"                video.type \u003d meta_prop.get(\u0027hw_video_model\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BLLM%3D","line":2968,"in_reply_to":"AAAATn%2F%2BMRc%3D","updated":"2013-11-29 18:45:55.000000000","message":"I see, thanks. I\u0027ll separate vram from this patch and will submit another one to handle it.","commit_id":"0274e24991102200a52a09a8e95256cdfdc45b07"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"c435d9693f3ae35cc9b602294cfcc7100c0c9dce","unresolved":false,"context_lines":[{"line_number":2969,"context_line":"            if meta_prop.get(\u0027hw_video_model\u0027):"},{"line_number":2970,"context_line":"                video.type \u003d meta_prop.get(\u0027hw_video_model\u0027)"},{"line_number":2971,"context_line":"                if (video.type not in VALID_VIDEO_DEVICES):"},{"line_number":2972,"context_line":"                    raise exception.InvalidVideoMode(model\u003dvideo.type)"},{"line_number":2973,"context_line":""},{"line_number":2974,"context_line":"            elif CONF.spice.enabled:"},{"line_number":2975,"context_line":"                video.type \u003d \u0027qxl\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BKwM%3D","line":2972,"updated":"2013-11-30 01:02:03.000000000","message":"Should I raise here if video.type !\u003d \u0027xen\u0027 and guest.os_type \u003d\u003d vm_mode.XEN as well or should It stay as it is now?","commit_id":"32cb1fbf42c920685068aa4f6d6aa7fbef7fcdf6"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"5648fc5e54a0d163b3aaa65b759594ec030a9ba5","unresolved":false,"context_lines":[{"line_number":2969,"context_line":"            if meta_prop.get(\u0027hw_video_model\u0027):"},{"line_number":2970,"context_line":"                video.type \u003d meta_prop.get(\u0027hw_video_model\u0027)"},{"line_number":2971,"context_line":"                if (video.type not in VALID_VIDEO_DEVICES):"},{"line_number":2972,"context_line":"                    raise exception.InvalidVideoMode(model\u003dvideo.type)"},{"line_number":2973,"context_line":""},{"line_number":2974,"context_line":"            elif CONF.spice.enabled:"},{"line_number":2975,"context_line":"                video.type \u003d \u0027qxl\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F96KQ%3D","line":2972,"in_reply_to":"AAAATn%2F%2BKwM%3D","updated":"2013-12-04 16:13:51.000000000","message":"I don\u0027t think we need to go over the top in duplicating validation that libvirt will also do.","commit_id":"32cb1fbf42c920685068aa4f6d6aa7fbef7fcdf6"}]}