)]}'
{"nova/api/openstack/placement/objects/resource_provider.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"c331db7b0ff9e74e82b11c7a234b050fbd42e234","unresolved":false,"context_lines":[{"line_number":2928,"context_line":"                matching_rps[prov_ids[0]] \u003d prov_ids"},{"line_number":2929,"context_line":""},{"line_number":2930,"context_line":"        if start_num_matches \u003d\u003d 0:"},{"line_number":2931,"context_line":"            LOG.debug(\"found %d providers with capacity for the requested \""},{"line_number":2932,"context_line":"                      \"%d %s. \", len(provs_with_resource), amount, rc_name)"},{"line_number":2933,"context_line":"        else:"},{"line_number":2934,"context_line":"            LOG.debug(\"found %d providers with capacity for the requested \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_608b8d6d","side":"PARENT","line":2931,"updated":"2018-08-10 21:00:46.000000000","message":"and you removed the information that indicated the before and after counts of matched providers. this was useful information meant to enable diagnosing the filtering process.","commit_id":"2a10b87addae77e4a817a6a4bd712b017b25dd10"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"30e94bfafb839a5d6f501ffaf9b7b2164f308e8d","unresolved":false,"context_lines":[{"line_number":2928,"context_line":"                matching_rps[prov_ids[0]] \u003d prov_ids"},{"line_number":2929,"context_line":""},{"line_number":2930,"context_line":"        if start_num_matches \u003d\u003d 0:"},{"line_number":2931,"context_line":"            LOG.debug(\"found %d providers with capacity for the requested \""},{"line_number":2932,"context_line":"                      \"%d %s. \", len(provs_with_resource), amount, rc_name)"},{"line_number":2933,"context_line":"        else:"},{"line_number":2934,"context_line":"            LOG.debug(\"found %d providers with capacity for the requested \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_2017d553","side":"PARENT","line":2931,"in_reply_to":"3f79a3b5_608b8d6d","updated":"2018-08-10 21:47:07.000000000","message":"I figured you could see the previous iteration\u0027s count in the message from the previous iteration.","commit_id":"2a10b87addae77e4a817a6a4bd712b017b25dd10"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"c331db7b0ff9e74e82b11c7a234b050fbd42e234","unresolved":false,"context_lines":[{"line_number":2905,"context_line":"        if filt_rps:"},{"line_number":2906,"context_line":"            rp_ids \u0026\u003d filt_rps"},{"line_number":2907,"context_line":"        elif forbidden_rp_ids:"},{"line_number":2908,"context_line":"            rp_ids -\u003d forbidden_rp_ids"},{"line_number":2909,"context_line":""},{"line_number":2910,"context_line":"        LOG.debug(\"inside %s request loop. after applying combined aggregate \""},{"line_number":2911,"context_line":"                  \"and trait filters, found %d matching providers\","}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_00a3b901","line":2908,"updated":"2018-08-10 21:00:46.000000000","message":"The log messages that used to be in here were supposed to help diagnose what cause a filter to return 0 rows. By removing the log messages about required traits and aggregate filters we\u0027ve removed that information.","commit_id":"9a4d84ed491ea3fddb0db0729b9684d0adcef00d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"30e94bfafb839a5d6f501ffaf9b7b2164f308e8d","unresolved":false,"context_lines":[{"line_number":2905,"context_line":"        if filt_rps:"},{"line_number":2906,"context_line":"            rp_ids \u0026\u003d filt_rps"},{"line_number":2907,"context_line":"        elif forbidden_rp_ids:"},{"line_number":2908,"context_line":"            rp_ids -\u003d forbidden_rp_ids"},{"line_number":2909,"context_line":""},{"line_number":2910,"context_line":"        LOG.debug(\"inside %s request loop. after applying combined aggregate \""},{"line_number":2911,"context_line":"                  \"and trait filters, found %d matching providers\","}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_401c5177","line":2908,"in_reply_to":"3f79a3b5_00a3b901","updated":"2018-08-10 21:47:07.000000000","message":"Yeah, whatever minor gain in efficiency is almost certainly not worth it.","commit_id":"9a4d84ed491ea3fddb0db0729b9684d0adcef00d"}]}