)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f40f8183907b16dfc919af39f557a6a536ea7576","unresolved":false,"context_lines":[{"line_number":17,"context_line":"case the allocation held by the migration_uuid is leaked. The same true"},{"line_number":18,"context_line":"for live migration failing to delete allocaton on the source host."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"TODO:"},{"line_number":21,"context_line":"* Add a release notes explaining the possible leaks."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Blueprint: use-nested-allocation-candidates"},{"line_number":24,"context_line":"Change-Id: I99427a52676826990d2a2ffc82cf30ad945b939c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_d6e87c16","line":21,"range":{"start_line":20,"start_character":0,"end_line":21,"end_character":52},"updated":"2018-09-26 09:02:38.000000000","message":"Done","commit_id":"0599893c48ebf0a9a964714791cecd8b70d89885"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"867474710b4d53f7905d71eee8b3e55fb3764ce2","unresolved":false,"context_lines":[{"line_number":14,"context_line":"then nova puts the instance to ERROR state. The instance still has two"},{"line_number":15,"context_line":"allocations in this state and deleting the instance only deletes the one that"},{"line_number":16,"context_line":"is held by the instance_uuid. This patch logs an ERROR describing that in this"},{"line_number":17,"context_line":"case the allocation held by the migration_uuid is leaked. The same true"},{"line_number":18,"context_line":"for live migration failing to delete allocaton on the source host."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"As this makes every caller of _delete_allocation_after_move logging the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f79a3b5_68fbc047","line":17,"range":{"start_line":17,"start_character":67,"end_line":17,"end_character":71},"updated":"2018-09-26 15:42:30.000000000","message":"is true","commit_id":"3a43a931d4e46a0aa66683da22482f3e78f26cd7"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"867474710b4d53f7905d71eee8b3e55fb3764ce2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"case the allocation held by the migration_uuid is leaked. The same true"},{"line_number":18,"context_line":"for live migration failing to delete allocaton on the source host."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"As this makes every caller of _delete_allocation_after_move logging the"},{"line_number":21,"context_line":"same error for AllocationDeleteFailed exception this patch moves that logging"},{"line_number":22,"context_line":"into _delete_allocation_after_move."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f79a3b5_c891b4f9","line":20,"range":{"start_line":20,"start_character":60,"end_line":20,"end_character":67},"updated":"2018-09-26 15:42:30.000000000","message":"s/logging/log","commit_id":"3a43a931d4e46a0aa66683da22482f3e78f26cd7"}],"nova/compute/manager.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"13d423ce5a11f41170b7f6dc126b6ffe11bfe011","unresolved":false,"context_lines":[{"line_number":3895,"context_line":"                                                   migration,"},{"line_number":3896,"context_line":"                                                   old_instance_type,"},{"line_number":3897,"context_line":"                                                   migration.source_node)"},{"line_number":3898,"context_line":"            except exception.AllocationDeleteFailed:"},{"line_number":3899,"context_line":"                LOG.error(\u0027Deleting allocation in placement for migration \u0027"},{"line_number":3900,"context_line":"                          \u0027%(migration_uuid)s failed. The instance \u0027"},{"line_number":3901,"context_line":"                          \u0027%(instance_uuid)s will be put to ERROR state but \u0027"},{"line_number":3902,"context_line":"                          \u0027the allocation held by the migration is leaked.\u0027,"},{"line_number":3903,"context_line":"                          {\u0027instance_uuid\u0027: instance.uuid,"},{"line_number":3904,"context_line":"                           \u0027migration_uuid\u0027: migration.uuid})"},{"line_number":3905,"context_line":"                raise"},{"line_number":3906,"context_line":""},{"line_number":3907,"context_line":"            instance.drop_migration_context()"},{"line_number":3908,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_33fe4d05","line":3905,"range":{"start_line":3898,"start_character":0,"end_line":3905,"end_character":21},"updated":"2018-09-17 22:30:35.000000000","message":"Why not add this error handling into _delete_allocation_after_move() instead of the outside?","commit_id":"0599893c48ebf0a9a964714791cecd8b70d89885"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f40f8183907b16dfc919af39f557a6a536ea7576","unresolved":false,"context_lines":[{"line_number":3895,"context_line":"                                                   migration,"},{"line_number":3896,"context_line":"                                                   old_instance_type,"},{"line_number":3897,"context_line":"                                                   migration.source_node)"},{"line_number":3898,"context_line":"            except exception.AllocationDeleteFailed:"},{"line_number":3899,"context_line":"                LOG.error(\u0027Deleting allocation in placement for migration \u0027"},{"line_number":3900,"context_line":"                          \u0027%(migration_uuid)s failed. The instance \u0027"},{"line_number":3901,"context_line":"                          \u0027%(instance_uuid)s will be put to ERROR state but \u0027"},{"line_number":3902,"context_line":"                          \u0027the allocation held by the migration is leaked.\u0027,"},{"line_number":3903,"context_line":"                          {\u0027instance_uuid\u0027: instance.uuid,"},{"line_number":3904,"context_line":"                           \u0027migration_uuid\u0027: migration.uuid})"},{"line_number":3905,"context_line":"                raise"},{"line_number":3906,"context_line":""},{"line_number":3907,"context_line":"            instance.drop_migration_context()"},{"line_number":3908,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_f68d787c","line":3905,"range":{"start_line":3898,"start_character":0,"end_line":3905,"end_character":21},"in_reply_to":"3f79a3b5_10b28e07","updated":"2018-09-26 09:02:38.000000000","message":"Done","commit_id":"0599893c48ebf0a9a964714791cecd8b70d89885"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b2426fd02c4f4deb7406ad7eaf969272277f06fa","unresolved":false,"context_lines":[{"line_number":3895,"context_line":"                                                   migration,"},{"line_number":3896,"context_line":"                                                   old_instance_type,"},{"line_number":3897,"context_line":"                                                   migration.source_node)"},{"line_number":3898,"context_line":"            except exception.AllocationDeleteFailed:"},{"line_number":3899,"context_line":"                LOG.error(\u0027Deleting allocation in placement for migration \u0027"},{"line_number":3900,"context_line":"                          \u0027%(migration_uuid)s failed. The instance \u0027"},{"line_number":3901,"context_line":"                          \u0027%(instance_uuid)s will be put to ERROR state but \u0027"},{"line_number":3902,"context_line":"                          \u0027the allocation held by the migration is leaked.\u0027,"},{"line_number":3903,"context_line":"                          {\u0027instance_uuid\u0027: instance.uuid,"},{"line_number":3904,"context_line":"                           \u0027migration_uuid\u0027: migration.uuid})"},{"line_number":3905,"context_line":"                raise"},{"line_number":3906,"context_line":""},{"line_number":3907,"context_line":"            instance.drop_migration_context()"},{"line_number":3908,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_10b28e07","line":3905,"range":{"start_line":3898,"start_character":0,"end_line":3905,"end_character":21},"in_reply_to":"3f79a3b5_33fe4d05","updated":"2018-09-25 15:12:04.000000000","message":"Good point.","commit_id":"0599893c48ebf0a9a964714791cecd8b70d89885"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c4e40f32dd4282836f532af0bbc7521204a25183","unresolved":false,"context_lines":[{"line_number":3894,"context_line":"            rt.drop_move_claim(context, instance, migration.source_node,"},{"line_number":3895,"context_line":"                               old_instance_type, prefix\u003d\u0027old_\u0027)"},{"line_number":3896,"context_line":"            self._delete_allocation_after_move(context, instance,"},{"line_number":3897,"context_line":"                                               migration,"},{"line_number":3898,"context_line":"                                               old_instance_type,"},{"line_number":3899,"context_line":"                                               migration.source_node)"},{"line_number":3900,"context_line":"            instance.drop_migration_context()"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_2842a83c","line":3897,"updated":"2018-09-26 15:02:45.000000000","message":"unrelated","commit_id":"3a43a931d4e46a0aa66683da22482f3e78f26cd7"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"867474710b4d53f7905d71eee8b3e55fb3764ce2","unresolved":false,"context_lines":[{"line_number":3947,"context_line":"                        # NOTE(danms): We succeeded, which means we do not"},{"line_number":3948,"context_line":"                        # need to do the complex double allocation dance"},{"line_number":3949,"context_line":"                        return"},{"line_number":3950,"context_line":"                except exception.AllocationDeleteFailed:"},{"line_number":3951,"context_line":"                    LOG.error(\u0027Deleting allocation in placement for migration \u0027"},{"line_number":3952,"context_line":"                              \u0027%(migration_uuid)s failed. The instance \u0027"},{"line_number":3953,"context_line":"                              \u0027%(instance_uuid)s will be put to ERROR state \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_4e212d9e","line":3950,"range":{"start_line":3950,"start_character":33,"end_line":3950,"end_character":55},"updated":"2018-09-26 15:42:30.000000000","message":"I don\u0027t see where we\u0027re catching AllocationDeleteFailed anywhere in the manager.py file?","commit_id":"3a43a931d4e46a0aa66683da22482f3e78f26cd7"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8fa8a68130c95675abc60241684ba8689fbf8ba8","unresolved":false,"context_lines":[{"line_number":3947,"context_line":"                        # NOTE(danms): We succeeded, which means we do not"},{"line_number":3948,"context_line":"                        # need to do the complex double allocation dance"},{"line_number":3949,"context_line":"                        return"},{"line_number":3950,"context_line":"                except exception.AllocationDeleteFailed:"},{"line_number":3951,"context_line":"                    LOG.error(\u0027Deleting allocation in placement for migration \u0027"},{"line_number":3952,"context_line":"                              \u0027%(migration_uuid)s failed. The instance \u0027"},{"line_number":3953,"context_line":"                              \u0027%(instance_uuid)s will be put to ERROR state \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_4eaa8d84","line":3950,"range":{"start_line":3950,"start_character":33,"end_line":3950,"end_character":55},"in_reply_to":"3f79a3b5_4e212d9e","updated":"2018-09-26 15:59:24.000000000","message":"You are correct we are not catching this but there are generic exception handling already in place [1] that puts the instance to ERROR state if this exception bubbles up.\nAlso the move operations are async on the API so this exception will not cause HTTP 500 to be returned to the end user.\n\n[1] https://github.com/openstack/nova/blob/b79a21a03db72af2d85894d51c9a3a49bb48a35e/nova/compute/manager.py#L3871","commit_id":"3a43a931d4e46a0aa66683da22482f3e78f26cd7"}]}