)]}'
{"nova/api/openstack/placement/schemas/allocation.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"4478ed3a04dcf6282b30c447020b8f7df975a7a9","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                        \"type\": \"object\","},{"line_number":41,"context_line":"                        \"minProperties\": 1,"},{"line_number":42,"context_line":"                        \"patternProperties\": {"},{"line_number":43,"context_line":"                            \"^[0-9A-Z_]+$\": {"},{"line_number":44,"context_line":"                                \"type\": \"integer\","},{"line_number":45,"context_line":"                                \"minimum\": 1,"},{"line_number":46,"context_line":"                            }"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_24286295","line":43,"range":{"start_line":43,"start_character":29,"end_line":43,"end_character":41},"updated":"2018-08-22 13:13:14.000000000","message":"This also","commit_id":"8463682007d416cead72c7a8e0f0b7e467c9453f"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9d8e5f05e6b17b551cc73a36ed31300fb62cac9c","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                        \"type\": \"object\","},{"line_number":41,"context_line":"                        \"minProperties\": 1,"},{"line_number":42,"context_line":"                        \"patternProperties\": {"},{"line_number":43,"context_line":"                            \"^[0-9A-Z_]+$\": {"},{"line_number":44,"context_line":"                                \"type\": \"integer\","},{"line_number":45,"context_line":"                                \"minimum\": 1,"},{"line_number":46,"context_line":"                            }"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_791fdb07","line":43,"range":{"start_line":43,"start_character":29,"end_line":43,"end_character":41},"in_reply_to":"3f79a3b5_24286295","updated":"2018-08-22 16:09:33.000000000","message":"Yup, good catch, done.","commit_id":"8463682007d416cead72c7a8e0f0b7e467c9453f"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"4478ed3a04dcf6282b30c447020b8f7df975a7a9","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                            \"minProperties\": 1,"},{"line_number":93,"context_line":"                            # resource class"},{"line_number":94,"context_line":"                            \"patternProperties\": {"},{"line_number":95,"context_line":"                                \"^[0-9A-Z_]+$\": {"},{"line_number":96,"context_line":"                                    \"type\": \"integer\","},{"line_number":97,"context_line":"                                    \"minimum\": 1,"},{"line_number":98,"context_line":"                                }"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_8437f6fe","line":95,"range":{"start_line":95,"start_character":33,"end_line":95,"end_character":45},"updated":"2018-08-22 13:13:14.000000000","message":"this can be replaced by const also.","commit_id":"8463682007d416cead72c7a8e0f0b7e467c9453f"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9d8e5f05e6b17b551cc73a36ed31300fb62cac9c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                            \"minProperties\": 1,"},{"line_number":93,"context_line":"                            # resource class"},{"line_number":94,"context_line":"                            \"patternProperties\": {"},{"line_number":95,"context_line":"                                \"^[0-9A-Z_]+$\": {"},{"line_number":96,"context_line":"                                    \"type\": \"integer\","},{"line_number":97,"context_line":"                                    \"minimum\": 1,"},{"line_number":98,"context_line":"                                }"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_3915e3e5","line":95,"range":{"start_line":95,"start_character":33,"end_line":95,"end_character":45},"in_reply_to":"3f79a3b5_8437f6fe","updated":"2018-08-22 16:09:33.000000000","message":"Done","commit_id":"8463682007d416cead72c7a8e0f0b7e467c9453f"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"ab4122ebf17fa2e79698103bfba95f4c29274b7b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                        \"properties\": {"},{"line_number":31,"context_line":"                            \"uuid\": {"},{"line_number":32,"context_line":"                                \"type\": \"string\","},{"line_number":33,"context_line":"                                \"format\": \"uuid\""},{"line_number":34,"context_line":"                            }"},{"line_number":35,"context_line":"                        },"},{"line_number":36,"context_line":"                        \"additionalProperties\": False,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_2b182a1c","line":33,"updated":"2018-08-22 16:38:15.000000000","message":"Note for the future:\nwe may wish, perhaps when we follow up https://review.openstack.org/#/c/567191/ and do the microversion-requiring enforcement changes, to change this to a pattern that uses the new pattern that is being added in this patch.\n\nBecause: the \u0027uuid\u0027 format is backed by uuidutils.is_uuid_like, which is happy with dashless (and several other forms) of UUID.","commit_id":"fa66d9a730072869ac13797a37d3224855653f1e"}],"nova/api/openstack/placement/schemas/common.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"7260939c11de754c438e51e9e78cb6f678a421c1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":"_XDIGIT \u003d \"[0-9a-fA-F]\""},{"line_number":13,"context_line":"# TODO(efried): Use this stricter pattern, and replace string/uuid with it:"},{"line_number":14,"context_line":"# UUID_PATTERN \u003d \"^%s{8}-%s{4}-%s{4}-%s{4}-%s{12}$\" % ((_XDIGIT,) * 5)"},{"line_number":15,"context_line":"UUID_PATTERN \u003d \"^%s{36}$\" % _XDIGIT"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_fe085c92","line":12,"updated":"2018-08-15 08:19:55.000000000","message":"You need a \u0027-\u0027 after the \u0027F\u0027 otherwise you\u0027re only accepts numbers, and upper and lower a through f, no -","commit_id":"5c906742a849f6078d1a6143b6a709541f3be327"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"deea766fdcc76d52bb67a837d01dbdb278ed5194","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":"_XDIGIT \u003d \"[0-9a-fA-F]\""},{"line_number":13,"context_line":"# TODO(efried): Use this stricter pattern, and replace string/uuid with it:"},{"line_number":14,"context_line":"# UUID_PATTERN \u003d \"^%s{8}-%s{4}-%s{4}-%s{4}-%s{12}$\" % ((_XDIGIT,) * 5)"},{"line_number":15,"context_line":"UUID_PATTERN \u003d \"^%s{36}$\" % _XDIGIT"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_73b6be8c","line":12,"in_reply_to":"3f79a3b5_fe085c92","updated":"2018-08-15 13:48:52.000000000","message":"whoops","commit_id":"5c906742a849f6078d1a6143b6a709541f3be327"}]}