)]}'
{"nova/network/neutronv2/api.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"76234d1004d4ef87eb7c93b89ed2062d3b114b0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3f79a3b5_19c4a75f","updated":"2018-09-17 07:56:41.000000000","message":"One alternative would be to move the SRIOV check to the compute.api.attach_interface() call. That way we could avoid the extra boolean flag, but in return we would need to call port_show in the compute api. I don\u0027t think that would be significantly better so this is approach is OK for me.","commit_id":"68011c40ae2ab0900674408a88f62a60a802fef7"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"76234d1004d4ef87eb7c93b89ed2062d3b114b0c","unresolved":false,"context_lines":[{"line_number":971,"context_line":"    def allocate_for_instance(self, context, instance, vpn,"},{"line_number":972,"context_line":"                              requested_networks, macs\u003dNone,"},{"line_number":973,"context_line":"                              security_groups\u003dNone, bind_host_id\u003dNone,"},{"line_number":974,"context_line":"                              attach\u003dFalse):"},{"line_number":975,"context_line":"        \"\"\"Allocate network resources for the instance."},{"line_number":976,"context_line":""},{"line_number":977,"context_line":"        :param context: The request context."}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_79e27b03","line":974,"updated":"2018-09-17 07:56:41.000000000","message":"Is it intentional that base_api.NetworkAPI.allocate_for_instance() signature is not extended with the new flag?","commit_id":"68011c40ae2ab0900674408a88f62a60a802fef7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d7336363064663cafd55c49175a94c2e96c623e","unresolved":false,"context_lines":[{"line_number":971,"context_line":"    def allocate_for_instance(self, context, instance, vpn,"},{"line_number":972,"context_line":"                              requested_networks, macs\u003dNone,"},{"line_number":973,"context_line":"                              security_groups\u003dNone, bind_host_id\u003dNone,"},{"line_number":974,"context_line":"                              attach\u003dFalse):"},{"line_number":975,"context_line":"        \"\"\"Allocate network resources for the instance."},{"line_number":976,"context_line":""},{"line_number":977,"context_line":"        :param context: The request context."}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_ffff4163","line":974,"in_reply_to":"3f79a3b5_79e27b03","updated":"2018-09-17 16:56:15.000000000","message":"No, it\u0027s not intentional, it\u0027s just that nothing outside of this class was calling allocate_for_instance with the new parameter, so I didn\u0027t think of it (like I would if the ComputeManager were calling this). If you don\u0027t mind I\u0027ll fix that in a follow up.","commit_id":"68011c40ae2ab0900674408a88f62a60a802fef7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3a4a17f36296c15a035d9c4f5e99c40a44c7e1a9","unresolved":false,"context_lines":[{"line_number":971,"context_line":"    def allocate_for_instance(self, context, instance, vpn,"},{"line_number":972,"context_line":"                              requested_networks, macs\u003dNone,"},{"line_number":973,"context_line":"                              security_groups\u003dNone, bind_host_id\u003dNone,"},{"line_number":974,"context_line":"                              attach\u003dFalse):"},{"line_number":975,"context_line":"        \"\"\"Allocate network resources for the instance."},{"line_number":976,"context_line":""},{"line_number":977,"context_line":"        :param context: The request context."}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_4ef28d07","line":974,"in_reply_to":"3f79a3b5_ffff4163","updated":"2018-09-26 15:47:02.000000000","message":"https://review.openstack.org/#/c/605464/","commit_id":"68011c40ae2ab0900674408a88f62a60a802fef7"}],"nova/tests/unit/network/test_neutronv2.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"46b717d6631e59b7421526a6d9d279ba36c7ada8","unresolved":false,"context_lines":[{"line_number":5963,"context_line":"    def test_validate_requested_port_ids_raise_sriov(self):"},{"line_number":5964,"context_line":"        self._assert_validate_requested_port_ids_raises("},{"line_number":5965,"context_line":"            exception.AttachSRIOVPortNotSupported,"},{"line_number":5966,"context_line":"            {\"binding:vnic_type\": model.VNIC_TYPE_DIRECT},"},{"line_number":5967,"context_line":"            attach\u003dTrue)"},{"line_number":5968,"context_line":""},{"line_number":5969,"context_line":"    def test_validate_requested_network_ids_success_auto_net(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_e2244f0f","line":5966,"range":{"start_line":5966,"start_character":34,"end_line":5966,"end_character":56},"updated":"2018-08-24 21:51:23.000000000","message":"I\u0027d suggest to make a random.choice(model.VNIC_TYPES_SRIOV)\nsomehow all values will be tested with different patches, but this is fine too.","commit_id":"68011c40ae2ab0900674408a88f62a60a802fef7"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"eb7af87755e78bb2f0903f1886de22072a6a0c84","unresolved":false,"context_lines":[{"line_number":5963,"context_line":"    def test_validate_requested_port_ids_raise_sriov(self):"},{"line_number":5964,"context_line":"        self._assert_validate_requested_port_ids_raises("},{"line_number":5965,"context_line":"            exception.AttachSRIOVPortNotSupported,"},{"line_number":5966,"context_line":"            {\"binding:vnic_type\": model.VNIC_TYPE_DIRECT},"},{"line_number":5967,"context_line":"            attach\u003dTrue)"},{"line_number":5968,"context_line":""},{"line_number":5969,"context_line":"    def test_validate_requested_network_ids_success_auto_net(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_6b83b0cc","line":5966,"range":{"start_line":5966,"start_character":34,"end_line":5966,"end_character":56},"in_reply_to":"3f79a3b5_3d0e618c","updated":"2018-09-13 19:19:39.000000000","message":"its fine anyway, I don\u0027t think it would be error prone, as it will be just picking a value from predefined list.","commit_id":"68011c40ae2ab0900674408a88f62a60a802fef7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c5f02c06b60d42d66fe84c12f57569be4decdb5e","unresolved":false,"context_lines":[{"line_number":5963,"context_line":"    def test_validate_requested_port_ids_raise_sriov(self):"},{"line_number":5964,"context_line":"        self._assert_validate_requested_port_ids_raises("},{"line_number":5965,"context_line":"            exception.AttachSRIOVPortNotSupported,"},{"line_number":5966,"context_line":"            {\"binding:vnic_type\": model.VNIC_TYPE_DIRECT},"},{"line_number":5967,"context_line":"            attach\u003dTrue)"},{"line_number":5968,"context_line":""},{"line_number":5969,"context_line":"    def test_validate_requested_network_ids_success_auto_net(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_3d0e618c","line":5966,"range":{"start_line":5966,"start_character":34,"end_line":5966,"end_character":56},"in_reply_to":"3f79a3b5_e2244f0f","updated":"2018-09-13 15:55:19.000000000","message":"You shouldn\u0027t do that because it runs the risk of introducing random failures, which are never fun to debug. If we really cared, we\u0027d parameterize/duplicate this test but I guess this is good enough","commit_id":"68011c40ae2ab0900674408a88f62a60a802fef7"}]}