)]}'
{"nova/tests/functional/regressions/test_bug_1787606.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"5c05a5dd433811989625951fde4321563811432b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        nova.tests.unit.image.fake.stub_out_image_service(self)"},{"line_number":47,"context_line":"        self.addCleanup(nova.tests.unit.image.fake.FakeImageService_reset)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        self.flags(compute_driver\u003d\u0027fake.FakeRescheduleDriver\u0027)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        self.start_service(\u0027conductor\u0027)"},{"line_number":52,"context_line":"        self.start_service(\u0027scheduler\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_63b99aea","line":49,"updated":"2018-09-13 16:47:22.000000000","message":"a bit of a comment would be helpful to explain that we force the first spawn to fail in order to test reschedules.","commit_id":"20b667a65bf577c594520f752fe92d7d2b667c2f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"18af23e4827bff3acfb2b6532a646f5b6c386761","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            \u0027name\u0027: \u0027server\u0027,"},{"line_number":68,"context_line":"            \u0027imageRef\u0027: self.image_id,"},{"line_number":69,"context_line":"            \u0027flavorRef\u0027: self.flavor_id,"},{"line_number":70,"context_line":"            \u0027min_count\u0027: \u00274\u0027,"},{"line_number":71,"context_line":"        }"},{"line_number":72,"context_line":"        self.api.post_server({\u0027server\u0027: server_request})"},{"line_number":73,"context_line":"        # FIXME(lyarwood): Instances should eventually be rescheduled on to an"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_42e7bce4","line":70,"updated":"2018-09-13 15:22:05.000000000","message":"you should probably comment that here, what\u0027s the most important is that the number of instances to create necessarly has to be higher than the number of hosts.\n\nOr just assert it.","commit_id":"20b667a65bf577c594520f752fe92d7d2b667c2f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"18af23e4827bff3acfb2b6532a646f5b6c386761","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        # FIXME(lyarwood): Instances should eventually be rescheduled on to an"},{"line_number":74,"context_line":"        # alternate host after an initial failure."},{"line_number":75,"context_line":"        for server in self.api.get_servers(detail\u003dFalse):"},{"line_number":76,"context_line":"            self._wait_for_state_change(self.api, server, \u0027ERROR\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_42ea5c74","line":76,"updated":"2018-09-13 15:22:05.000000000","message":"well, you only have an ERROR state if all of the instances can\u0027t be spawned on the host they were elected for, nope ?\n\nHere, you should maybe trick the selection (by mocking _get_sorted_hosts) so that all of the instances go to one host1 (and fail) and check that you\u0027re getting ERROR because even if host2 can fulfill the requests, there are no alternates.","commit_id":"20b667a65bf577c594520f752fe92d7d2b667c2f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"5c05a5dd433811989625951fde4321563811432b","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        # FIXME(lyarwood): Instances should eventually be rescheduled on to an"},{"line_number":74,"context_line":"        # alternate host after an initial failure."},{"line_number":75,"context_line":"        for server in self.api.get_servers(detail\u003dFalse):"},{"line_number":76,"context_line":"            self._wait_for_state_change(self.api, server, \u0027ERROR\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_031a2617","line":76,"in_reply_to":"3f79a3b5_42ea5c74","updated":"2018-09-13 16:47:22.000000000","message":"Nevermind, I missed the fakerescheduledriver fixture which forces the first spawn to fail. In that case, that makes the reschedules predictable and given alternates would accept the instances as they have allocation requests, that will work once we fix the bug.","commit_id":"20b667a65bf577c594520f752fe92d7d2b667c2f"}]}