)]}'
{"nova/virt/baremetal/db/sqlalchemy/migrate_repo/versions/010_add_preserve_ephemeral.py":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"de12afae663af1e94dc3e27e1252c17f02263eb4","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            c"},{"line_number":47,"context_line":"            for c in t.constraints"},{"line_number":48,"context_line":"            if not (hasattr(c, \u0027sqltext\u0027) and COLUMN_NAME in str(c.sqltext))"},{"line_number":49,"context_line":"        ])"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    t.drop_column(COLUMN_NAME)"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUH%2F%2FWpk%3D","line":49,"updated":"2014-01-14 18:22:22.000000000","message":"ouch. Sqlite is really painful sometimes. On this specific issues we\u0027ve come up with different solutions in the past (like recreating the table from scratch on the downgrade). Might be nice to make this a common utility or something in db_utils.\n\nI would add that I\u0027m not the biggest fan of reusing code in migrations but in this case, for sqlite testing only it could make sense.","commit_id":"1b7870a42d76d3f91cfd272c4e65deb3a088e1f2"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"6c9c10179f519e8ec2b449836f5ee080e1876f11","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            c"},{"line_number":47,"context_line":"            for c in t.constraints"},{"line_number":48,"context_line":"            if not (hasattr(c, \u0027sqltext\u0027) and COLUMN_NAME in str(c.sqltext))"},{"line_number":49,"context_line":"        ])"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    t.drop_column(COLUMN_NAME)"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUH%2F%2FMYU%3D","line":49,"in_reply_to":"AAAAUH%2F%2FWpk%3D","updated":"2014-01-16 15:32:20.000000000","message":"/me hopes we\u0027ll stop running migrations on sqlite soon...\n\nI\u0027d rather leave this as is or take your approach here (recreate the table from scratch) instead of putting this to a helper function. Just want to discourage people from caring about and using of sqlite :)","commit_id":"1b7870a42d76d3f91cfd272c4e65deb3a088e1f2"}],"nova/virt/baremetal/driver.py":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"de12afae663af1e94dc3e27e1252c17f02263eb4","unresolved":false,"context_lines":[{"line_number":322,"context_line":"        \"\"\""},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        instance.task_state \u003d task_states.REBUILD_SPAWNING"},{"line_number":325,"context_line":"        instance.save(expected_task_state\u003d[task_states.REBUILDING])"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        node_uuid \u003d self._require_node(instance)"},{"line_number":328,"context_line":"        node \u003d db.bm_node_get_by_node_uuid(context, node_uuid)"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUH%2F%2FWm4%3D","line":325,"updated":"2014-01-14 18:22:22.000000000","message":"I don\u0027t believe we need these here do we? Setting the task and instance state already occurs in the compute manager already no?","commit_id":"1b7870a42d76d3f91cfd272c4e65deb3a088e1f2"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"6c9c10179f519e8ec2b449836f5ee080e1876f11","unresolved":false,"context_lines":[{"line_number":322,"context_line":"        \"\"\""},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        instance.task_state \u003d task_states.REBUILD_SPAWNING"},{"line_number":325,"context_line":"        instance.save(expected_task_state\u003d[task_states.REBUILDING])"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        node_uuid \u003d self._require_node(instance)"},{"line_number":328,"context_line":"        node \u003d db.bm_node_get_by_node_uuid(context, node_uuid)"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAUH%2F%2FMbc%3D","line":325,"in_reply_to":"AAAAUH%2F%2FWm4%3D","updated":"2014-01-16 15:32:20.000000000","message":"Setting of this particular task state is done in the default implementation of rebuild() - https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2147 and this method overrides it. So I believe, this is needed.","commit_id":"1b7870a42d76d3f91cfd272c4e65deb3a088e1f2"}]}